From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36CBEC53219 for ; Tue, 28 Jul 2026 17:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H9tbT3MmTWZadkFYtLmnXOyq2+XHjhkh1A8FrJjDKXM=; b=KxzZL1wgEu5Eq6xIyHEM92MSTs kG5pr81or1Y7/tQS4BMwRVFlDbcLVa8QGaYSqQAF5eM0/2P0JaaDX/4c/WhSMMGOuAvOeAeiXSCak QRkv3N7iLiy/OWzcmJntoU0MFh6SMvJNrDcISE5sZN3tfNcArfIxUueYcPUFBgNAF/Hb5uwA8yiTl WlctX6QzAbH74ED+2HfLTXRhyc3jDTxT0awQgZDbGrrvtNBpXv7RAxRo4x/BaZWaVsXCCDgg8Lp9r OhRNy0v5NziCgmHAVnPlsFbNzaVjmOWE43/ne3xB2FcpGQykTdK0xOfR+WKwrd2RGgbCvbojoStkL aqfl3AJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wolCt-00000005tnd-34rw; Tue, 28 Jul 2026 17:03:07 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wolCq-00000005tlX-2aum for linux-mediatek@lists.infradead.org; Tue, 28 Jul 2026 17:03:05 +0000 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so58684a91.3 for ; Tue, 28 Jul 2026 10:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785258183; x=1785862983; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=H9tbT3MmTWZadkFYtLmnXOyq2+XHjhkh1A8FrJjDKXM=; b=WyNGMJeaGfXncq6ykdni6hNIQFM79d3ACxbjJKO78UP2Ei9DR0e7r4rEN+jipbNrj8 QEWlIvP+vsG7OrX57hRtRlK7+zu86ROtyNVXUEdszE7roprS/8+nZ/7KqzWyKY/R4h6s KLCsFSbXQ64A9WXv/x0ICWsylNCxekaYYMiFJkrVBXZjztnaT7UZ5qaN/iCZSKPyUHm5 jdkGWxcpBYsZHhX8DR377THgVHowbU++jQdwGJfXc/DqHXJh8cgjn92+k4D0DfCqSf3G gsbcY3F9V7xjS4lhw1fCH25lzZAfOKcO+d6AZCri8lZM653IB29Zc7u7jMLwxfKiRJxZ R2Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785258183; x=1785862983; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=H9tbT3MmTWZadkFYtLmnXOyq2+XHjhkh1A8FrJjDKXM=; b=AI5pkkyjQ0BJY2LNusyxyAGaAtMFOdl6LxuLpFMtEYgjAjKrxwEsDmrQGM/UD+jPCY yfNmAWvkHoqgPRtE36l6zQ0iDuhAB/VRVYseR+D5NEhCEm4VnJPW+a9Dldy3T6tkneJ1 vhoC/Ivx4eR7NH5/olflb3/u8jN5HQpZ8u8vzRdvyy0SY7M3fpvvDpREWSR6nxN4v/50 GK/0E3pFtxBDGTAZ2G99ib2ZAqRA2oQNucNYcMrljMfo1WFbF8CcjvIITB+UNfukq3c0 hvd91u0/NukUDHGKPQPaydSqQyN5MPYBJbTVHorBhWsBVu9cghSBWIH6E4/qrTI7lQ5h uiAA== X-Forwarded-Encrypted: i=1; AHgh+RrOP0QM5LaztohZg75HzaiJQ0MjD9vtdp2TAI+SLGu+BFuC2o3WvQypSBUNAyVsKaV4A12nFBaM9dHpIEWpmQ==@lists.infradead.org X-Gm-Message-State: AOJu0Yw/D4wgangAd3V6QyinSbguUkTV5glRcnyotKqqxLOOMSrtqJOo iN+aMV2pXA07lxOLeaRO8hBX9gIDIOe4Vxf7EMVnQtNzeKJZxFgGxO2D X-Gm-Gg: AR+sD10loxeqns80dJxFFhTwAb27fpSWTYJJtwH80hCorEBkSVo61rxIQppo/55Wt5O mQklN+rR5z6h5f4YgyURokPv3Tba5PsF5J+9BBN0gXottypm6XKaJ+gzZS5xoRtqXFfJP/CrrfZ VIsWxyD36sU6IpVsIYFjbgzi8ror4troGWkDh+4H5oGYi5jrZWrgrkthRNupZdW7i22efSqMqyt DEUBF0Oq/hOUTbH2pbNGYuZ9JN+a6ViK50RFxtmR+N8DmKWZgyg8tpIF2tbJudOD5Awm+3bWbVE MDyUFgrO0K/gGAzCgqlMntt/IQn2bxfT7uUvLS7Qw2ZxSVpAWn4BuiyME2n7KyB9haoGwnQ66mi aSX+rCpXlLsGE496ijDKhp4m6ElP7XKqGb/kunPm0xzh5NAJeo9ukZNbwdgKogeVaw70/9f2Z42 LFq9D+UeJ9Rnj7Uk4BhnSHHNDCvHwmd4U7oA== X-Received: by 2002:a17:90a:dfc7:b0:36d:9e0b:3801 with SMTP id 98e67ed59e1d1-38f6a33d8c3mr3853027a91.8.1785258183046; Tue, 28 Jul 2026 10:03:03 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f64111441sm1667127a91.1.2026.07.28.10.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 10:03:02 -0700 (PDT) Date: Wed, 29 Jul 2026 02:02:59 +0900 From: Akari Tsuyukusa To: Brian Masney Cc: Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , "open list:COMMON CLK FRAMEWORK" , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , stable@vger.kernel.org, Chen-Yu Tsai , Miles Chen Subject: Re: [PATCH v2 5/6] clk: mediatek: mt8173: fix memory leak on module removal Message-ID: References: <20260707074839.240676-1-akkun11.open@gmail.com> <20260707074839.240676-6-akkun11.open@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260728_100304_659965_8DC4E609 X-CRM114-Status: GOOD ( 25.73 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Brian, On Tue, Jul 28, 2026 at 10:53:00AM -0400, Brian Masney wrote: > On Tue, Jul 07, 2026 at 04:48:34PM +0900, Akari Tsuyukusa wrote: > > clk-mt8173-apmixedsys.c and clk-mt8173-infracfg.c do not call > > platform_set_drvdata() during their driver probe callback, > > but their remove callback calls platform_get_drvdata(). > > This results in platform_get_drvdata() returning NULL, > > which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). > > This leaves clk_data unreleased, causing a memory leak. > > > > Fix this by calling platform_set_drvdata() during probe. > > > > Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock drivers and allow module build") > > Cc: stable@vger.kernel.org > > Signed-off-by: Akari Tsuyukusa > > --- > > drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 ++ > > drivers/clk/mediatek/clk-mt8173-infracfg.c | 2 ++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > > index d7d416172ab3..65dc4489a09c 100644 > > --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > > +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > > @@ -179,6 +179,8 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) > > if (r) > > goto unregister_ref2usb; > > > > + platform_set_drvdata(pdev, clk_data); > > + > > return 0; > > > > unregister_ref2usb: > > diff --git a/drivers/clk/mediatek/clk-mt8173-infracfg.c b/drivers/clk/mediatek/clk-mt8173-infracfg.c > > index fa2d1d557e04..8b69009e1965 100644 > > --- a/drivers/clk/mediatek/clk-mt8173-infracfg.c > > +++ b/drivers/clk/mediatek/clk-mt8173-infracfg.c > > @@ -128,6 +128,8 @@ static int clk_mt8173_infracfg_probe(struct platform_device *pdev) > > if (r) > > goto unregister_clk_hw; > > > > + platform_set_drvdata(pdev, clk_data); > > + > > This patch doesn't compile. > > drivers/clk/mediatek/clk-mt8173-infracfg.c: In function ‘clk_mt8173_infracfg_probe’: > drivers/clk/mediatek/clk-mt8173-infracfg.c:131:36: error: ‘clk_data’ undeclared (first use in this function); did you mean ‘clk_gate’? Sorry for sending you a broken patch. I accidentally built only with ARCH=arm and missed the build failure. While fixing this, I noticed that clk-mt8173-infracfg.c can be converted to use mtk_clk_simple_probe()/remove() instead of adding driver-specific drvdata handling. The helper currently lacks cpumux support, but I have a reviewed patch for it: https://lore.kernel.org/lkml/20260304181024.738391-2-akkun11.open@gmail.com/ (Reviewed-by: Chen-Yu Tsai ) Also, adding PLL support to the helper should allow more MediaTek clock drivers to use the common probe/remove path: https://github.com/TeamYogaBlade2/linux/commit/d991a61887ab76fd83708dffe8e48192e01023d5 Would it be preferable to extend mtk_clk_simple_probe()/remove() with cpumux and PLL support and reorganize this series around it? or should I keep this series focused on the current simple fixes? Best Regards, Akari