From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CFE2C55162 for ; Thu, 30 Jul 2026 11:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1HWoRuuEQ7zJ3vpj2jIwSgIRqCCpU7QeZRVoWtE84e0=; b=WNvDdAhNO9RHvIfhIhGbF522Q5 TwH6N/Xpwv6XuYsNoIwwwROiu/dVPoGcf2xJzxaO90QxN6/JnmxmocbkN3aMAlw8SShIUmTj0mUGa ehKpjmEcPutdc2IJkx0UbGPeGDY6kQ51wUa2WpLQKAvNiptzAi8wT79AvlXmc6B7fXOrkd+gwy5zt DEkDZq4IHUY4YMT9vFv0AYKzc4wuZHa3XPr4fFnSTOol8avkyaofRkzqP586KiAQypu7yMUZ1R2fh cJevJefCPuuxOaUxcmXxV7w9p3WOrkUE/fwZ4uikpW8GirZdko5QTTzVYRSiVulG4zE4kBvkJXeXp u07CHeVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpOaZ-0000000AIyG-3RkS; Thu, 30 Jul 2026 11:06:11 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpOaW-0000000AIx5-13Rn for linux-mediatek@lists.infradead.org; Thu, 30 Jul 2026 11:06:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785409567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1HWoRuuEQ7zJ3vpj2jIwSgIRqCCpU7QeZRVoWtE84e0=; b=G5VyDAXTvTR4Izyyp+2kTy9QRhcAUEUe8S5DVyfxRLPU5z8JnqSqvcYyDxM9NL4r2N9Osl zg78jVb272tOA0CzfZfullU4LN0bG2bgAd5VlEjK77qOyLWyvLyFdYmGKAUZm/S8DGAtZj ON4mRssQpzHiCK6Z+J26Pi6QwepNqf4= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-6aqa2dfIPHi3sJ1BAAVjBg-1; Thu, 30 Jul 2026 07:06:03 -0400 X-MC-Unique: 6aqa2dfIPHi3sJ1BAAVjBg-1 X-Mimecast-MFC-AGG-ID: 6aqa2dfIPHi3sJ1BAAVjBg_1785409563 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-81ebb5e11caso63914577b3.2 for ; Thu, 30 Jul 2026 04:06:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785409563; x=1786014363; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=1HWoRuuEQ7zJ3vpj2jIwSgIRqCCpU7QeZRVoWtE84e0=; b=a9Ur74MMApeUuoZwkLwnOAZIcUYGvLu2r+2wNt9WUajKbu8iyGVsqcdq/trJyCnvkZ lGRLJhKcCl6Fo7IT+QjsTtn2zwCF5EQr3eMVIfzFlr5hL46ETB6C1tLudGCeTbiJtg0i 126ADz7AABOdg5YipNyHP4eBqTWN/5oykdvQz4KDllj5bChzzf7odEsAncV2Dp7RSVOJ A2P+jNXCnOvw0WWPTc4m4kLZVMxPixGb0CMiNeLRNsJ1yUx3NAN4hSmt29OudvsdyifQ mL0RKjGjqNGyvSxvqGcWZJsR5IM1gzrkXZFc+DSbJY23ZBWtTl803xgQCcJyxpgOrwaY eHtA== X-Forwarded-Encrypted: i=1; AHgh+Rq0wV3DmdBV5Ju6FYrvznjfY8PaekJG0Gntigdil3sTyNfZIMsOgF4saTABZ7fpZMzWOISYNqsyLHnM7niZgw==@lists.infradead.org X-Gm-Message-State: AOJu0Yx16egDT5Q68pqLlGwGUqHW25onz8+99AZ7RJjo1vfP7AnLvMbZ xgdWwTHj+sk7nJsK1tsftmfGdUW8yahNbHWLJf6Tf1r21Y1Jc4ulUYRIEiSISF2QCwycbncOLdz 6672uVPJu/Offz26q2U7R+Zh5owlgq3vYSWp2eGw10+0dPAmQ6HmDKBrALzVUOCvT4nfZte4Hwg == X-Gm-Gg: AR+sD132+WJqPrK1Z4hMwx0m3hx3GcDGeSJnYLADCEoKgzbQt7rnfJeEvoL56EK8ltR KKvrfO2Xmf8ii1IZ1bSeiE5ioO5H+4RiyuR1/7Oow5+V4icJ5ku2Q2X1svdyF2V81Ma3nvFMsOu BxXwH2TBF022LAUbCdj8SxX0Bl8HlOD+4i57D4MJ03qqlA7NLKz21feyAmaMoQIDT5O1esLQoFE mi/aMOxGfdaUy7s1iAZXdxVGJeAIcfN4BRul7uU9/9+qh1ed0GGlNPBjGBhcvWp7GiFeQvWbWoz u34QZOUzqNxpQ9GPuCVXxJHQGGTJl0T4pa2SWzVKO3PT+KtK6QVDkFT92ixQiybk4dXZFC/NdpL Vb904BWBUw8za0eE7FLuAaIMmQQ4ZzkhcvIk= X-Received: by 2002:a05:690c:6802:b0:7ff:1a06:472 with SMTP id 00721157ae682-81fb8953b7dmr15182027b3.4.1785409563059; Thu, 30 Jul 2026 04:06:03 -0700 (PDT) X-Received: by 2002:a05:690c:6802:b0:7ff:1a06:472 with SMTP id 00721157ae682-81fb8953b7dmr15181697b3.4.1785409562604; Thu, 30 Jul 2026 04:06:02 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fb8b2975csm7687837b3.48.2026.07.30.04.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 04:06:01 -0700 (PDT) Date: Thu, 30 Jul 2026 07:05:58 -0400 From: Brian Masney To: AngeloGioacchino Del Regno , Chen-Yu Tsai Cc: Stephen Boyd , Matthias Brugger , Alessio Belle , Luigi Santivetti , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, imagination@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Icenowy Zheng , YoungJoon Lee Subject: Re: [PATCH v4 0/5] powervr: MT8173 GPU support Message-ID: References: <20260728091804.382753-1-wenst@chromium.org> <36f2775a-d332-4913-8e9e-ca0429c3f713@collabora.com> MIME-Version: 1.0 In-Reply-To: <36f2775a-d332-4913-8e9e-ca0429c3f713@collabora.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: b4n2Vl15G5Rkijc0-1uRnbThWR0Xj6vOu8ZJQzoNeH4_1785409563 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260730_040608_361038_74072B2A X-CRM114-Status: GOOD ( 36.62 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Angelo and Chen-Yu, On Thu, Jul 30, 2026 at 10:23:14AM +0200, AngeloGioacchino Del Regno wrote: > On 7/30/26 06:51, Chen-Yu Tsai wrote: > > On Tue, Jul 28, 2026 at 10:33 PM AngeloGioacchino Del Regno > > wrote: > > > > > > On 7/28/26 15:13, Chen-Yu Tsai wrote: > > > > On Tue, Jul 28, 2026 at 9:10 PM Brian Masney wrote: > > > > > On Tue, Jul 28, 2026 at 05:17:58PM +0800, Chen-Yu Tsai wrote: > > > > > > Hi everyone, > > > > > > > > > > > > This is v4 of my MT8173 PowerVR GPU support series. > > > > > > > > > > > > This time around Mesa was ready for basic testing, using both vulkanmark > > > > > > and glmark2-es2-drm (with Zink). Details below. > > > > > > > > > > > > Changes since v3 (all in the clk driver patch): > > > > > > - Changed pm_runtime_put() to pm_runtime_put_sync() > > > > > > - Added missing of_node_put() in remove function > > > > > > > > > > > > Changes since v2 (all in the clk driver patch): > > > > > > - Made COMMON_CLK_MT8173_MFGTOP depend on PM > > > > > > - Needed since the driver implements PM domains using the generic PM > > > > > > domain library, which also depends on PM > > > > > > - Fixes build breakage (kernel test robot) > > > > > > - Fixed "RST_DELAY_CNT" name (Brian) > > > > > > - Dropped unused mfg_desc (Brian) > > > > > > - Added check of clk_prepare_enable()'s return value in > > > > > > clk_mt8173_mfgtop_power_on() (Brian) > > > > > > - Saved error value for return in IS_ERR(data->clk_26m) branch > > > > > > (Dan Carpenter / kernel test robot w/ smatch) > > > > > > > > > > > > Changes since v1: > > > > > > - Adapted to changed DT bindings > > > > > > - Dropped driver change > > > > > > - Use same power domain for "a" and "b" GPU power domains > > > > > > > > > > > > > > > > > > This series enables the PowerVR GPU found in the MT8173 SoC, found in > > > > > > some Chromebooks. > > > > > > > > > > I'm making a pull for Stephen for the clk changes. Should patches 1,2,4 > > > > > go through the clk tree? Patches 3,5 go through the DRM tree? > > > > > > > > Only patches 1 and 2 should go through the clock tree. > > > > > > > > Patch 3, 4, 5 can all go through the soc tree if Angelo wants to pick up > > > > DT binding patches. Otherwise I can push patch 3 through drm-misc. > > > > > > > > > > Not sure if I can really take the DRM bindings patch through soc. > > > > > > I will take the devicetree ones exactly right now, even though it's going to > > > give warnings. > > > > Apologies for missing this, but the first DT patch depends on the clk DT > > bindings patch for the clk ID macros. This is causing build errors in > > linux-next right now. > > > > Not sure how we can fix this right now. > > > > Brian, would it be possible for you to split out that patch into a > > separate immutable branch for Angelo to merge? Yes, I can split things out and make an immutable branch this morning. But it sounds too late for that. > > > > Otherwise Angelo might need to drop the DT patches until the next cycle. > > Yeah, that's so bad. > I'd be happy to be able to resolve this, but it's too late on my side. > > I should've checked the DT patches more carefully, my bad: I got a bit too excited > to finally see this PowerVR stuff working on MT8173 and going upstream. > > Sadly, I have to drop the devicetree patches :-( Chen-Yu: Could Angelo add an Acked-by to the three patches, and then I send Stephen an additional pull with just those patches? Do you think he'd pull that? Brian