From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0A6AC5516D for ; Thu, 30 Jul 2026 18:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=57rmP4vhcSTbGsoBnLah+TzWrTa5sRCpdridw9cY9ZA=; b=bK/5iv+HrUjqtay+FUT5tBG4OG dtgqFKHU8DXVANquli52wPo/HJ3kp0JxYF9z88PFsDs79VsH7iunaNTf79Zkl2i7/lW5rihSUrRb9 ZfL7yR2VVx53zPTRy/z0Q0fi09bUbWCPc+8aXqOF9PE39C4voXzJGbTRA13Vrxzy0qbF1FhggML7X 2eQhO/nztRUWmVrf9UMRn9+tNZ+RafXa+zf6FVv6Uql6G+HW0COTCwQCpDXiEMcxK6cikIUj1zipV pASsJcgF0FWE9f4072ZgBCQMpekUOoZwwXPRRTKQ21NMCRQ5Lgs1QR2NL3oCyTiG7j3s6z9o6jqce F/PmtRMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpVPE-0000000B9ZE-035y; Thu, 30 Jul 2026 18:22:56 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpVPB-0000000B9YK-1O1H for linux-mediatek@lists.infradead.org; Thu, 30 Jul 2026 18:22:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785435771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=57rmP4vhcSTbGsoBnLah+TzWrTa5sRCpdridw9cY9ZA=; b=Bgs+D2/w0zk0FPCceFytKcRxM33AObSpgssoBr7mxH/T9VQYwHuEVVwPuqSCDlsRoBWU1G HFZxZiAoJrg30PfEvvQLf1NoixmZC5HPig8EP/EkQGVYnn99S5Xd5bPk0HSeydwmlXLHRS om0lOn9GUwTwZTmH07weYwYmOwS+QIQ= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-D8V6JGejOH-F774MYT-NDQ-1; Thu, 30 Jul 2026 14:22:50 -0400 X-MC-Unique: D8V6JGejOH-F774MYT-NDQ-1 X-Mimecast-MFC-AGG-ID: D8V6JGejOH-F774MYT-NDQ_1785435770 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-81bee860fb7so3894767b3.3 for ; Thu, 30 Jul 2026 11:22:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785435770; x=1786040570; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=57rmP4vhcSTbGsoBnLah+TzWrTa5sRCpdridw9cY9ZA=; b=nFD8keQqQAjLsRnbjjx9xsiALpHE4QBji39UuStpWnbuiTpOrdKCq3dyvgK//m16WX 5WLFQ3xNL4o6N5kzKSM1rLrVxlNWpsZLjE5KNQEK5LTZOAzpAfpNcEgYr3NHjXqrIj8K nrORKJgGx7LKXyHeAoCYGPOZiG1Qn3C8uDqQOKEdEdQW31LdWnryang9h9vNhF53rV+t z5Qk2nkU7vQ9E3er2oRjxdgmf1qNGu9Waw/AJT819MbBpGINiyh5Rp6C26+YkfP8hr+7 LCFksnEFAIO8SEzS/B+5mb1lX9JI4cc/l6Qs0SnMhQEgSN9zsceTfNo08lQR/TCu5SGI kzcQ== X-Forwarded-Encrypted: i=1; AHgh+RpzQ5u+M5lN6NQT0Cs3rJ7Ls07vmyx+H3Dxi0P9ZpEdBpyjgev/V71XCiWvCUV6yv0cWE94QS2XS/de0S+zbA==@lists.infradead.org X-Gm-Message-State: AOJu0Yzgxn/T4WVfv+FICfQCB75PqlljOLaPziiMEJ9QJje6z1dgrptB dtgJ2ygwfK41WlcIcUIILlrE/ry9jSts+5qOnVvzImteEGG2kHh8FQfK6ZxEO8q33/IAcp7XO53 Aojhx6rLsGk9nAyEewcuhLCSUSraJcNpvaPI8EZCIRGZUVWsoplJuOOlglDvMekTIyEGXzCB9nQ == X-Gm-Gg: AR+sD12tmi5uXXHn6v6jODWcACxRP49eO7Tl6eZXKDdEu2ydb8X1LM61QE/cRnZUI3J PtH7NW/u8slOeG+JsGNtWd1U9BZOBFeBIGTFGUjrZ3nk5YGreTho1lCsM+S3GixF/6uktd6zf0Y R7pFXofMDIZVRsJhx9YSnxlsXN8/CZKGodDvcziOFi6xqW2Yxj8FBwPD5G6bZA3RSdyUVz0Bac9 Udzvcjy74Ba4BmUY5JpZp5xD5f3qFjfnvbi70hpxcUkoh6DLIbBbEabTVrYOnmmghtxlN3eXDvi MlMpoDZfNqH2+U/JVOG6Q0Tfju6FEEjf432RSBEvMJhJks8IVWKFMjVrwzHRZx9DJTwi5pOghp1 C0CFAPxLReyFVbFeG6bde7FjGqsjLyPDmM/g= X-Received: by 2002:a05:690c:3705:b0:7f4:fad5:2087 with SMTP id 00721157ae682-81fb8b36a91mr27760227b3.38.1785435769585; Thu, 30 Jul 2026 11:22:49 -0700 (PDT) X-Received: by 2002:a05:690c:3705:b0:7f4:fad5:2087 with SMTP id 00721157ae682-81fb8b36a91mr27759957b3.38.1785435769087; Thu, 30 Jul 2026 11:22:49 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fc4175a04sm2847377b3.15.2026.07.30.11.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 11:22:48 -0700 (PDT) Date: Thu, 30 Jul 2026 14:22:45 -0400 From: Brian Masney To: Louis-Alexis Eyraud Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Chun-Jie Chen , Philipp Zabel , Edward-JW Yang , Richard Cochran , Chen-Yu Tsai , kernel@collabora.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Conor Dooley , Irving-CH Lin Subject: Re: [PATCH v4 00/24] MT8189: Add support for system and base clock controllers Message-ID: References: <20260729-mt8189-clocks-system-base-v4-0-e356b813a64c@collabora.com> MIME-Version: 1.0 In-Reply-To: <20260729-mt8189-clocks-system-base-v4-0-e356b813a64c@collabora.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: njhpfXiu_lAXUxNwWDZ4JUKWRm4fwI7WKjj7IZ-RHSM_1785435770 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260730_112253_520265_2AFFBFEA X-CRM114-Status: GOOD ( 38.28 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Jul 29, 2026 at 12:02:44PM +0200, Louis-Alexis Eyraud wrote: > This series is a continuation by AngeloGioacchino Del Regno and I of a > previous series ([1]), that adds the clock controller support for > the Mediatek MT8189 SoC and its variants (MT8371, MT8391). > > The first major changes is the split of the series in two: > - one for all basic clock controllers including system ones (this > series) > - one for the multimedia and graphics related clock controllers (to be > send in the future) > > We chose to separate the multimedia clock drivers from the base system > ones, as there is currently an unsolvable inter-dependency between the > power domains and multimedia clocks; the power domains need a > dual-stage bring-up, where only a part of the multimedia clocks are > accessible in the first power domain powerup stage, and the rest when > the second stage (SRAM enablement) is done. > The current workarounds for this issue, such as removing the is_enabled > operation from the impacted clock controllers clk_ops table or > let the multimedia power domain always on, were quickly discarded > for upstream. > > The second major change is the dt-bindings patch ([2]) that got heavily > reworked, not only because of the split choice. We took the opportunity > to regroup in the MT8186 clock and system clock dt-bindings the > description of several other Mediatek SoC (MT8188, MT8192 and MT8195) > and add in them the MT8189 new ones. > The rationale is to ease maintainability and have common files for > several currently supported SoC or new future ones, that have the same > kind of clock controller design. > > Finally the pending remarks from peer reviews on the v6 revision of [1] > were also taken into account and new fixes and cleanups were also > added. > > A more detailed changelog between [1] and this series: > - Removed multimedia and graphics related clock controllers code and > definitions from series > - Added new dt-bindings patches to factorise existing MT8188, MT8192 > and MT8195 in MT8186 clock dt-bindings > - Heavily modified the MT8189 dt-bindings to add new compatibles > in MT8186 clock dt-bindings > - Created a new dt-bindings include for the MT8189 reset controller > definitions (include/dt-bindings/reset/mediatek,mt8189-resets.h) > - Removed unnecessary `syscon` compatible fallback from MT8189 base > clock controllers > - Added missing 'mediatek,mt8189-fhctl' compatible declaration in > dt-bindings > - Modified Kconfig to COMMON_CLK_MT8189 be tristate (and not bool) to > allow all MT8189 clock controller drivers to be built as modules (it > was partial) > - Fix pll unregisters in clk_mt8189_apmixed_probe error case > - Reparent several clocks to correct 26M references in clk-mt8189-bus.c, > clk-mt8189-topckgen.c and clk-mt8189-vlpckgen.c > - Removed CLK_SET_RATE_NO_REPARENT flag from mfg_sel_mfgpll > - Rename TOPCKGEN_fmipi_csi_up26m clock to fmipi_csi_up26m to remove caps usage > - Implemented reset controllers in clk-mt8189-ufs.c > - Updated all file headers to update copyrights and add all authors > - Added all co-developed-by trailers > > The series is based on linux-next tree (tag: next-20260728) and has > been tested on Mediatek Genio 520-EVK (MT8371) and 720-EVK (MT8391) > boards, with hardware enablement patch series ([3]), and on Genio > 510-EVK (MT8370, variant of MT8188) and Genio 1200-EVK (MT8395, > variant of MT8195). > > [1]: https://lore.kernel.org/linux-mediatek/20260309120512.3624804-1-irving-ch.lin@mediatek.com/ > [2]: https://lore.kernel.org/linux-mediatek/20260309120512.3624804-2-irving-ch.lin@mediatek.com/ > [3]: https://lore.kernel.org/linux-mediatek/20260701-add-mediatek-genio-520-720-evk-v2-0-19d5da4ef984@collabora.com/ > > --- > Changes in v4: > - Rebased on next-20260728 tag > - Added patches 9 to 14 to add new clock ops data set for PLL and > PLL-FHCTL to handle a new PLL switch logic for PLL control and BAR > reset, supported by MT8189 SoC > - Patch 15: > - Removed useless includes (B. Masney) > - Fixed variable declaration order in clk_mt8189_apmixed_probe (B. > Masney) > - Added missing pwr_reg setting setting in PLL_SETCLR macro (B. > Masney, Sashiko) > - Added en_set_reg, en_clr_reg, rst_bar_reg, rst_bar_set_reg and > rst_bar_clr_reg fixed offsets and new mtk_pll_setclr_ops ops > setting in PLL_SETCLR macro > - Added pwr_reg offset values in apmixed_plls array > - Fixed rst_bar_mask for mainpll univpll, and mmpll in apmixed_plls > array to match rst_bar set/clr reg settings > - Fixed factor ratio for mainpll_d4_d8, tvdpll1_d16, tvdpll2_d16 and > osc_d16 clocks (Sashiko) > - Link to v3: https://lore.kernel.org/r/20260720-mt8189-clocks-system-base-v3-0-8e6d99ab3ad2@collabora.com > > Changes in v3: > - Rebased on next-20260717 tag > - Added Fixes tags to patches 1, 2 and 3 > - Reworded patch 8 subject and description messages > - Updated Reviewed-by and Acked-by trailers > - Link to v2: https://lore.kernel.org/r/20260709-mt8189-clocks-system-base-v2-0-2926da3db6cf@collabora.com > > Changes in v2: > - Rebased on next-20260708 tag > - Added patch 1,2 and 3 to make the #clock-cells a required property in > MT8186, MT8192 and MT8195 clock controller dt-bindings > - Patch 5: > - Removed conditional blocks to check clock-cells property presence > for MT8188 clock controller compatible > - Reworded commit message to remove the note (no more applicable) > - Fixed incorrect property value in else block for #reset-cells > property check. > _ Removed from patch 9 conditional blocks to check clock-cells property > presence for MT8189 clock controller compatible > - Fixed missing MODULE_DEVICE_TABLE in patches 10, 11 and 12. > - Added devicetree series link in cover letter > - Link to v1: https://lore.kernel.org/r/20260701-mt8189-clocks-system-base-v1-0-2b048feea50a@collabora.com > > --- > Louis-Alexis Eyraud (24): > dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8186 > dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8192 > dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8195 > dt-bindings: clock: mediatek: reorder MT8186 compatibles > dt-bindings: clock: mediatek: regroup MT8188 dt-bindings into MT8186 > dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186 > dt-bindings: clock: mediatek: regroup MT8195 dt-bindings into MT8186 > dt-bindings: clock: mediatek: Add MT8189 system/base clocks and resets > clk: mediatek: Harmonize mtk_pll_fenc related symbol names > clk: mediatek: pll: Add BAR reset register offsets > clk: mediatek: pll: split default prepare/unprepare callbacks > clk: mediatek: pll: Add ops for PLLs using set/clr regs > clk: mediatek: pllfh: Add configurable clock ops to mtk_pllfh_data > clk: mediatek: pllfh: Add ops for PLLs using set/clr regs > clk: mediatek: Add MT8189 apmixedsys clock support > clk: mediatek: Add MT8189 topckgen clock support > clk: mediatek: Add MT8189 vlpckgen clock support > clk: mediatek: Add MT8189 vlpcfg clock support > clk: mediatek: Add MT8189 bus clock support > clk: mediatek: Add MT8189 dbgao clock support > clk: mediatek: Add MT8189 dvfsrc clock support > clk: mediatek: Add MT8189 i2c clock support > clk: mediatek: Add MT8189 scp clock support > clk: mediatek: Add MT8189 ufs clock support > > .../bindings/clock/mediatek,mt8186-clock.yaml | 128 ++- > .../bindings/clock/mediatek,mt8186-fhctl.yaml | 1 + > .../bindings/clock/mediatek,mt8186-sys-clock.yaml | 24 +- > .../bindings/clock/mediatek,mt8188-clock.yaml | 93 -- > .../bindings/clock/mediatek,mt8188-sys-clock.yaml | 58 -- > .../bindings/clock/mediatek,mt8192-clock.yaml | 191 ---- > .../bindings/clock/mediatek,mt8192-sys-clock.yaml | 68 -- > .../bindings/clock/mediatek,mt8195-clock.yaml | 238 ----- > .../bindings/clock/mediatek,mt8195-sys-clock.yaml | 76 -- > drivers/clk/mediatek/Kconfig | 79 ++ > drivers/clk/mediatek/Makefile | 8 + > drivers/clk/mediatek/clk-mt8189-apmixedsys.c | 203 ++++ > drivers/clk/mediatek/clk-mt8189-bus.c | 200 ++++ > drivers/clk/mediatek/clk-mt8189-dbgao.c | 98 ++ > drivers/clk/mediatek/clk-mt8189-dvfsrc.c | 58 ++ > drivers/clk/mediatek/clk-mt8189-iic.c | 122 +++ > drivers/clk/mediatek/clk-mt8189-scp.c | 77 ++ > drivers/clk/mediatek/clk-mt8189-topckgen.c | 1025 ++++++++++++++++++++ > drivers/clk/mediatek/clk-mt8189-ufs.c | 133 +++ > drivers/clk/mediatek/clk-mt8189-vlpcfg.c | 116 +++ > drivers/clk/mediatek/clk-mt8189-vlpckgen.c | 285 ++++++ > drivers/clk/mediatek/clk-mt8196-apmixedsys.c | 2 +- > drivers/clk/mediatek/clk-mt8196-vlpckgen.c | 2 +- > drivers/clk/mediatek/clk-pll.c | 135 ++- > drivers/clk/mediatek/clk-pll.h | 13 +- > drivers/clk/mediatek/clk-pllfh.c | 15 +- > drivers/clk/mediatek/clk-pllfh.h | 3 + > include/dt-bindings/clock/mediatek,mt8189-clk.h | 433 +++++++++ > include/dt-bindings/reset/mediatek,mt8189-resets.h | 17 + > 29 files changed, 3135 insertions(+), 766 deletions(-) Should there be a new MAINTAINERS entry added? There's currently 221 files under drivers/clk/mediatek/ and there's currently only one mediatek maintainer entry: MEDIATEK MT6735 CLOCK & RESET DRIVERS. Is there anyone from mediatek (or elsewhere) that could act as a clk subsystem maintainer similar to what the other SoC vendors do? Help with reviews, send in pulls, etc? I'll review this one in a bit but this subsystem is big enough that it really should have some support from the vendor (or via a consulting company) in some form. Brian