From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0053C55184 for ; Mon, 3 Aug 2026 15:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jF3MmI86y2BChVqhm8vdVAw/xAkrV44X6MqoOsmdA58=; b=nU21l7IcTUIu7Gq6yPXQSbOi7V jAVIpFn5ykvDn/juZyKrvIGTk3XKukSCzdMKhTt0OGPz00evABsgoFP23TGErG5mFOc9RtbIiakT6 d40LpDwL8JIPdcGKhXydm9vGhBUKj4VKEr1GudUymHoTfwJCFNGvvsXP7ql7tsLbW1Ppwp+WqEQYg dDApb2t2YKyIW6eCnlNEhjpPJ6ccZGcajWnEdR2qdJ9JAU69Bvd8tNjQoy/LBiu+gGJy8G/FsbheR QMW8/iCVjdDe680tPRpnItb4XS2/UrvX0NVfQWlE5MARnGX6v5kcCuZldpUMGTk2cN/20Asih6joc r0ZY3eGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wquL7-0000000HTwu-2HKm; Mon, 03 Aug 2026 15:12:29 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wquL4-0000000HTvj-37lm for linux-mediatek@lists.infradead.org; Mon, 03 Aug 2026 15:12:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785769945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jF3MmI86y2BChVqhm8vdVAw/xAkrV44X6MqoOsmdA58=; b=HHUj5lacBpmFjEes7/hIsyN8s3nTBWen7w/vLY3FXSL8hNDAcvCtHFMXjufvb/XXXZeWy2 X2CPJXcvCGq3Ga9kazQ1YEp2G8SEG/qboI9h+UIVos5tjfxsUdm59+fu6gHVyBje6Pjjmm qtLmGNbKPcQk4mJJwyQ0v97LiYT/Bg8= Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-jzcQZ0hxMD-qajwFN3XCMA-1; Mon, 03 Aug 2026 11:12:23 -0400 X-MC-Unique: jzcQZ0hxMD-qajwFN3XCMA-1 X-Mimecast-MFC-AGG-ID: jzcQZ0hxMD-qajwFN3XCMA_1785769943 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-66850cde3a8so5162431d50.2 for ; Mon, 03 Aug 2026 08:12:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785769943; x=1786374743; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jF3MmI86y2BChVqhm8vdVAw/xAkrV44X6MqoOsmdA58=; b=ohqysqHEGEvnoeV3O7uIcSbOz7uD1vLBbdC0m/ckOq5Jon0So2hroN02fudCs7MzRC ayJManqYTSHP+o8nsHOStMYK+X4t5YReqGAk5S660byvATtbGMtVaMiigqbU1LK8FzKP +2LivRreP9Qwkm5fFiKY+z3bvjqdTbGDty4UAzTJV/cKbXSasViEV129hdYyLMQlisEg xqIzsOYJmPNtX5g/Y1jwdOFkf+PKzL8UwSQmUr/j8Q1ONpltHxlygTj3dctFr3CUAgZX tVG8sxAAaVLEXBTDfkaIdDlunEsfptR7H4R5M3d99Il/wh9aezHbhgJOmE86Rt72+aBe 1SyA== X-Forwarded-Encrypted: i=1; AHgh+RqjTcWwwBfTV9lBS4Zhy5uqCtRtxzV0oEJUwX5KeKBxBXVoDRotClnO6C+aIpamgxNeOG4h32nZlJEiPCiM6w==@lists.infradead.org X-Gm-Message-State: AOJu0YyjPrl6cET6HgZax/fo+wXeUO3WZQv+yj+o1KSpjiX3N61K9dV6 VFlzyU4iwG1pQeiHPOrTUqvLc0NgUuj6Y97YqRiTppiSsGctPCMYixBs9rrWeSZLJL41xW4M/5M TJkqQ6+0klJG9I6uUrV9fbdiShxwIcskY1Ll8SzWdktNiToMynyuCGNO7AhpIQAqdv397Flbzlg == X-Gm-Gg: AR+sD10Qg7JRP8XVa07s+nF/Mzyz9QIzajPaTEUi5BYZu9vYxIDzfllMbugMnokMpsg D1L3niJE16k3ggKBER2kR3HmCwhqh3QK/VOblUsOTSNqmSXCX+KuSORw9eM/wCHvk25Cq2l6qxl JRYvSb5rKOQjU980nj1lBAqJfzi7fB9lIOZP3dNk8u8JHesmLpwkOAqca/1rYnYXioLmxPXb+Zm kQ4FtjySzDXofyygdd44C8HeGV+gj6UqjL4DgKOsvRmXUlnosT9QRJrECwwX/WbwSchAVZYfz12 4rjz/wn4ee8zf2+wYQoRloOK7WS9nbqM4Rm0lmipA0LszZi1rribX/iRYj+aa9hzZIC38NhgoGu Rrlj9ZQOykqRAvnq23/BNCuGVcK4/+TFTkMs= X-Received: by 2002:a05:690e:2244:b0:663:9a0a:7b80 with SMTP id 956f58d0204a3-6694f08c75fmr9214986d50.19.1785769942613; Mon, 03 Aug 2026 08:12:22 -0700 (PDT) X-Received: by 2002:a05:690e:2244:b0:663:9a0a:7b80 with SMTP id 956f58d0204a3-6694f08c75fmr9214934d50.19.1785769942042; Mon, 03 Aug 2026 08:12:22 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66948fc7ef2sm5945641d50.13.2026.08.03.08.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 08:12:21 -0700 (PDT) Date: Mon, 3 Aug 2026 11:12:18 -0400 From: Brian Masney To: Louis-Alexis Eyraud Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Chun-Jie Chen , Philipp Zabel , Edward-JW Yang , Richard Cochran , Chen-Yu Tsai , kernel@collabora.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Irving-CH Lin Subject: Re: [PATCH v5 16/25] clk: mediatek: Add MT8189 apmixedsys clock support Message-ID: References: <20260801-mt8189-clocks-system-base-v5-0-ac4410697cc2@collabora.com> <20260801-mt8189-clocks-system-base-v5-16-ac4410697cc2@collabora.com> MIME-Version: 1.0 In-Reply-To: <20260801-mt8189-clocks-system-base-v5-16-ac4410697cc2@collabora.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -K0VOj3m1aIm12ROdDtK9kn9FjeA-8crzUIsJPpzddU_1785769943 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260803_081226_928032_0D923877 X-CRM114-Status: GOOD ( 31.10 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, Aug 01, 2026 at 01:21:02PM +0200, Louis-Alexis Eyraud wrote: > Add support for the MT8189 apmixedsys clock controller, which provides > PLLs generated from SoC 26m. > > Co-developed-by: Irving-CH Lin > Signed-off-by: Irving-CH Lin > Co-developed-by: AngeloGioacchino Del Regno > Signed-off-by: AngeloGioacchino Del Regno > Signed-off-by: Louis-Alexis Eyraud > --- > drivers/clk/mediatek/Kconfig | 13 ++ > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt8189-apmixedsys.c | 203 +++++++++++++++++++++++++++ > 3 files changed, 217 insertions(+) > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index 2c09fd729bab..f67dfb6cd019 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -815,6 +815,19 @@ config COMMON_CLK_MT8188_WPESYS > help > This driver supports MediaTek MT8188 Warp Engine clocks. > > +config COMMON_CLK_MT8189 > + tristate "Clock driver for MediaTek MT8189" > + depends on ARM64 || COMPILE_TEST > + select COMMON_CLK_MEDIATEK > + select COMMON_CLK_MEDIATEK_FHCTL > + default ARCH_MEDIATEK > + help > + Enable this option to support the clock management for MediaTek MT8189 SoC. This > + includes handling of all primary clock functions and features specific to the MT8189 > + platform. Enabling this driver ensures that the system's clock functionality aligns > + with the MediaTek MT8189 hardware capabilities, providing efficient management of > + clock speeds and power consumption. > + > config COMMON_CLK_MT8192 > tristate "Clock driver for MediaTek MT8192" > depends on ARM64 || COMPILE_TEST > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > index d8736a060dbd..66577ccb9b93 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -123,6 +123,7 @@ obj-$(CONFIG_COMMON_CLK_MT8188_VDOSYS) += clk-mt8188-vdo0.o clk-mt8188-vdo1.o > obj-$(CONFIG_COMMON_CLK_MT8188_VENCSYS) += clk-mt8188-venc.o > obj-$(CONFIG_COMMON_CLK_MT8188_VPPSYS) += clk-mt8188-vpp0.o clk-mt8188-vpp1.o > obj-$(CONFIG_COMMON_CLK_MT8188_WPESYS) += clk-mt8188-wpe.o > +obj-$(CONFIG_COMMON_CLK_MT8189) += clk-mt8189-apmixedsys.o > obj-$(CONFIG_COMMON_CLK_MT8192) += clk-mt8192-apmixedsys.o clk-mt8192.o > obj-$(CONFIG_COMMON_CLK_MT8192_AUDSYS) += clk-mt8192-aud.o > obj-$(CONFIG_COMMON_CLK_MT8192_CAMSYS) += clk-mt8192-cam.o > diff --git a/drivers/clk/mediatek/clk-mt8189-apmixedsys.c b/drivers/clk/mediatek/clk-mt8189-apmixedsys.c > new file mode 100644 > index 000000000000..a50a8979b849 > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8189-apmixedsys.c > @@ -0,0 +1,203 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2025-2026 MediaTek Inc. > + * Qiqi Wang > + * Irving-CH Lin > + * Copyright (C) 2026 Collabora Ltd. > + * AngeloGioacchino Del Regno > + * Louis-Alexis Eyraud > + */ > + > +#include > +#include > +#include > + > +#include "clk-fhctl.h" > +#include "clk-mtk.h" > +#include "clk-pll.h" > + > +#include > + > +#define MT8189_PLL_FMAX (3800UL * MHZ) > +#define MT8189_PLL_FMIN (1500UL * MHZ) > +#define MT8189_PLLEN_OFS 0x70 > +#define MT8189_PLLEN_SET_OFS 0x74 > +#define MT8189_PLLEN_CLR_OFS 0x78 > +#define MT8189_RSTBAR_OFS 0x80 > +#define MT8189_RSTBAR_SET_OFS 0x84 > +#define MT8189_RSTBAR_CLR_OFS 0x88 > +#define MT8189_INTEGER_BITS 8 > + > +#define PLL_SETCLR(_id, _name, _reg, _pwr_reg, _en_setclr_bit, \ > + _rstb_setclr_bit, _flags, _pd_reg, \ > + _pd_shift, _tuner_reg, _tuner_en_reg, \ > + _tuner_en_bit, _pcw_reg, _pcw_shift, \ > + _pcwbits) { \ > + .id = _id, \ > + .name = _name, \ > + .en_reg = MT8189_PLLEN_OFS, \ > + .en_set_reg = MT8189_PLLEN_SET_OFS, \ > + .en_clr_reg = MT8189_PLLEN_CLR_OFS, \ > + .reg = _reg, \ > + .pwr_reg = _pwr_reg, \ > + .pll_en_bit = _en_setclr_bit, \ > + .rst_bar_reg = MT8189_RSTBAR_OFS, \ > + .rst_bar_set_reg = MT8189_RSTBAR_SET_OFS, \ > + .rst_bar_clr_reg = MT8189_RSTBAR_CLR_OFS, \ > + .rst_bar_mask = BIT(_rstb_setclr_bit), \ > + .flags = _flags, \ > + .fmax = MT8189_PLL_FMAX, \ > + .fmin = MT8189_PLL_FMIN, \ > + .pd_reg = _pd_reg, \ > + .pd_shift = _pd_shift, \ > + .tuner_reg = _tuner_reg, \ > + .tuner_en_reg = _tuner_en_reg, \ > + .tuner_en_bit = _tuner_en_bit, \ > + .pcw_reg = _pcw_reg, \ > + .pcw_shift = _pcw_shift, \ > + .pcwbits = _pcwbits, \ > + .pcwibits = MT8189_INTEGER_BITS, \ > + .ops = &mtk_pll_setclr_ops, \ > + } > + > +static const struct mtk_pll_data apmixed_plls[] = { > + PLL_SETCLR(CLK_APMIXED_ARMPLL_LL, "armpll-ll", 0x204, 0x210, 18, > + 0, PLL_AO, 0x208, 24, 0, 0, 0, 0x208, 0, 22), > + PLL_SETCLR(CLK_APMIXED_ARMPLL_BL, "armpll-bl", 0x214, 0x220, 17, > + 0, PLL_AO, 0x218, 24, 0, 0, 0, 0x218, 0, 22), > + PLL_SETCLR(CLK_APMIXED_CCIPLL, "ccipll", 0x224, 0x230, 16, > + 0, PLL_AO, 0x228, 24, 0, 0, 0, 0x228, 0, 22), > + PLL_SETCLR(CLK_APMIXED_MAINPLL, "mainpll", 0x304, 0x310, 15, > + 2, HAVE_RST_BAR | PLL_AO, > + 0x308, 24, 0, 0, 0, 0x308, 0, 22), > + PLL_SETCLR(CLK_APMIXED_UNIVPLL, "univpll", 0x314, 0x320, 14, > + 1, HAVE_RST_BAR, 0x318, 24, 0, 0, 0, 0x318, 0, 22), > + PLL_SETCLR(CLK_APMIXED_MMPLL, "mmpll", 0x324, 0x330, 13, > + 0, HAVE_RST_BAR, 0x328, 24, 0, 0, 0, 0x328, 0, 22), > + PLL_SETCLR(CLK_APMIXED_MFGPLL, "mfgpll", 0x504, 0x510, 7, > + 0, 0, 0x508, 24, 0, 0, 0, 0x508, 0, 22), > + PLL_SETCLR(CLK_APMIXED_APLL1, "apll1", 0x404, 0x414, 11, > + 0, 0, 0x408, 24, 0x040, 0x00c, 0, 0x40c, 0, 32), > + PLL_SETCLR(CLK_APMIXED_APLL2, "apll2", 0x418, 0x428, 10, > + 0, 0, 0x41c, 24, 0x044, 0x00c, 1, 0x420, 0, 32), > + PLL_SETCLR(CLK_APMIXED_EMIPLL, "emipll", 0x334, 0x340, 12, > + 0, PLL_AO, 0x338, 24, 0, 0, 0, 0x338, 0, 22), > + PLL_SETCLR(CLK_APMIXED_APUPLL2, "apupll2", 0x614, 0x620, 2, > + 0, 0, 0x618, 24, 0, 0, 0, 0x618, 0, 22), > + PLL_SETCLR(CLK_APMIXED_APUPLL, "apupll", 0x604, 0x610, 3, > + 0, 0, 0x608, 24, 0, 0, 0, 0x608, 0, 22), > + PLL_SETCLR(CLK_APMIXED_TVDPLL1, "tvdpll1", 0x42c, 0x438, 9, > + 0, 0, 0x430, 24, 0, 0, 0, 0x430, 0, 22), > + PLL_SETCLR(CLK_APMIXED_TVDPLL2, "tvdpll2", 0x43c, 0x448, 8, > + 0, 0, 0x440, 24, 0, 0, 0, 0x440, 0, 22), > + PLL_SETCLR(CLK_APMIXED_ETHPLL, "ethpll", 0x514, 0x520, 6, > + 0, 0, 0x518, 24, 0, 0, 0, 0x518, 0, 22), > + PLL_SETCLR(CLK_APMIXED_MSDCPLL, "msdcpll", 0x524, 0x530, 5, > + 0, 0, 0x528, 24, 0, 0, 0, 0x528, 0, 22), > + PLL_SETCLR(CLK_APMIXED_UFSPLL, "ufspll", 0x534, 0x540, 4, > + 0, 0, 0x538, 24, 0, 0, 0, 0x538, 0, 22), > +}; > + > +#define FH(_pllid, _fhid, _offset) { \ > + .data = { \ > + .pll_id = _pllid, \ > + .fh_id = _fhid, \ > + .fh_ver = FHCTL_PLLFH_V2, \ > + .fhx_offset = _offset, \ > + .dds_mask = GENMASK(21, 0), \ > + .slope0_value = 0x6003c97, \ > + .slope1_value = 0x6003c97, \ > + .sfstrx_en = BIT(2), \ > + .frddsx_en = BIT(1), \ > + .fhctlx_en = BIT(0), \ > + .tgl_org = BIT(31), \ > + .dvfs_tri = BIT(31), \ > + .pcwchg = BIT(31), \ > + .dt_val = 0x0, \ > + .df_val = 0x9, \ > + .updnlmt_shft = 16, \ > + .msk_frddsx_dys = GENMASK(23, 20), \ > + .msk_frddsx_dts = GENMASK(19, 16), \ > + .ops = &mtk_pllfh_setclr_ops, \ > + }, \ > + } > + > +static struct mtk_pllfh_data pllfhs[] = { > + FH(CLK_APMIXED_ARMPLL_LL, 0, 0x003C), > + FH(CLK_APMIXED_ARMPLL_BL, 1, 0x0050), > + FH(CLK_APMIXED_CCIPLL, 2, 0x0064), > + FH(CLK_APMIXED_MAINPLL, 3, 0x0078), > + FH(CLK_APMIXED_MMPLL, 4, 0x008C), > + FH(CLK_APMIXED_MFGPLL, 5, 0x00A0), > + FH(CLK_APMIXED_EMIPLL, 6, 0x00B4), > + FH(CLK_APMIXED_TVDPLL1, 7, 0x00C8), > + FH(CLK_APMIXED_TVDPLL2, 8, 0x00DC), > + FH(CLK_APMIXED_MSDCPLL, 9, 0x00F0), > + FH(CLK_APMIXED_UFSPLL, 10, 0x0104), > + FH(CLK_APMIXED_APUPLL, 11, 0x0118), > + FH(CLK_APMIXED_APUPLL2, 12, 0x012c), > +}; > + > +static const struct of_device_id of_match_clk_mt8189_apmixed[] = { > + { .compatible = "mediatek,mt8189-apmixedsys" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, of_match_clk_mt8189_apmixed); > + > +static int clk_mt8189_apmixed_probe(struct platform_device *pdev) > +{ > + const u8 *fhctl_node = "mediatek,mt8189-fhctl"; > + struct device_node *node = pdev->dev.of_node; > + struct clk_hw_onecell_data *clk_data; > + int r; > + > + clk_data = mtk_alloc_clk_data(ARRAY_SIZE(apmixed_plls)); > + if (!clk_data) > + return -ENOMEM; > + > + fhctl_parse_dt(fhctl_node, pllfhs, ARRAY_SIZE(pllfhs)); So I know this is how the existing drivers are written. This calls of_iomap(), and the iounmap is called by mtk_clk_unregister_pllfhs(). I usually like to see things in pairs to make it easier to review where there's some register, and an unregister with the same name. Could the fhctl_parse_dt() call be moved into mtk_clk_register_pllfhs() ? Additionally fhctl_parse_dt() sets some state variables that are never cleared in the unregister: pllfh->state.fh_enable = 1; pllfh->state.ssc_rate = ssc_rate; pllfh->state.base = base; Just a quick glance though I think this is fine. Brian