From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98C3EC624A5 for ; Mon, 31 Aug 2026 15:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uVxBilOuJ3eJRjLFViKxIC+i5050iOvt2YALC/2UHq4=; b=cAcdcrf5/ty0sUuLn7nAfiaOhm tBLbqn73rektw/En/C27W46JJ/xvYszjSVapbea7Px4VA1/e3SZAwsaqMZ5VFRWr2LUYNo+x2O0Am TmcU4a+A+M2REbgtMmQ6ltySm+KRjzPZ/CrplMjgCXQSw4G612QN4cv1jp7HeP79H+HZRj7UPlGaK Nr8fO/MX6RgT4vK7aofmBU699KVFu75U0ZfHB4pjH7zEqg5P2tp20MAcCraLevqkcXTz9ao9wxzSp ZrwdwKjezENEo90coguqCXPk8/amTHPFYbvs8fHatxCrDPXhsdxZibcWd4oRLcCCLOv5bL863Qu/O mBp72bRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x143Q-00000009suo-1cBD; Mon, 31 Aug 2026 15:36:12 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x143O-00000009stU-0gPk for linux-mediatek@lists.infradead.org; Mon, 31 Aug 2026 15:36:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788190567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uVxBilOuJ3eJRjLFViKxIC+i5050iOvt2YALC/2UHq4=; b=MllDFC1FBEdnQNrGZhkaDrBpl2tNnlUR3bV0uqNK9YMcEXl+vOOyvlPNsxPaII6K6UZAJc gQFslQcZjRNKSmxLmBwoMkDrJ9RnjvzFNDzdMM/v37r2kYDWSMMsSvkVmjCxsy5YP/E5J1 4nA6GLfiOEJVEWgW4RwZ7OZ8H3j6moA= Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-858MhGsTNouqJlDkdk2BGQ-1; Mon, 31 Aug 2026 11:36:06 -0400 X-MC-Unique: 858MhGsTNouqJlDkdk2BGQ-1 X-Mimecast-MFC-AGG-ID: 858MhGsTNouqJlDkdk2BGQ_1788190565 Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-66d309b367dso3551848d50.3 for ; Mon, 31 Aug 2026 08:36:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788190565; x=1788795365; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uVxBilOuJ3eJRjLFViKxIC+i5050iOvt2YALC/2UHq4=; b=I389kxCBQ01M06aVLijl4vLwv8rToAv0ett3UmFmOt7oPN2qGxIZ9cVvE827+3wNHX lxMsl03FEvq0YgQaT2EQ6Yq9G/N/sRTKFAHfA1g1eJdDLj9LllfdVCuEot4sEMizNEkT F4oqNJ4FCS2B2I7etjLu85ccT2YYnIL9eZME0kysRZjAkNFiI1OosglFtp+SRRgrvbIq tJ3e1r6V+8JfL8ekSQo0mEZ5rbWjkfG3HMkZzLFjIvtvlFkphNVsHX29j/7uuJrn1KlM q+Gj0ZTbavVDHldlznFgZKvdUYizQSnTGn93TEvpDYnJO1/WViSNIgMTqzQf/iVWiGE1 1PvA== X-Forwarded-Encrypted: i=1; AKwUvBxw4T493abbZHPv+KWKsMFVSh1LS9xIC5j14kOrw+BPHAocHKW0ofOOUtRzGdEhESJ8vTp76oDTCygFL+j9pA==@lists.infradead.org X-Gm-Message-State: AFuF++n9JerdTH1AruyVF+vhva/GhgSs8AQDe8dkfydvRmkWVNdgD5M5 f+8vmAIOfx5DcEIcg43TGh8W7ck5UKIGjglZL0PaAzorIMPSmgwFf7MW6KDM3MQjWUBzR0yjjL9 FMeiNnx7ge4XNq1TlSz2I3KyvhybufXbE+FhEKfHg34IWCkOA+UkADCnfGt1O/hRo/iLmjgnxpw == X-Gm-Gg: AYBFou1wq8jgwCZ2yAAs0RSZq6g9mpH7Q49pBrI/btaVyRgk8bp4sNSDZy9XYo/bzkR QyhL+f3rXIFvjVqN/k7ekdQ1c0U/+Spbd8V28WdaT6kFkrJZyFYGTKBJuEDMpUmmUhfjc03g24A /rBNZsSCu4CmTrXsAZSKDn3rzx23jxgo3xaViKi6TVUKrUHtfgqP5Kzc8tFWLoay8gsbWYw/6d3 YKKYsnOxww8Ag+UQQa5v/S/sqYufBeGGORNPovqHLA+ZXDgDSmYN6bECpDNpTR05gPJyf+eAa2V zrW7PNndlVPUY+cHv1DHv9QcuS2pynUAnw9Fq/2W/Bq9y8z7KlIkFvEBj1tHfQgL9d0Vf3c+s60 = X-Received: by 2002:a05:690e:13c7:b0:66f:8255:9f3d with SMTP id 956f58d0204a3-66f873db9b1mr559410d50.7.1788190565221; Mon, 31 Aug 2026 08:36:05 -0700 (PDT) X-Received: by 2002:a05:690e:13c7:b0:66f:8255:9f3d with SMTP id 956f58d0204a3-66f873db9b1mr559344d50.7.1788190564555; Mon, 31 Aug 2026 08:36:04 -0700 (PDT) Received: from redhat.com ([2600:382:8519:3f74:ab6c:bb55:e9cb:f8d6]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66f7efc9dbfsm2062227d50.9.2026.08.31.08.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2026 08:36:03 -0700 (PDT) Date: Mon, 31 Aug 2026 11:35:55 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?iso-8859-1?Q?L=F3pez?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Liviu Dudau , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 00/45] clk: Make sure clk_init_data is fully initialized (part two) Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -netv7qVh_NPyn2JN-QO3j9UwNDsd5GH_11csPd8x2o_1788190565 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260831_083610_279096_4DF3DB3A X-CRM114-Status: GOOD ( 20.59 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Geert / all, On Fri, Aug 21, 2026 at 10:53:10AM +0200, Geert Uytterhoeven wrote: > Hi all, > > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Hence this series aims to make sure all members are fully initialized, > to avoid such bugs, and to prevent future breakage when converting > drivers to a different method for specifying the parents. > > Part One[1] fixed all cases that I identified to be real bugs, in > response to a crash I saw on BeagleBone Black. > > This series is the clock subpart of Part Two, which fixes remaining > cases that are currently harmless. These are still fragile, and may > cause future breakage when converting drivers to a different method for > specifying the parents. > > Thanks for your comments! > > [1] "[PATCH treewide 0/5] clk: Make sure clk_init_data is fully > initialized (part 1)" > https://lore.kernel.org/cover.1787165329.git.geert+renesas@glider.be > > Geert Uytterhoeven (45): > clk: aspeed: Make sure clk_init_data is fully initialized > clk: at91: Make sure clk_init_data is fully initialized > clk: bcm: iproc: Make sure clk_init_data is fully initialized > clk: berlin: Make sure clk_init_data is fully initialized > clk: cdce925: Make sure clk_init_data is fully initialized > clk: clk-axi-clkgen: Make sure clk_init_data is fully initialized > clk: cs2000-cp: Make sure clk_init_data is fully initialized > clk: davinci: Make sure clk_init_data is fully initialized > clk: fractional-divider: Make sure clk_init_data is fully initialized > clk: gemini: Make sure clk_init_data is fully initialized > clk: highbank: Make sure clk_init_data is fully initialized > clk: hisilicon: Make sure clk_init_data is fully initialized > clk: imx: Make sure clk_init_data is fully initialized > clk: ingenic: Make sure clk_init_data is fully initialized > clk: keystone: Make sure clk_init_data is fully initialized > clk: lmk04832: Make sure clk_init_data is fully initialized > clk: mediatek: Make sure clk_init_data is fully initialized > clk: milbeaut: Make sure clk_init_data is fully initialized > clk: mmp: Make sure clk_init_data is fully initialized > clk: mvebu: Make sure clk_init_data is fully initialized > clk: mxs: Make sure clk_init_data is fully initialized > clk: nomadik: Make sure clk_init_data is fully initialized > clk: npcm7xx: Make sure clk_init_data is fully initialized > clk: nxp: Make sure clk_init_data is fully initialized > clk: pistachio: Make sure clk_init_data is fully initialized > clk: pwm: Make sure clk_init_data is fully initialized > clk: renesas: Make sure clk_init_data is fully initialized > clk: rockchip: Make sure clk_init_data is fully initialized > clk: samsung: Make sure clk_init_data is fully initialized > clk: scpi: Make sure clk_init_data is fully initialized > clk: silabs: Make sure clk_init_data is fully initialized > clk: socfpga: Make sure clk_init_data is fully initialized > clk: spear: Make sure clk_init_data is fully initialized > clk: stm32: Make sure clk_init_data is fully initialized > clk: st: Make sure clk_init_data is fully initialized > clk: sunxi: Make sure clk_init_data is fully initialized > clk: tegra: Make sure clk_init_data is fully initialized > clk: uniphier: Make sure clk_init_data is fully initialized > clk: ux500: Make sure clk_init_data is fully initialized > clk: versatile: Make sure clk_init_data is fully initialized > clk: vt8500: Make sure clk_init_data is fully initialized > clk: x86: Make sure clk_init_data is fully initialized > clk: xgene: Make sure clk_init_data is fully initialized > clk: xilinx: Make sure clk_init_data is fully initialized > clk: zynqmp: Make sure clk_init_data is fully initialized 44 / 45 patches have been added to clk-next. I took it all for simplicity rather than everyone trying to cherry pick just their parts. Geert: The only patch that didn't apply was: [PATCH 27/45] clk: renesas: Make sure clk_init_data is fully initialized I didn't look into it too much. Brian