From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C61FCC88E5C for ; Wed, 16 Sep 2026 08:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SjWIP8bNgzdC4buQnhVS9zvJ7ieVsM0oE8uqr/MRoYM=; b=BDEXpsI64Sr/cFkY0Uq0a8jXCl 1r9wja79fHa3xHVXBh4SzIw8zbiIgjarXbc0FcLqvP0s+DMPN6q1UXrkKlx9LXQsqhbYKUM7raXNz 9gHNyR4MH4NBLvYFFuAYKc3OpDiGNhnazrCPNuKWq1HMyGG9UHcN+l8WtunYhMj0Wx6yJtuYlEKtV QUc2CVob2AUAxmmOpam2wpAeUZsA7DFIx77I/zjILolZCclpTmBBnIgvTDBYY8zmI6sh89HDmbI/R 3y+aE7JpZvnS0uoCA2L86jVlCMcVF9OHTF9rPpdn12a8TDuDEetM5poe7jlDmlompDkkmvs6Sh8ve eAZJVkYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6koX-00000008hKL-3KNN; Wed, 16 Sep 2026 08:16:21 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6koW-00000008hJU-23AV; Wed, 16 Sep 2026 08:16:20 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 918586053A; Wed, 16 Sep 2026 08:16:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F8951F00893; Wed, 16 Sep 2026 08:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789546579; bh=SjWIP8bNgzdC4buQnhVS9zvJ7ieVsM0oE8uqr/MRoYM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=JXwBUxpp6BrunGC9Exr6GM/vSGpDSwW0e19VQG/HebrdWDreqD+TRflwbah2sHQOp FpxMLshY1UEor/GvOfupqRFWD/7O/D2IT53Ts1TI0qFtHguYs/mwcF9Zi3Q3eq5daW zDrOlbTsyURpbnesjY/9q7QnelxvpU617ZiErDVoEip8cXsy+kXVqb4NL0quiCe+fz VUWYamsRGz77Z/6BQ1e99VwL01uV5WAnNUvkI2cMNjx/mSZFEeZRdfrPgO6QyFkNxL 4wb3ea39LRymM0UgOJlA2TIVhPRqcPmZq2u67H7j2RDNLc9dbn0+llVJHeqS7b4Itb l8KwbL9+yj3oA== Received: from johan by xi.lan with local (Exim 4.99.5) (envelope-from ) id 1x6koS-00000005wGU-1cEn; Wed, 16 Sep 2026 10:16:16 +0200 Date: Wed, 16 Sep 2026 10:16:16 +0200 From: Johan Hovold To: Joshua Crofts Cc: Peter Chen , Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , Mathias Nyman , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH 2/6] usb: xhci-mtk: add missing pm_runtime_dont_use_autosuspend() call Message-ID: References: <20260915090223.1346-1-joshua.crofts1@gmail.com> <20260915090223.1346-3-joshua.crofts1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260915090223.1346-3-joshua.crofts1@gmail.com> X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2026 at 09:02:19AM +0000, Joshua Crofts wrote: > The disable_pm label in xhci_mtk_probe() and xhci_mtk_remove() both call > pm_runtime_disable() on error or device teardown, but don't call > pm_runtime_dont_use_autosuspend(), causing resource leaks. No, there is no resource leak here either and this does not need to be backported. The autosuspend setting is not restored, but that would only possibly have an impact in the theoretical corner case that someone forcibly rebinds a different driver that does not enable it. > Add the missing pm_runtime_dont_use_autosuspend(). > > Found using Coccinelle. > > Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") > Fixes: 04284eb74e0c ("usb: xhci-mtk: add support runtime PM") > Cc: So, without having looked at the rest: none of these should be backported. Johan