From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 591D1C982EE for ; Mon, 21 Sep 2026 15:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C9OuFK8krYG5CFJQY5mJoDN0CmcjBiY8Df4psmo7f7k=; b=40CIrKXl2CysP3Mdc8jiLFtuJ0 pJRqsYKeTrMwaEJuL2hCgr/s9WenBlKmEX9F4JgshNbKCzpEvjpOGW2yWSzLXItpOOhzB3anDMSVc r40/RHIPiv6EnlPA0agi7trm5/MkFxnV9vTODBk7n/UV0IXzqkBsYhtd5QfAjwdJJL1SYyn+/d1wl o5ZUP21JNdInGcbQAMCO/F/r3V2kl8iQPBBxKrOO7NWPiZ2eo2ps1Fb817WI0pf19DYltfoc0NapC i9kHzSqxRbcR115tt4c72083e1dXa6wK7fjIyilYj9otuBBRj2YDiGVYxZ4JM+R2z4E2JUl5mLUyF BQxWX+Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8fgv-00000002ZJH-1ZBC; Mon, 21 Sep 2026 15:12:25 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8fgq-00000002ZHZ-39Hy; Mon, 21 Sep 2026 15:12:20 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1E23960142; Mon, 21 Sep 2026 15:12:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B7491F000FF; Mon, 21 Sep 2026 15:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790003538; bh=C9OuFK8krYG5CFJQY5mJoDN0CmcjBiY8Df4psmo7f7k=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ll1CjiAP/Ipjm1dHbz/UzwNVf9Su2P2qOIF1JmfRmgsGSU25vaCQ2xhjcQ1JLOaz4 EfWNN+ckuH8zevwEV0XQBK8ptDUjLCv1HjxSFkKj5eeUQmVDJlcrD8ayhqK3wOEBSK 3cVnaTQYVPioq0KH1+A2XfU2ddu58foJDAKEHR/9jP0tolYzATNsIURq3kcnkjU9cU lKJYn7IToJuUKRUUX8u/zhpe+XdEabg6RFg+Wmb7azT7uw0H0Rr0NxFzltQXI9wdhZ YAAp7ozwP56WEdbxFryz4ovhOso3trE8rzp93innvh+2VQaqdZodZbHALaKXJIHVaW /2nWX6PpbDydA== Date: Mon, 21 Sep 2026 17:12:15 +0200 From: krzk@kernel.org To: Guangshuo Li Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Min Guo , Matthias Brugger , Yonglong Wu , stable@vger.kernel.org, AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-mediatek@lists.infradead.org, Bin Liu Subject: Re: [PATCH] usb: musb: mediatek: fix child device leak Message-ID: References: <20260921085119.308981-1-lgs201920130244@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260921085119.308981-1-lgs201920130244@gmail.com> X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 21 Sep 2026 16:51:19 +0800, Guangshuo Li wrote: > mtk_musb_probe() populates child platform devices using > of_platform_populate(), but neither the probe error paths nor the > driver remove path depopulate them. > > If any initialization step after of_platform_populate() fails, the > probe returns without unregistering the populated child devices. > Likewise, the children remain registered when the driver is later > unbound. > > Use devm_of_platform_populate() so the populated child devices are > automatically depopulated when probe fails or the driver is unbound. > > The issue was identified by a static analysis tool I developed and > confirmed by manual review. > > Fixes: 0990366bab3c ("usb: musb: Add support for MediaTek musb controller") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- > drivers/usb/musb/mediatek.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > You sent multiple independent patches, to multiple independent subsystems. The amount of these patches clearly suggest this was AI generated and most likely not tested. More importantly, you sent all this work without properly organizing relevant patches into patchsets. This makes reviewing difficult and might cause multiple reviewers to address the same issue. Replying to the entire set is impossible and requires handling each patch independently, instead of applying or discarding the set. Maintainers also won't see the bigger picture of your work. Quite worrying. This is on the verge of hostile patch: bomb us with so many contributions, we won't be able to handle them in efficient manner, like responding ONCE to ask you to slow down. Considering all this is untested and LLM generated, I have even more doubts whether this should be considered for review. Please read kernel documentation BEFORE posting more work. It will explain you how to identify subsystems, how to organize your work per subsystem, how to document usage of LLM and how what you should not do if this was posted in a good faith. Best regards, Krzysztof