Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Erwin Springer <aot.lerwin@gmail.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	"André Almeida" <andrealmeid@igalia.com>,
	"Boris Brezillon" <bbrezillon@kernel.org>,
	"Christopher Snowhill" <chris@kode54.net>,
	"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
	"Dharma Balasubiramani" <dharma.b@microchip.com>,
	"Dmitry Baryshkov" <lumag@kernel.org>,
	freedreno@lists.freedesktop.org,
	"Gustavo Padovan" <gustavo.padovan@collabora.com>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"Icenowy Zheng" <zhengxingda@iscas.ac.cn>,
	"Jianmin Lv" <lvjianmin@loongson.cn>,
	linux-arm-msm@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Maíra Canal" <mcanal@igalia.com>,
	"Manikandan Muralidharan" <manikandan.m@microchip.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Mingcong Bai" <jeffbai@aosc.io>,
	nouveau@lists.freedesktop.org,
	"Qianhai Wu" <wuqianhai@loongson.cn>,
	"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
	"Simon Ser" <contact@emersion.fr>,
	wayland-devel@lists.freedesktop.org,
	"Xaver Hugl" <xaver.hugl@kde.org>,
	"Xi Ruoyao" <xry111@xry111.site>
Subject: Re: [PATCH 00/12] drm/atomic: Try to make atomic+async usable, and clear up the "async update" helper confusion
Date: Tue, 17 Nov 2026 16:42:23 +0200	[thread overview]
Message-ID: <avxnz4Nt1IufM6oM@intel.com> (raw)
In-Reply-To: <1b7a7d94-e349-4f3c-b973-c365041c15f2@gmail.com>

On Mon, Nov 16, 2026 at 06:29:38PM +0100, Erwin Springer wrote:
> 
> Am 16.11.2026 um 10:11 schrieb Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The weird uapi semantics of the atomic async flip support make it
> > really hard for drivers to implement. Try to fix that by filtering
> > out the no-op junk from the commit that userspace likes to put there.
> >
> > Also a lot of people are apparently confusing the
> > .atomic_async_{update,check}() hack with async flips. The two
> > are completely orthogonal, so try to clear up that mess by
> > renaming the hack to .atomic_bypass_{update,check}().
> >
> > TODO: atomic+async is in serious need to proper tests, somehow
> >        all that seems to have gotten skipped when the feature
> >        was added :(
> 
> thanks, this fixes the KWin case for me, so my patch is no longer
> needed..
> 
> tested on Raptor Lake-U (Iris Xe) with unmodified KWin 6.8.2 and a
> fullscreen client that requests tearing through wp_tearing_control_v1,
> without my patch. I applied the series to the CachyOS 7.3.4 kernel,
> the only conflicts were the renames in amdgpu and msm.
> 
> Before, none of about 350 frames per run was presented without vsync.
> With the series 3330 of 3336 frames tear over four runs (with and
> without CCS modifiers), and the "async flip not supported" message is
> gone. What is still rejected is the first flip after the modifier or
> format changed, once per run, as intended, and in three of the runs
> one commit that touches the cursor plane, which can't do async flips:
> 
>    [PLANE:146:cursor A] does not support async flips
> No warnings and no flip_done timeouts in the log.
> 
> If you think it fits, feel free to add:
> 
> Reported-by: Erwin Springer <aot.lerwin@gmail.com>
> Tested-by: Erwin Springer <aot.lerwin@gmail.com>

Thanks. There are quite a few unresolved issues left here
though, so we might want you patch as a short term fix.
I'll have to go read it with some actual thought...

-- 
Ville Syrjälä
Intel


      reply	other threads:[~2026-11-17 14:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  9:11 [PATCH 00/12] drm/atomic: Try to make atomic+async usable, and clear up the "async update" helper confusion Ville Syrjala
2026-11-16  9:11 ` [PATCH 01/12] drm/atomic: Remove tall tales about tearing vs. "async updates" Ville Syrjala
2026-11-16  9:11 ` [PATCH 02/12] drm/atomic: s/async/bypass/ Ville Syrjala
2026-11-16  9:11 ` [PATCH 03/12] drm/atomic: Add FIXMEs around the incorrect use of the .atomic_bypass_check() for async flips Ville Syrjala
2026-11-16  9:11 ` [PATCH 04/12] drm/atomic: Highlight that bypass commits need care Ville Syrjala
2026-11-16  9:11 ` [PATCH 05/12] drm/atomic/uapi: Eliminate the confusing drm_atomic_check_prop_changes() Ville Syrjala
2026-11-16  9:11 ` [PATCH 07/12] drm/atomic/uapi: Document the non-obvious fence/fb_id prop behaviour Ville Syrjala
2026-11-16  9:11 ` [PATCH 08/12] drm/atomic/uapi: Add a FIXME about colorop vs. async flips Ville Syrjala
2026-11-16  9:11 ` [PATCH 09/12] drm/atomic-helper: Mark drm_atomic_crtc_state_for_each_plane_state() unsafe Ville Syrjala
2026-11-16  9:11 ` [PATCH 10/12] drm/i915: Complete no-op "async flips" by hand Ville Syrjala
2026-11-16  9:11 ` [PATCH 11/12] drm/atomic/uapi: Make async flips a bit more palatable through atomic Ville Syrjala
2026-11-16  9:11 ` [PATCH 12/12] drm/atomic/uapi: Extract {connector,crtc,plane}_async_flip_check() Ville Syrjala
2026-11-16 17:29 ` [PATCH 00/12] drm/atomic: Try to make atomic+async usable, and clear up the "async update" helper confusion Erwin Springer
2026-11-17 14:42   ` Ville Syrjälä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avxnz4Nt1IufM6oM@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrealmeid@igalia.com \
    --cc=aot.lerwin@gmail.com \
    --cc=bbrezillon@kernel.org \
    --cc=chenhuacai@kernel.org \
    --cc=chris@kode54.net \
    --cc=contact@emersion.fr \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dharma.b@microchip.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jeffbai@aosc.io \
    --cc=kernel-list@raspberrypi.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lumag@kernel.org \
    --cc=lvjianmin@loongson.cn \
    --cc=manikandan.m@microchip.com \
    --cc=mcanal@igalia.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=wayland-devel@lists.freedesktop.org \
    --cc=wuqianhai@loongson.cn \
    --cc=xaver.hugl@kde.org \
    --cc=xry111@xry111.site \
    --cc=zhengxingda@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox