Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Moudy Ho (何宗原)" <Moudy.Ho@mediatek.com>
To: "AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"andersson@kernel.org" <andersson@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"TingHan Shen (沈廷翰)" <TingHan.Shen@mediatek.com>,
	"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"Nicolas Prado" <nfraprado@collabora.com>,
	"Olivia Wen (温倩苓)" <Olivia.Wen@mediatek.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"kernel@collabora.com" <kernel@collabora.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 2/4] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP
Date: Thu, 20 Mar 2025 01:28:17 +0000	[thread overview]
Message-ID: <b0872ee008c3c6a2731f949d8c2be77aa49341f7.camel@mediatek.com> (raw)
In-Reply-To: <70c10764-121b-43f5-931e-84ffd666c594@collabora.com>

On Wed, 2025-03-19 at 10:34 +0100, AngeloGioacchino Del Regno wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 18/03/25 23:22, Nícolas F. R. A. Prado ha scritto:
> > The SCP present on MT8188 does not have an L1TCM memory region, but
> > the
> > binding incorrectly requires one for the dual-core description of
> > the
> > MT8188 SCP. Remove that requirement. Also update the minimum number
> > of
> > reg and reg-names to 1, since as this is a multi-core SCP with no
> > L1TCM memory, only the CFG memory region is present in the parent
> > node.
> > 
> > Fixes: 91e0d560b9fd ("dt-bindings: remoteproc: mediatek: Support
> > MT8188 dual-core SCP")
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 
> As far as I know, the L1TCM is present on MT8188, and it's at
> 0x1070000 len 0x8000
> exactly like MT8195.
> 
> Moudy, are you able to please confirm or deny that?
> 
> Cheers,
> Angelo
> 
> 

Hi Angelo,

Unfortunately, during the transition from MT8195 to MT8188, the SCP
removed the L1TCM, retaining only the SRAM and config register.
For detailed hardware changes, you can refer to Tinghan's previous
description at the following link.

ref:
https://lore.kernel.org/all/20220715051821.30707-3-tinghan.shen@mediatek.com/

Sincerely,
Moudy Ho


  reply	other threads:[~2025-03-20  1:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18 22:22 [PATCH 0/4] Describe MT8188's SCP as dual-core Nícolas F. R. A. Prado
2025-03-18 22:22 ` [PATCH 1/4] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195 Nícolas F. R. A. Prado
2025-03-19  7:16   ` Krzysztof Kozlowski
2025-03-19 14:25     ` Nícolas F. R. A. Prado
2025-04-18  8:43       ` AngeloGioacchino Del Regno
2025-03-18 22:22 ` [PATCH 2/4] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP Nícolas F. R. A. Prado
2025-03-19  7:18   ` Krzysztof Kozlowski
2025-03-19  9:34   ` AngeloGioacchino Del Regno
2025-03-20  1:28     ` Moudy Ho (何宗原) [this message]
2025-03-20 10:33       ` AngeloGioacchino Del Regno
2025-03-18 22:22 ` [PATCH 3/4] arm64: dts: mediatek: mt8188: Describe SCP as a cluster with two cores Nícolas F. R. A. Prado
2025-03-18 22:22 ` [PATCH 4/4] arm64: dts: mediatek: mt8390-genio-common: Add firmware-name for scp0 Nícolas F. R. A. Prado
2025-03-19  9:34   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0872ee008c3c6a2731f949d8c2be77aa49341f7.camel@mediatek.com \
    --to=moudy.ho@mediatek.com \
    --cc=Olivia.Wen@mediatek.com \
    --cc=TingHan.Shen@mediatek.com \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox