From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E54ECD32D62 for ; Fri, 5 Dec 2025 14:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:In-Reply-To:From:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6gmqcOwSNc0+xhzL2UsZFCz72iWFcGpUCCkzE2dmMWA=; b=1QOGQ3GKcuHhPrgWitA2C0GegF im09S5LFZcHWGfhg8NxdfB+nwsX65N3wHZC0WKlpR7mbsQ8a5Ywsnf2hlvQmc6Dpzc7Z0/H+GNZjn k51V/rQpyi4aNIaczOsVc8K1W7RhrQhoHKrupg5RU24WzgotJz0430vgU32jOIr0vIc2Ewte/d6B/ 5MSogqttGbw2po79lcLdogXcFw6Ukxfmx6qibn8cyFnM0kXTAj1IWTGyl+uMik1EWjtga7o2yCl5c 0T83unOKGMA75NFtpBaBaeoq+bSR8WXFkRDaXKe9Xr829dK0LCGEhbf4s+kLQ/QAdYeA5MJUGN/Jt t4ameK0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vRWl4-00000009aOt-3UWt; Fri, 05 Dec 2025 14:26:06 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vRWkz-00000009aNs-23Xa for linux-mediatek@lists.infradead.org; Fri, 05 Dec 2025 14:26:05 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20251205142556euoutp018a4e2aefd8464068e993b1abb31932a6~_V_egg4Wt3000530005euoutp01O for ; Fri, 5 Dec 2025 14:25:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20251205142556euoutp018a4e2aefd8464068e993b1abb31932a6~_V_egg4Wt3000530005euoutp01O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1764944756; bh=6gmqcOwSNc0+xhzL2UsZFCz72iWFcGpUCCkzE2dmMWA=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=F4NoGPDcG2LPkzlCRHCJrQdt7ggfb1R20wG+ILP7OURnlGKEu5jogmZcG73MZwegx VhtNsYtFdcpzIf0fBX5yIQ30ttmmFtM4PuEBdFNe59bQ3qlKeiHuq00UxvE5r0eyRj Jc+4Yub/CsoXVnqZFJJ88gWVoQ0eOsVo8gCnWuZs= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20251205142555eucas1p2e96cf9def9641e26e060f05139d24941~_V_d9WlrN2971629716eucas1p2H; Fri, 5 Dec 2025 14:25:55 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20251205142553eusmtip11d66a1f54e847d5d4b609dd79aef82bb~_V_b7m79k0312503125eusmtip1E; Fri, 5 Dec 2025 14:25:53 +0000 (GMT) Message-ID: Date: Fri, 5 Dec 2025 15:25:52 +0100 MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH 0/4] drm: Revert and fix enable/disable sequence To: Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dmitry Baryshkov , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Jyri Sarha Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Louis-Alexis Eyraud , Aradhya Bhatia , Linus Walleij , Chaoyi Chen , Vicente Bergas , Marek Vasut , stable@vger.kernel.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideasonboard.com> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20251205142555eucas1p2e96cf9def9641e26e060f05139d24941 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20251205095238eucas1p1b7cf95d86a9aecf19877ac568148e265 X-EPHeader: CA X-CMS-RootMailID: 20251205095238eucas1p1b7cf95d86a9aecf19877ac568148e265 References: <20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251205_062601_801244_C00F68B9 X-CRM114-Status: GOOD ( 18.46 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 05.12.2025 10:51, Tomi Valkeinen wrote: > Changing the enable/disable sequence in commit c9b1150a68d9 > ("drm/atomic-helper: Re-order bridge chain pre-enable and post-disable") > has caused regressions on multiple platforms: R-Car, MCDE, Rockchip. > > This is an alternate series to Linus' series: > > https://lore.kernel.org/all/20251202-mcde-drm-regression-thirdfix-v6-0-f1bffd4ec0fa%40kernel.org/ > > This series first reverts the original commit and reverts a fix for > mediatek which is no longer needed. It then exposes helper functions > from DRM core, and finally implements the new sequence only in the tidss > driver. > > There is one more fix in upstream for the original commit, commit > 5d91394f2361 ("drm/exynos: fimd: Guard display clock control with > runtime PM calls"), but I have not reverted that one as it looks like a > valid patch in its own. Right, that patch is a fix on its own, the changes in the atomic sequence just revealed the issue. > I added Cc stable v6.17+ to all patches, but I didn't add Fixes tags, as > I wasn't sure what should they point to. But I could perhaps add Fixes: > to all of these. > > Signed-off-by: Tomi Valkeinen > --- > Linus Walleij (1): > drm/atomic-helper: Export and namespace some functions > > Tomi Valkeinen (3): > Revert "drm/atomic-helper: Re-order bridge chain pre-enable and post-disable" > Revert "drm/mediatek: dsi: Fix DSI host and panel bridge pre-enable order" > drm/tidss: Fix enable/disable order > > drivers/gpu/drm/drm_atomic_helper.c | 122 ++++++++++++++---- > drivers/gpu/drm/mediatek/mtk_dsi.c | 6 - > drivers/gpu/drm/tidss/tidss_kms.c | 30 ++++- > include/drm/drm_atomic_helper.h | 22 ++++ > include/drm/drm_bridge.h | 249 ++++++++++-------------------------- > 5 files changed, 214 insertions(+), 215 deletions(-) > --- > base-commit: 88e721ab978a86426aa08da520de77430fa7bb84 > change-id: 20251205-drm-seq-fix-b4ed1f56604b Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland