From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2795FC5ACB3 for ; Thu, 16 Nov 2023 14:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bm2RzTQJq4kxmpZeDLnmc54Iix97y+OC5pYL0ktassI=; b=jvr0r2yQoymhMKiqfJ+Ir5S+oV dxHJIylRzsG4ZZ8/jfYaMBrk0LMzuL5Em/scMqslFkYN6ESqGzFVypkSms8kxtTHJpizj9lmsptwl m67v3Tvo7D1lYSTICYNTxiBynpCXsh/olYh4Qp4u77RUBAJl4EagEbFk2jAvdSHpBpkj6T6mpRK0o dcq3bWP0b3i1r7lUep7omuKArrVlNJMgL3rNFofoynitY8yS2H+WxZf1hjvG6Xof1oqudwYjvkf8o tOVYdzNxAQy7XJIv6c7KKLBcL+3wNmhRkLxiD40TJNU3sOTLUEq+PB5uoCbLPX7N2y7uhFE+RImWX tEM666aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3dVy-003idu-02; Thu, 16 Nov 2023 14:38:42 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3dVu-003id3-2V for linux-mediatek@lists.infradead.org; Thu, 16 Nov 2023 14:38:40 +0000 Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-7781b176131so44397985a.1 for ; Thu, 16 Nov 2023 06:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700145516; x=1700750316; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bm2RzTQJq4kxmpZeDLnmc54Iix97y+OC5pYL0ktassI=; b=oNpFuGxBzv6e2WHDPuocq5Xd7Y/2RME1Nh+Cej6zAriDyrhNI9m+Ya8go59V9SsYx2 AL9Xl5toXzEBqqDac5jlBhMmgsdV5jHqBxbAUmRHcB3qodYw5wrqEtn1OfHEm+8oeNpS l8k8PgnpdgMsQ/Io148YGtWLFykU3g1n72IytLIjtfKQyIGV3GtjmZn8bEMlrAp1vuOK z8lk7iQSYgYiIVuWLLIww+vnci6yXau+GP1vSuV7KM/tfmpiuWnZDwkQL7rE596d+883 I7r4iFSSFeSddpIdnTRVRLDJU8C1UtdA3/emEQ8u/5xVqQccVWm/8fD8MjwCAqpNOchs eMfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700145516; x=1700750316; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bm2RzTQJq4kxmpZeDLnmc54Iix97y+OC5pYL0ktassI=; b=QfqEXwCLubOSRZkMVBNqppRMjrUrFGKFjKRUSGucxG9IeQ6KiW0in0oiW/jUACAXEr W5oo/x5zjmMSK2hJBsqflqxMnwjzdRLKv+7rmEDvCOI2eENPJsCLJleC3Ced5L43zyi3 8QfMimW5v6GnFq/TjEL6R/lNNlgWsSoymPv00llNl7xLEFo0P07AquSORIHB96MjsVsY thegvH/6SQIwhQoOyQQaaqFIF32OG61B009+rFsgCg/aljmlz4O+EP5rqJV7dq1Sd7AF 4qmQKc8GXKhEb4j6FwomJ78JS24kIkjMNoZFbtN59/dQVEzxuJXrI0zmRKwqMqiAW6WV PA7A== X-Gm-Message-State: AOJu0YzWvuNL8b7U8HIIDHMeNRcehwlK2FwuWmW+EfAiBr+tSOdvNfeV hKmEtmlKUb+Z4RW+XtcPRPi66w== X-Google-Smtp-Source: AGHT+IHkfG2EtNEBccfsPbZQdfjg2kps5NLHZmzHvHHDc5M3LjUWwk8uRM9kdxfTEIesGr2NPAVyCA== X-Received: by 2002:a05:620a:3721:b0:76f:17ad:3c83 with SMTP id de33-20020a05620a372100b0076f17ad3c83mr9663931qkb.47.1700145516633; Thu, 16 Nov 2023 06:38:36 -0800 (PST) Received: from [10.50.4.74] ([50.201.115.146]) by smtp.gmail.com with ESMTPSA id m11-20020a05620a290b00b007743382121esm4315994qkp.84.2023.11.16.06.38.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Nov 2023 06:38:36 -0800 (PST) Message-ID: Date: Thu, 16 Nov 2023 15:38:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: thermal: convert Mediatek Thermal to the json-schema Content-Language: en-US To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20231116120225.29999-1-zajec5@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231116120225.29999-1-zajec5@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231116_063838_823875_1B21C7A9 X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 16/11/2023 13:02, Rafał Miłecki wrote: > From: Rafał Miłecki > > This helps validating DTS files. > ... mal.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal.yaml > new file mode 100644 > index 000000000000..0e036b22b82b > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.yaml mediatek,thermal.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/mediatek-thermal.yaml# mediatek,thermal.yaml > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek Thermal SoC? PMIC? > + > +description: > Drop > > + This describes the device tree binding for the Mediatek thermal controller Drop redundant part. Describe hardware, not the binding. There is no point to say that a binding describes a binding. > + which measures the on-SoC temperatures. This device does not have its own ADC, > + instead it directly controls the AUXADC via AHB bus accesses. For this reason > + this device needs phandles to the AUXADC. Also it controls a mux in the > + apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS > + is also needed. > + > +allOf: ... > + mediatek,auxadc: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: A phandle to the AUXADC which the thermal controller uses > + > + mediatek,apmixedsys: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: A phandle to the APMIXEDSYS controller > + > + resets: Reference to the reset controller controlling the thermal controller. > + Not tested. You miss constraints. Drop totally redundant description. > + > +unevaluatedProperties: false > + > +required: > + - reg > + - interrupts > + - clocks > + - clock-names > + - mediatek,auxadc > + - mediatek,apmixedsys unevaluatedProperties go here. Best regards, Krzysztof