Re: [PATCH v3 1/3] dt-bindings: gpu: mali-bifrost: Add compatible for MT8370 SoC

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 07/02/25 16:18, Louis-Alexis Eyraud ha scritto:
> Add a compatible for the MediaTek MT8370 SoC, with an
> integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core).
> This new compatible is needed for this SoC support, as the other
> existing compatibles for the same GPU architecture (MT8188, MT8192) do
> not match the required power domain number.
> The other compatibles (especially MT8186) cannot be reused because of
> GPU architecture difference.
> 
> Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> index 735c7f06c24e632ab738d062f15378f754c8adaf..6f6211950bb495fa6bfcdfe8d1e27e5ce7aeeae0 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> @@ -37,6 +37,7 @@ properties:
>             - enum:
>                 - mediatek,mt8188-mali
>                 - mediatek,mt8192-mali
> +              - mediatek,mt8370-mali
>             - const: arm,mali-valhall-jm # Mali Valhall GPU model/revision is fully discoverable
>   
>     reg:
> @@ -217,7 +218,9 @@ allOf:
>         properties:
>           compatible:
>             contains:
> -            const: mediatek,mt8186-mali
> +            enum:
> +              - mediatek,mt8186-mali
> +              - mediatek,mt8370-mali
>       then:
>         properties:
>           power-domains:
>