From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2DEEC02198 for ; Mon, 10 Feb 2025 12:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=44y8j+AwXW+Xy0HJDEfrJNBigjIXgkSJ5/Vx3gjsh+s=; b=dVxbR1F0sI2IiLQ3iw20LTnHi9 w75WozXTdc8OgV0lLfoEWcBWSctg+aCCrIlj5go80Ed7lJV88LGu2ZC3fqkE5Fzc51roNS4Ap+roz Hegy1LmxaoSTqKeNOfb7jXdmItdbUVjKtF/TZcIxlErI6Y7XODlSKJCNbltTouKlRKTNZadBVpRnK jTWc1c46pEKsZklGp5ixVxRNGQWjmxvgqDjkARDJYnDzjRP0jIrydyJuleUIQddwlkKxoDzCfXe9q jQ9ReI4C18b5v3Xrrgx0iH+XYTQI4jXNKkBf+YuCGmQotGn7uj8kswydtqJtXtRSenVDpCt4a5YVR PpuCBW4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thSjG-0000000HMtm-2fps; Mon, 10 Feb 2025 12:17:34 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thSJQ-0000000HJD0-1QSR; Mon, 10 Feb 2025 11:50:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1739188250; bh=+WeROGh0IxRi9ENLiNY69RRv2egDN0g2bYDLctyHo44=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HEz9H+6QOsA296TDuoufEDidTU7hVQ6bZYMICdFoHQ/oorkC4Tv0eaj0Ukyn4tHVO 8vnoitsAR4mJmDb1TNiBo51HH8eevn+Jq5Rz6Vs5iXCKrC4j+jIhyrOjrbtVsfzEXw ZArZ/75YuNonfRn3AZyxa/pNCregDZHtgDI5UZ7Yaw37odh+wZbVEbS7VqEX0iOYeh fDkXjbc2lwrjBnM/ErdRjwcXF4u6OpNIl9EXqWaxrmSIyHtlWL3pTEEF4RT2nrY38W LbWutO0VmtLnvJfyqmCkNEYdhqg3Gm5JPQOAhbo5qt+dWt/LeMewFSGJYOqv0L9MOw WhBU6GAdaW0Lw== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 74CA117E0239; Mon, 10 Feb 2025 12:50:49 +0100 (CET) Message-ID: Date: Mon, 10 Feb 2025 12:50:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/34] drm/mediatek: mtk_hdmi_ddc: Switch to register as module_platform_driver To: =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "chunkuang.hu@kernel.org" Cc: "robh@kernel.org" , "jie.qiu@mediatek.com" , "tzimmermann@suse.de" , "simona@ffwll.ch" , "mripard@kernel.org" , =?UTF-8?B?Sml0YW8gU2hpICjnn7PorrDmtpsp?= , "linux-mediatek@lists.infradead.org" , "dri-devel@lists.freedesktop.org" , "maarten.lankhorst@linux.intel.com" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "kernel@collabora.com" , "dmitry.baryshkov@linaro.org" , "krzk+dt@kernel.org" , =?UTF-8?B?TGV3aXMgTGlhbyAo5buW5p+P6YieKQ==?= , "p.zabel@pengutronix.de" , "conor+dt@kernel.org" , =?UTF-8?B?VG9tbXlZTCBDaGVuICjpmbPlvaXoia8p?= , =?UTF-8?B?SXZlcyBDaGVuamggKOmZs+S/iuW8mCk=?= , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "junzhi.zhao@mediatek.com" References: <20250113145232.227674-1-angelogioacchino.delregno@collabora.com> <20250113145232.227674-11-angelogioacchino.delregno@collabora.com> <424656ad6c9fbd1c32a62d7ed7b35eb322e94720.camel@mediatek.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <424656ad6c9fbd1c32a62d7ed7b35eb322e94720.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_035052_537464_CED05AC6 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 10/02/25 08:01, CK Hu (胡俊光) ha scritto: > On Mon, 2025-01-13 at 15:52 +0100, AngeloGioacchino Del Regno wrote: >> External email : Please do not click links or open attachments until you have verified the sender or the content. >> >> >> In preparation for splitting out the common bits from the HDMI >> driver, change the mtk_cec driver from being registered from the >> HDMI driver itself to be a module_platform_driver of its own. > > "change the mtk_hdmi_ddc driver" > > I think ddc is not the common part, so the reason is not splitting out the common bits. > Thanks, I didn't notice this typo! Regards, Angelo >> >> With this change, there are no more users of the mtk_hdmi.h header >> so, while at it, also remove it. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> drivers/gpu/drm/mediatek/Makefile | 6 ++---- >> drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 -- >> drivers/gpu/drm/mediatek/mtk_hdmi.h | 13 ------------- >> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 2 +- >> 4 files changed, 3 insertions(+), 20 deletions(-) >> delete mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi.h >> >> diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile >> index bdd3a062f797..43afd0a26d14 100644 >> --- a/drivers/gpu/drm/mediatek/Makefile >> +++ b/drivers/gpu/drm/mediatek/Makefile >> @@ -21,10 +21,8 @@ mediatek-drm-y := mtk_crtc.o \ >> >> obj-$(CONFIG_DRM_MEDIATEK) += mediatek-drm.o >> >> -mediatek-drm-hdmi-objs := mtk_hdmi.o \ >> - mtk_hdmi_ddc.o >> - >> obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mtk_cec.o >> -obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o >> +obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mtk_hdmi.o >> +obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mtk_hdmi_ddc.o > > It's not necessary to separate ddc to an independent module. > > Regards, > CK > >> >> obj-$(CONFIG_DRM_MEDIATEK_DP) += mtk_dp.o >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> index da725182f0db..e648fb5714e7 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> @@ -31,7 +31,6 @@ >> #include >> >> #include "mtk_cec.h" >> -#include "mtk_hdmi.h" >> #include "mtk_hdmi_regs.h" >> >> #define NCTS_BYTES 7 >> @@ -1804,7 +1803,6 @@ static struct platform_driver mtk_hdmi_driver = { >> }; >> >> static struct platform_driver * const mtk_hdmi_drivers[] = { >> - &mtk_hdmi_ddc_driver, >> &mtk_hdmi_driver, >> }; >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.h b/drivers/gpu/drm/mediatek/mtk_hdmi.h >> deleted file mode 100644 >> index e40bc4651995..000000000000 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.h >> +++ /dev/null >> @@ -1,13 +0,0 @@ >> -/* SPDX-License-Identifier: GPL-2.0-only */ >> -/* >> - * Copyright (c) 2014 MediaTek Inc. >> - * Author: Jie Qiu >> - */ >> -#ifndef _MTK_HDMI_CTRL_H >> -#define _MTK_HDMI_CTRL_H >> - >> -struct platform_driver; >> - >> -extern struct platform_driver mtk_hdmi_ddc_driver; >> - >> -#endif /* _MTK_HDMI_CTRL_H */ >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c >> index 07db68067844..6358e1af69b4 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c >> @@ -20,7 +20,6 @@ >> #include >> >> #include "mtk_drm_drv.h" >> -#include "mtk_hdmi.h" >> >> #define SIF1_CLOK (288) >> #define DDC_DDCMCTL0 (0x0) >> @@ -337,6 +336,7 @@ struct platform_driver mtk_hdmi_ddc_driver = { >> .of_match_table = mtk_hdmi_ddc_match, >> }, >> }; >> +module_platform_driver(mtk_hdmi_ddc_driver); >> >> MODULE_AUTHOR("Jie Qiu "); >> MODULE_DESCRIPTION("MediaTek HDMI DDC Driver"); >> -- >> 2.47.0 >> >