From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3842CC433EF for ; Mon, 28 Mar 2022 05:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vb98dXkNER77PJ3Kwt+rECrBM9VYQ+2nYT8HVHnflTc=; b=SHH87JuN1oeWpK PB7Ruckm0q0tFybUgj285hbMDZ108RksopZZHNkg4n5VwTfi1Mr7urneoVlAXxmOPLqOD8qY35ka9 /rWyL+idqTtAz5lhjM+AcgVleiyDwnfYnfTgoRcnRwn4wIBHOa28WRYiRcm6ns0LN2TSR7BbmX9Pg gPhA+4b7jKqpFbshypybZNA4HEZWR0zSwOPuUrFwC/S///mIVhO0a9OXy2LAXQOaB5yYj9c+fVCdm Df/H/a7VMUUvWsGJ5lap+e0X9W0HGthF0RhHYDEZAAcpuLcHkhfdZgt6FiHlfRlqFNCQ6ivvrT1Vn xWaVfzAgzDYl5RQeEn4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYi8Q-007LvK-8j; Mon, 28 Mar 2022 05:41:46 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYi8O-007Lus-CZ; Mon, 28 Mar 2022 05:41:45 +0000 X-UUID: 511cea21cf9046ddb37be490a243af1d-20220327 X-UUID: 511cea21cf9046ddb37be490a243af1d-20220327 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1255063751; Sun, 27 Mar 2022 22:39:59 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 27 Mar 2022 22:39:58 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Mar 2022 13:39:55 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 28 Mar 2022 13:39:55 +0800 Message-ID: Subject: Re: [PATCH v16 4/8] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 From: CK Hu To: Jason-JH Lin , Rob Herring , Matthias Brugger , "Chun-Kuang Hu" , Philipp Zabel , AngeloGioacchino Del Regno Date: Mon, 28 Mar 2022 13:39:55 +0800 In-Reply-To: References: <20220307032859.3275-1-jason-jh.lin@mediatek.com> <20220307032859.3275-5-jason-jh.lin@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220327_224144_442237_0015AA89 X-CRM114-Status: GOOD ( 25.18 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Maxime Coquelin , David Airlie , linux-kernel@vger.kernel.org, singo.chang@mediatek.com, Alexandre Torgue , roy-cw.yeh@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com, Fabien Parent , moudy.ho@mediatek.com, linux-mediatek@lists.infradead.org, Daniel Vetter , hsinyi@chromium.org, Enric Balletbo i Serra , nancy.lin@mediatek.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Jason: On Mon, 2022-03-28 at 13:03 +0800, Jason-JH Lin wrote: > Hi CK, > > Thanks for the reviews. > > On Mon, 2022-03-07 at 11:28 +0800, jason-jh.lin wrote: > > Add mt8195 vdosys0 clock driver name and routing table to > > the driver data of mtk-mmsys. > > > > Signed-off-by: jason-jh.lin > > Acked-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > Impelmentation patch of vdosys1 can be refered to [1] > > > > [1] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1 > > --- > > drivers/soc/mediatek/mt8195-mmsys.h | 130 > > +++++++++++++++++++++++++ > > drivers/soc/mediatek/mtk-mmsys.c | 11 +++ > > include/linux/soc/mediatek/mtk-mmsys.h | 9 ++ > > 3 files changed, 150 insertions(+) > > create mode 100644 drivers/soc/mediatek/mt8195-mmsys.h > > > > diff --git a/drivers/soc/mediatek/mt8195-mmsys.h > > b/drivers/soc/mediatek/mt8195-mmsys.h > > new file mode 100644 > > index 000000000000..24a3afe23bc8 > > --- /dev/null > > +++ b/drivers/soc/mediatek/mt8195-mmsys.h > > @@ -0,0 +1,130 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > + > > +#ifndef __SOC_MEDIATEK_MT8195_MMSYS_H > > +#define __SOC_MEDIATEK_MT8195_MMSYS_H > > + > > +#define MT8195_VDO0_OVL_MOUT_EN > > 0xf14 > > +#define MT8195_MOUT_DISP_OVL0_TO_DISP_RDMA0 > > BIT(0) > > +#define MT8195_MOUT_DISP_OVL0_TO_DISP_WDMA0 > > BIT(1) > > > > Useless, so remove. > > > > +#define MT8195_MOUT_DISP_OVL0_TO_DISP_OVL1 BIT(2) > > Ditto.Useless, so remove. > > Regards, > > CK > > Although these definitions are not used, they represent the > functionality provided by this register. > > I think we can show that we have these capabilities by defining them. > > Can we keep these definitions? It's better that we know how to use it. Even though the symbol name show some information, but I would like to add it to mmsys_mt8195_routing_table[]. Regards, CK > > Regards, > Jason-JH.Lin > > > +#define MT8195_MOUT_DISP_OVL1_TO_DISP_RDMA1 > > BIT(4) > > +#define MT8195_MOUT_DISP_OVL1_TO_DISP_WDMA1 > > BIT(5) > > +#define MT8195_MOUT_DISP_OVL1_TO_DISP_OVL0 BIT(6) > > > [snip] > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek