From: Alexandre Mergnat <amergnat@baylibre.com>
To: krzysztof.kozlowski@linaro.org
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
amergnat@baylibre.com, angelogioacchino.delregno@collabora.com,
broonie@kernel.org, chen.zhong@mediatek.com,
devicetree@vger.kernel.org, dmitry.torokhov@gmail.com,
fabien.parent@linaro.org, fparent@baylibre.com,
krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-rtc@vger.kernel.org, matthias.bgg@gmail.com,
mkorpershoek@baylibre.com, pavel@ucw.cz, robh@kernel.org,
sean.wang@mediatek.com
Subject: Re: [PATCH v4 2/9] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation
Date: Tue, 15 Nov 2022 11:34:41 +0100 [thread overview]
Message-ID: <ba0901a0-56c5-4e60-49b3-356899921934@baylibre.com> (raw)
In-Reply-To: <09495553-e563-e12b-056e-bed95531ab6b@linaro.org>
Hi, thanks for your help
>>>> I checked and it doesn't support it but this needs to be fixed. >>>> >>>>> What about rest of rtc.yaml schema? >>>>> >>>> >>>>
wakeup-source would make sense but the driver doesn't support it yet.
>>> >>> The question is about hardware - does hardware support waking
up the >>> system via interrupt? This is usually a domain of PMICs which
still are >>> powered on when system sleeps. >>> >> >> I'd say that it
is possible that a PMIC is able to wake up the system >> with or without
having an interrupt wired to the SoC so wakeup-source >> makes sense. We
don't need it if it is interrupt only. >
>Then I propose to reference the rtc.yaml.
I think I understand my error.
Actually, the RTC (HW) support the "start-year" feature, then I suggest
to fix the binding like that:
allOf:
- $ref: "rtc.yaml#"
properties:
compatible:
enum:
- mediatek,mt6323-rtc
- mediatek,mt6357-rtc
- mediatek,mt6358-rtc
- mediatek,mt6366-rtc
- mediatek,mt6397-rtc
start-year: true
additionalProperties: false
required:
- compatible
examples:
- |
pmic {
rtc {
compatible = "mediatek,mt6397-rtc";
};
};
next prev parent reply other threads:[~2022-11-15 10:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 18:43 [PATCH v4 0/9] Add MediaTek MT6357 PMIC support Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 1/9] dt-bindings: input: mtk-pmic-keys: add binding for MT6357 PMIC Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 2/9] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation Alexandre Mergnat
2022-11-08 22:30 ` Rob Herring
2022-11-09 9:40 ` AngeloGioacchino Del Regno
2022-11-09 17:49 ` Alexandre Belloni
2022-11-09 22:29 ` Rob Herring
2022-11-09 22:57 ` Alexandre Belloni
2022-11-10 14:14 ` Krzysztof Kozlowski
2022-11-14 22:57 ` Alexandre Belloni
2022-11-15 7:56 ` Krzysztof Kozlowski
2022-11-15 8:05 ` Alexandre Belloni
2022-11-15 8:17 ` Krzysztof Kozlowski
2022-11-15 10:34 ` Alexandre Mergnat [this message]
2022-11-15 13:49 ` Krzysztof Kozlowski
2022-11-08 18:43 ` [PATCH v4 3/9] dt-bindings: regulator: Add binding schema for mt6357 regulators Alexandre Mergnat
2022-11-11 14:45 ` Krzysztof Kozlowski
2022-11-08 18:43 ` [PATCH v4 4/9] dt-bindings: mfd: mediatek: Add bindings for MT6357 PMIC Alexandre Mergnat
2022-11-08 22:30 ` Rob Herring
2022-11-11 14:51 ` Krzysztof Kozlowski
2022-11-08 18:43 ` [PATCH v4 5/9] dt-bindings: soc: mediatek: convert pwrap documentation Alexandre Mergnat
2022-11-09 9:55 ` AngeloGioacchino Del Regno
2022-11-15 13:54 ` Alexandre Mergnat
2022-11-15 14:18 ` Krzysztof Kozlowski
2022-11-15 15:54 ` Alexandre Mergnat
2022-11-11 14:55 ` Krzysztof Kozlowski
2022-11-08 18:43 ` [PATCH v4 6/9] arm64: dts: mt6358: change node names Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 7/9] arm64: dts: mt8173: change node name Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 8/9] regulator: add mt6357 regulator Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 9/9] Input: mtk-pmic-keys: add MT6357 support Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba0901a0-56c5-4e60-49b3-356899921934@baylibre.com \
--to=amergnat@baylibre.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fabien.parent@linaro.org \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox