From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21BBBC25B79 for ; Thu, 23 May 2024 05:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uTyeLMDb4lNaxhZJTQsoV5C1v2Ta4iSW4vHweH8NajA=; b=R1ERVcmKH1xrmgoN7tiHXH+qFD Q9/1BRcMcjESESzFnywGG6p+88gDIMRF6NyPaudosc2oixlNT748CI/lkQjupNmPKV2BtCkRX585y L3Vy2vOOGKFoLa3yc6iIMRkM8JlzALX2ggJ4AnTYKn+U9rs4dC7/NPWOsdWp/zDwGSzxKVyyWTnZ7 rseNF6Zr+WBKOj26uOfkeh5mdxBvQUYB0FfAfA5yTkoNsf9wiwP1alHurJqQKxz7m8Me2GfIo1cuD ATopFE4A/XO48O4HVGqUvSAGEI1gLKrYso3FynE4iG0fjC8mluoR+WAxfnl3nGIgyQrCicwUqtF+e n+5ArB3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sA1H2-0000000587y-47k6; Thu, 23 May 2024 05:45:56 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sA1Gz-00000005874-00ed; Thu, 23 May 2024 05:45:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1716443149; bh=ixt8OajYR20IPA+H5M4ytRrCuvQEPCIDj6wZr5U9vZU=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=V6XZISe2rHRPDxCU3RcaRltfEjMsf3Um1F7s2Knx3jBoPnoWXYLTzBB1x2GEXFNlA zCUCvq/awcplJhGU9EHEmA06ZVtHfJe0QRL0SxHOCBDpNUeLpks5b6o7YrYR8Z+0JD jJVHUHbOum7lO29ITpT33LzBWBmhEmtjVsm1AeUnTM81zmzbDR00y3AVw7dE0/xQ7q wgIzSxGobBDfFQRLyrrVAK78jMvSAybnilANfAm2CwRhrPydRXI5h2h1YYYNI9aIDM pVoGtRcF0sS4YgQRyYQUvx/UVf6KA9mvN2TP05pxOmAzrMSCZx594KP6GwZlPhptpQ PQxZ6jnI5aOrg== Received: from [100.66.96.193] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: vignesh) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 8AA8637820E5; Thu, 23 May 2024 05:45:45 +0000 (UTC) Message-ID: Date: Thu, 23 May 2024 11:15:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] drm/ci: build virtual GPU driver as module From: Vignesh Raman To: Dmitry Baryshkov Cc: dri-devel@lists.freedesktop.org, daniels@collabora.com, helen.koike@collabora.com, airlied@gmail.com, daniel@ffwll.ch, robdclark@gmail.com, david.heidelberg@collabora.com, guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com, mcanal@igalia.com, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, amd-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20240517092502.647420-1-vignesh.raman@collabora.com> <20240517092502.647420-4-vignesh.raman@collabora.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240522_224553_361740_41B74EE7 X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Dmitry, On 21/05/24 12:39, Vignesh Raman wrote: > Hi Dmitry, > > On 20/05/24 16:32, Dmitry Baryshkov wrote: >> On Fri, May 17, 2024 at 02:54:59PM +0530, Vignesh Raman wrote: >>> With latest IGT, the tests tries to load the module and it >>> fails. So build the virtual GPU driver for virtio as module. >> >> Why? If the test fails on module loading (if the driver is built-in) >> then it's the test that needs to be fixed, not the kerenel config. >> >> It's fine as a temporal workaround, but please include a link to the >> patch posted to fix the issue. > > I will recheck this issue and post a link to the fix. This was the issue seen with IGT commit https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/7d1841317c13c19c26b6352f923b205d43742c55 [ 4.450571] [drm:virtio_gpu_init] *ERROR* failed to find virt queues [ 4.450962] virtio_gpu virtio0: probe with driver virtio_gpu failed with error -2 [ 5.471417] [drm:virtio_gpu_init] *ERROR* failed to find virt queues [ 5.471916] virtio_gpu virtio0: probe with driver virtio_gpu failed with error -2 https://gitlab.freedesktop.org/vigneshraman/linux/-/jobs/59037122 With the recent uprev of IGT to https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/0df7b9b97f9da0e364f5ee30fe331004b8c86b56, this issue is not seen. So will drop this commit. Regards, Vignesh > > Regards, > Vignesh > >> >>> >>> Signed-off-by: Vignesh Raman >>> --- >>> >>> v2: >>>    - No changes. >>> >>> --- >>>   drivers/gpu/drm/ci/build.sh       | 1 - >>>   drivers/gpu/drm/ci/igt_runner.sh  | 6 +++--- >>>   drivers/gpu/drm/ci/image-tags.yml | 4 ++-- >>>   drivers/gpu/drm/ci/test.yml       | 1 + >>>   drivers/gpu/drm/ci/x86_64.config  | 2 +- >>>   5 files changed, 7 insertions(+), 7 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/ci/build.sh b/drivers/gpu/drm/ci/build.sh >>> index a67871fdcd3f..e938074ac8e7 100644 >>> --- a/drivers/gpu/drm/ci/build.sh >>> +++ b/drivers/gpu/drm/ci/build.sh >>> @@ -157,7 +157,6 @@ fi >>>   mkdir -p artifacts/install/lib >>>   mv install/* artifacts/install/. >>> -rm -rf artifacts/install/modules >>>   ln -s common artifacts/install/ci-common >>>   cp .config artifacts/${CI_JOB_NAME}_config >>> diff --git a/drivers/gpu/drm/ci/igt_runner.sh >>> b/drivers/gpu/drm/ci/igt_runner.sh >>> index 20026612a9bd..55532f79fbdc 100755 >>> --- a/drivers/gpu/drm/ci/igt_runner.sh >>> +++ b/drivers/gpu/drm/ci/igt_runner.sh >>> @@ -30,10 +30,10 @@ case "$DRIVER_NAME" in >>>               export IGT_FORCE_DRIVER="panfrost" >>>           fi >>>           ;; >>> -    amdgpu) >>> +    amdgpu|virtio_gpu) >>>           # Cannot use HWCI_KERNEL_MODULES as at that point we don't >>> have the module in /lib >>> -        mv /install/modules/lib/modules/* /lib/modules/. >>> -        modprobe amdgpu >>> +        mv /install/modules/lib/modules/* /lib/modules/. || true >>> +        modprobe --first-time $DRIVER_NAME >>>           ;; >>>   esac >>> diff --git a/drivers/gpu/drm/ci/image-tags.yml >>> b/drivers/gpu/drm/ci/image-tags.yml >>> index 60323ebc7304..328f5c560742 100644 >>> --- a/drivers/gpu/drm/ci/image-tags.yml >>> +++ b/drivers/gpu/drm/ci/image-tags.yml >>> @@ -4,9 +4,9 @@ variables: >>>      DEBIAN_BASE_TAG: "${CONTAINER_TAG}" >>>      DEBIAN_X86_64_BUILD_IMAGE_PATH: "debian/x86_64_build" >>> -   DEBIAN_BUILD_TAG: "2023-10-08-config" >>> +   DEBIAN_BUILD_TAG: "2024-05-09-virtio" >>> -   KERNEL_ROOTFS_TAG: "2023-10-06-amd" >>> +   KERNEL_ROOTFS_TAG: "2024-05-09-virtio" >>>      DEBIAN_X86_64_TEST_BASE_IMAGE: "debian/x86_64_test-base" >>>      DEBIAN_X86_64_TEST_IMAGE_GL_PATH: "debian/x86_64_test-gl" >>> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml >>> index 612c9ede3507..864ac3809d84 100644 >>> --- a/drivers/gpu/drm/ci/test.yml >>> +++ b/drivers/gpu/drm/ci/test.yml >>> @@ -350,6 +350,7 @@ virtio_gpu:none: >>>     script: >>>       - ln -sf $CI_PROJECT_DIR/install /install >>>       - mv install/bzImage /lava-files/bzImage >>> +    - mkdir -p /lib/modules >> >> Is it necessary to create it manually here? >> >>>       - mkdir -p $CI_PROJECT_DIR/results >>>       - ln -sf $CI_PROJECT_DIR/results /results >>>       - install/crosvm-runner.sh install/igt_runner.sh >>> diff --git a/drivers/gpu/drm/ci/x86_64.config >>> b/drivers/gpu/drm/ci/x86_64.config >>> index 1cbd49a5b23a..78479f063e8e 100644 >>> --- a/drivers/gpu/drm/ci/x86_64.config >>> +++ b/drivers/gpu/drm/ci/x86_64.config >>> @@ -91,7 +91,7 @@ CONFIG_KVM=y >>>   CONFIG_KVM_GUEST=y >>>   CONFIG_VIRT_DRIVERS=y >>>   CONFIG_VIRTIO_FS=y >>> -CONFIG_DRM_VIRTIO_GPU=y >>> +CONFIG_DRM_VIRTIO_GPU=m >>>   CONFIG_SERIAL_8250_CONSOLE=y >>>   CONFIG_VIRTIO_NET=y >>>   CONFIG_VIRTIO_CONSOLE=y >>> -- >>> 2.40.1 >>> >>