From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABE4FC48BEB for ; Wed, 14 Feb 2024 09:24:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=autbkFLkjIeFP2IoTWAP7V+DqrVLjHlcVKE9Dqcp+7Q=; b=Ib3ICGSiWukUvsZN2Xq3Y/RMWi ea2n7zOMb47Rqzblg/xZE3uWGaBjnHppYFFmRvQmKkzZNIqsmHHHL6uibd4c8SYdwDGXmdrMdZAMo c2UyGHkZtI0I45moGpkhQH9Y2vbXk/gv7qTNJQvqBRACuTRLQEwhnbmFH7ClVMhJwip2+qR3jYGRu uP37eaoi2NWo3yWMMb28nkdWW9IsiTie4FK4//2KHh6FhK9quTVuB9qokyfTNigf7aG6LPCC9qH3H 0cDuOTxQHA42jr6OTt1RQbq77Fkd2ve/6hKzcod+6ioKEY5gnrFoEzMgOxk+Knm7CqUTEMG1uIMXP YtLhs8SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raBVQ-0000000CHEG-0p2J; Wed, 14 Feb 2024 09:24:40 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raBVM-0000000CHDW-36oq; Wed, 14 Feb 2024 09:24:37 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a3d52d40569so34349566b.0; Wed, 14 Feb 2024 01:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707902675; x=1708507475; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=autbkFLkjIeFP2IoTWAP7V+DqrVLjHlcVKE9Dqcp+7Q=; b=DTyvZGmXZeGOQTnVzY0vSFyS1IAeBt2d4ovm+SEyb9/9Rx+PJyPCozKNrCxfwcPJ7O R5kU4O4mcQkdHveAmKr+HGrihmXTw2t46GFPcCQEC08oUoY6sU33jgNzTNCQ1HfPP14Y 6eI4QiL5HDbJb7+T8Ffl9N3SHHIHyqA0WRxxfM3dBFbz91AsUtZTDxK+PmeisO9nG6P4 2R/KIJAkOx0xuypFaedgfasaBdLkkdW37uSzD12Ev0ExGJvLsuZ3/9krpIxkZr6rImSC u3Xtmz3nzUF5nzL4sWvdQX3JPFcdaIGZa7LcAUr8uZe/AQ/tlkpZs7e9nYZFcjvmV58g nNOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707902675; x=1708507475; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=autbkFLkjIeFP2IoTWAP7V+DqrVLjHlcVKE9Dqcp+7Q=; b=u7YR+2iv2qpj2mwIb4RFCh2DHXEzcvLN2Sm9BDliwiyCH0pubj+QQLGg8wJ3grO78a GjKukATQDZJ9EW48kgJrEyFOU0ohIoVB7+q+3esl07DXH6AUsFNdd+SBIns7xokVOm6p z46xaIaGWcHLNIPB6sWD17XTJoW3HHuOCrpxiYexw7pPU+j/HvFWKaVO+JHRhA69g7W3 7II4K++wNH6KTLyaef+5iionm6+GWrBEI+fJEHIgifndRAj2XttEMZ9MP8QztZhQeEqT KjsMSFhbk/olClZ+3moKXXw4KxUpmUlLD1C4XIxBy6Arrwm0bL7lGqF04WorLu6vt33I RIFw== X-Forwarded-Encrypted: i=1; AJvYcCWplARFJNUe+in2zccIn9wATNaUANXujPOuIa0eE5ZYVx6nt0cq5tXmc/qnGe6/4a5jAX4c0aDSB7AjABH+JJExQXZAyvd/guOjMhperScUBuC49O+k0xt7c6gzOk9eFRcD55xdXPMfqVShM/DHCD5nZO8Yh2nZf/0= X-Gm-Message-State: AOJu0YxbFwC1Rc76ML3qdq1PkRqwbqvcR6wW1g9wq2m8ifA4+g3daFdN 2zQ4i+UAA+WhGMkl8jGnE/c4JoKW9eYP/eV9ZEI5XV/LLBwvWAwI X-Google-Smtp-Source: AGHT+IEIRK0LiG32CesRopAhB5xn0V0/7DWQoZ3+1hg39jN/1KBKrKr4SXdEpoYMVIpPCy2AIxG62A== X-Received: by 2002:a17:906:4158:b0:a3d:26b2:94f4 with SMTP id l24-20020a170906415800b00a3d26b294f4mr1389226ejk.73.1707902674566; Wed, 14 Feb 2024 01:24:34 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX3CDe8Xc/tATxS7T7yF2GAH4vsL09Wkp69VRwWz7CXelPz+Y3qX6mCVXQoiLVeDQjXN4B2M7OS6GeN2B2a7Crtgov9zLzWIvOlMdSYOjmaTQ1kSeeN9nW1WHcvwX9Jbaokv+jiZs+Yw5lWz7mZ/Y4enHVIoJhrLyjFcwY/vlzeIsQSgTht3lgfkPHwfBjRDdxOI4OSCHDKvPQJIbbVsmJIL/0/UhLWKCv3cVdsb6rwaD+6Cmxy/MiLputfczmnLOTqgffmeaJpCdcTOM5PjBQ87lSHA2nqCQjIwWiGT01w/uU9lPIEcuZxccYhMM6FybU5VvmIf05oXjULJGxcwcN6X66B4rmc/i3NZV5EaiMwsMlqIw1fEUOCQFBSc+y0Y95HOg44oORhyU9fiL0ZF1c+kiJTifxJdOHvGoihDF2Ir7aXXpb8s83kRYLquvlyfVMpoVqfRA+G1UiogrTcCRUO Received: from [192.168.26.149] (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.googlemail.com with ESMTPSA id vo2-20020a170907a80200b00a3cf66ec008sm1636224ejc.166.2024.02.14.01.24.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Feb 2024 01:24:34 -0800 (PST) Message-ID: Date: Wed, 14 Feb 2024 10:24:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt7988: add PWM controller To: AngeloGioacchino Del Regno , Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: John Crispin , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20240213164633.25447-1-zajec5@gmail.com> <20240213164633.25447-2-zajec5@gmail.com> <36baacb4-4aa9-421f-bde0-c4be7d7f4aa1@collabora.com> Content-Language: en-US From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: <36baacb4-4aa9-421f-bde0-c4be7d7f4aa1@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_012436_802567_E40DC56E X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 14.02.2024 10:09, AngeloGioacchino Del Regno wrote: > Il 13/02/24 17:46, Rafał Miłecki ha scritto: >> From: Rafał Miłecki >> >> Add binding for on-SoC controller that can control up to 8 PWMs. >> >> Signed-off-by: Rafał Miłecki >> --- >>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 21 ++++++++++++++++++++- >>   1 file changed, 20 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >> index bba97de4fb44..67007626b5cd 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >> @@ -1,5 +1,6 @@ >>   // SPDX-License-Identifier: GPL-2.0-only OR MIT >> +#include >>   #include >>   / { >> @@ -78,7 +79,7 @@ gic: interrupt-controller@c000000 { >>               #interrupt-cells = <3>; >>           }; >> -        clock-controller@10001000 { >> +        infracfg: clock-controller@10001000 { >>               compatible = "mediatek,mt7988-infracfg", "syscon"; >>               reg = <0 0x10001000 0 0x1000>; >>               #clock-cells = <1>; >> @@ -103,6 +104,24 @@ clock-controller@1001e000 { >>               #clock-cells = <1>; >>           }; >> +        pwm@10048000 { >> +            compatible = "mediatek,mt7988-pwm"; > > I can't take this unless there's a driver that supports your device. I'd argue you should rather look for a documented binding rather than a (Linux?) driver. Otherwise you would refuse changes that are not strictly Linux related. DTS files are meant to describe hardware in a generic way and not be driven by Linux drivers / design. Example: We have bindings for "brcm,bcm6345-timer" and "bcm63138-timer" (see commit e112f2de151b) and DTS files with those bindings. There is no Linux driver for that hardware block as there is no need for it. In this context I'm explaining binding thing with Conor in discussion on PATCH 1/1. So stay tuned :)