From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 009D4C43458 for ; Mon, 6 Jul 2026 08:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XAhBIVcIgoBMwzdmQI01e6U2QYtMrrtbbOHKP8KiZ8E=; b=bHHM5vOAmh4eycqJsChNgfdNwe 46EAKh+dKFSBzOy/5xofJ8jD+m3QEIvBFkG/NpoxhTh9fhndNa6N7W/bC55ZGEy0L2Dp6Jcx1+4T5 rfDlNWiv4n+MfgTTxOMjYM5WOJTv9x12QCwXXkUZPGFtQTA5rFYpnQfTmTv6jmaVeHYEpumRGEjS8 qpkzhlZ1wFrjD2ibek2EH9R2T472/D9iq7+Tjoel5C7HIGXOnkUdPj/LMPnK2ePCLDgDIbIR6lesC gT/OWPlVxVC1Yb+n4m3TsjMOit6JA1faERTs4RQW3VMqNpBXpLrtf/M13t5+BS3DCztcF7NypyHeL 0WYgBWbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgegm-0000000BpMc-3E4n; Mon, 06 Jul 2026 08:28:28 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgegi-0000000BpJ4-0Pym for linux-mediatek@lists.infradead.org; Mon, 06 Jul 2026 08:28:27 +0000 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66642DGO3618367 for ; Mon, 6 Jul 2026 08:28:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XAhBIVcIgoBMwzdmQI01e6U2QYtMrrtbbOHKP8KiZ8E=; b=jm0Kg9lSibJvV8Yi 8hdJzAn4zgpP2byZ5O4vxPHA667bXVLXHofUt568kB49iHxnfwvFhctaInLtCjCZ sjNHRodxgeyEI+K4Sh5SeEFuH+eYubHtMfiWH/bAUEFyu7LxqpBoChobn1qyHVpZ 1rLLI4FJJqj/Yk953HEONXVBT+N6ylBmW+SjTQeQEVhfTmxCK8O9BG8vaRt3Exir JXmS8JQhSMmJuTk8SMinF8d+mY+jVTVBRkY8NqkZa2/Ot0bSxasJBedLFZ9P4/jy oIqrv4PZJHfl9zhVgr7IHFht7qp40w3MPq61gyA4heu2IH0hVtB6bY7pBm7HdH1D jKj/ig== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6s64nd3p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 08:28:22 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e66f9e2baso261214085a.0 for ; Mon, 06 Jul 2026 01:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783326502; x=1783931302; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XAhBIVcIgoBMwzdmQI01e6U2QYtMrrtbbOHKP8KiZ8E=; b=JQE4jGfFa+DmqViVvBr+82Q3iuwwCzULVNE9StgVbYu2SX9jGFUU0zSxJJzj3AJkDB rr/A0PFusvtfs7s3yPdBvOORckuB6dXpVP62b3hdXv2vQvlFyhfGio+u/UMb8nLdG6jP Imokp53s5cMH7Ujx3TSSKzyq8Y4An7XYgEAv0L9jgsZePjHS8EoPZ9oqRyio9Xbzp8EJ OEnRw90Tuejp11sGKJ99KjmLOx0xeZ9eX5nODNRaTrb73ne9YbtBnCI0X4B2Cpu21hI4 zNl3cMxTYJMVUMEYqJ0x22JT/DTPskAXr+Lebsg0uqeoKiggDjTphWeQArzgZt+ecBEc pl5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783326502; x=1783931302; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XAhBIVcIgoBMwzdmQI01e6U2QYtMrrtbbOHKP8KiZ8E=; b=NUTsBjV9xQTyhR/4+VJB0DRl3o51NKazwcK1uDJ6D2RABLlD+q4AKL6HXdCGkzEEg+ WkQ+iXSQYb8enqXaLf1kCvIxcjR5PSyZ4FE0gkE8WwwZAKYG7G3Xfel64XDlNTyRFCUc DnA/f1siRPe2H5zM7rEFyOx9m2F3N0PoKTg6Tn1asmF9favC0l08qWsRWpDradZn7yyr NP29Qj8D3Xof4Pc7xcqDFuNCCoQ7qp07vGgvN9E6t3rB8d5js5qkUltBMw4va2X3X6wH Vy0swGJtU9DDr55YsR1p4ouKfgSRQv+aAKkK1MvphcEls+60wQ2DVsE/hdoPcZMxcF59 dz2g== X-Forwarded-Encrypted: i=1; AHgh+RpHiXn9MUj802EGEf38C3tILfty6+qFuTiUhvWRIRgITSJ6ggE80EPPdsytzTkNzlSfEgQ9dI418JUKKIFzxg==@lists.infradead.org X-Gm-Message-State: AOJu0Yw4O9sLI0xrUFo0fZW0qAu3Ahtnm4K059yWGEUWjZuGAZkeq7Mb adeas/WtWrFvc/HGVI53F7kJf7+HQ+Xjey1bdkwgGKtKCxW9uFtuzS5KEmfHbWb1pIreA2ipXgH TVLkIo9pQuGmAP8ikkJ6l/unTZF5oK04U+n0k8vQmA59SHEjAfZFThTlq+HdVZroTtuArxDhPq2 w= X-Gm-Gg: AfdE7cnclV9gL+BfjWuriLHn4fV0/0EHM9UIZFNx3nYDLKPx4thCozf6mIRPqSSensL z1r8jzB/DmOKyhAzFnGEmxh8PHyI8IqCl6CbmcxBtwEn+fgvDfNxDRC5v9dcjVPtbkUbGAEo5Tz Bx3BQw4lMx+g03K6hE2mUAdEeHQxi+Eu+unJHwUS9664cRN1yNqoGzWpIGg3pf6v/kZ6LtZz5l0 C2Q65C9AY9DlOrH0JAsw1uIWG8maDKp681245JY3aEfjPioAH0CuAAsfHRfMdyDZiBYVzA8TQ8L a9iUaeiLnNb2IKK+49CiFoiRCiVuz/aKn9cvyIUYGA1RtaptEqwbYhJg3sg+fKcObhkXyIweKmB PfQefekLyuPpvFouCeNuDpLzwajU6Jdn4F5VuLzBpKaE388prmlb+2e9m8IhyGw== X-Received: by 2002:a05:620a:2b84:b0:92e:47d4:b485 with SMTP id af79cd13be357-92e9a4ed0e1mr1294194685a.62.1783326501627; Mon, 06 Jul 2026 01:28:21 -0700 (PDT) X-Received: by 2002:a05:620a:2b84:b0:92e:47d4:b485 with SMTP id af79cd13be357-92e9a4ed0e1mr1294189385a.62.1783326501174; Mon, 06 Jul 2026 01:28:21 -0700 (PDT) Received: from [192.168.69.219] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b62907absm677939066b.33.2026.07.06.01.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 01:28:20 -0700 (PDT) Message-ID: Date: Mon, 6 Jul 2026 10:28:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Chen Wang Cc: linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDA4MyBTYWx0ZWRfXx/OhzxioiOdI QLGqNsu3NP6M7ZAiucvKDyMF2IH0jDxYpBnOQ8DGwbe1fBlqkbv4/TyPCJR9nh7Z4MDrHCepV5u RMhzC4TaMTlkZILYvS3ZAPdvR8A+HtkaYX51VP+Y36x5hSROY9cwaGO7F6elIFahMjHOsAcRjEx AXo8x6scZAsPSQV1JuTcjQHPNhKa3gjkJeBh6ClRrXzj+iSaryyecof1ZId+AuoZH1Kj2k/hM8/ ouwOOQWEccXtW2ZGYOTBrKEtVUWaGOCL1/2n+lsgCFuEVRggXrTCL80EIsm3KmH6lPKTNX3dZQX ZUjKBx8ZC2+KI4iKsYebK9UP6qGEJudVm8ok+r5des+JDmvgigeL9OksQzsT89Eo/qmwJ2UdiL1 J30oyogqIPydKW2hAsuYwwiOVsXl29JaRTWlJrZNxIa5q5/xhfjE3A5932EKxWggs/Ss0JWhAzp GT4ttSu7A3K+0+ajp7w== X-Authority-Analysis: v=2.4 cv=VvITxe2n c=1 sm=1 tr=0 ts=6a4b6726 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=8pif782wAAAA:8 a=IpJZQVW2AAAA:8 a=TiEZW8bMWLlPbLH3YMsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-ORIG-GUID: RbI72ImV-j08-3eU4OfJ1trEXf9vjfjw X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDA4MyBTYWx0ZWRfX91+/u5ATYYTm fjEjHUAMdA68wS75IvXfYmqfUNAWEis3JVWShFieg60TBj/umOipfcWYtVkNns+glrb2HvSd87+ WVFqaLSt97mIp0DbBCS1cJgSYtX3MkU= X-Proofpoint-GUID: RbI72ImV-j08-3eU4OfJ1trEXf9vjfjw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 clxscore=1011 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060083 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_012824_304714_F2255BE5 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Uwe, On 6/7/26 09:19, Uwe Kleine-König (The Capable Hub) wrote: > Hello Chen, > > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: >> On 7/5/2026 11:14 PM, Uwe Kleine-König (The Capable Hub) wrote: >>> - Use a single space in a of_device_id array terminator; A single space >>> after the opening { and before the closing } in non-empty >>> initializers; >>> - No comma after an array terminator; >>> - Also no trailing comma after a named initializer iff the >> iff -> if > > This is actually intended. iff = "if and only if", see e.g. > https://en.wikipedia.org/wiki/If_and_only_if . I agree this scientific idiomatic expression is not well known by non-native English speakers, and using the expanded form is just simpler to review (thinking at non-native English speaker reading your commit in the future). > >>> closing } is on the same line; >>> >>> Signed-off-by: Uwe Kleine-König (The Capable Hub) >> >> [......]