From: Bart Van Assche <bvanassche@acm.org>
To: Stanley Chu <stanley.chu@mediatek.com>,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, alim.akhtar@samsung.com,
pedrom.sousa@synopsys.com, sthumma@codeaurora.org,
jejb@linux.ibm.com
Cc: marc.w.gonzalez@free.fr, andy.teng@mediatek.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
evgreen@chromium.org, subhashj@codeaurora.org,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
vivek.gautam@codeaurora.org, matthias.bgg@gmail.com,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
beanhuo@micron.com
Subject: Re: [PATCH v3 1/3] scsi: core: allow auto suspend override by low-level driver
Date: Mon, 16 Sep 2019 08:16:16 -0700 [thread overview]
Message-ID: <bebea62f-8ab0-528f-5634-9b3c06f47ef7@acm.org> (raw)
In-Reply-To: <1568616437-16271-2-git-send-email-stanley.chu@mediatek.com>
On 9/15/19 11:47 PM, Stanley Chu wrote:
> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
> index 202f4d6a4342..495e30adb53f 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -199,7 +199,7 @@ struct scsi_device {
> unsigned broken_fua:1; /* Don't set FUA bit */
> unsigned lun_in_cdb:1; /* Store LUN bits in CDB[1] */
> unsigned unmap_limit_for_ws:1; /* Use the UNMAP limit for WRITE SAME */
> -
> + unsigned rpm_autosuspend_on:1; /* Runtime autosuspend */
> atomic_t disk_events_disable_depth; /* disable depth for disk events */
The "_on" part in the variable name "rpm_autosuspend_on" is probably
redundant and the comment could have been more elaborate. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2019-09-16 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 6:47 [PATCH v3 0/3] scsi: core: allow auto suspend override by low-level driver Stanley Chu
2019-09-16 6:47 ` [PATCH v3 1/3] " Stanley Chu
2019-09-16 15:16 ` Bart Van Assche [this message]
2019-09-16 15:55 ` Stanley Chu
2019-09-16 6:47 ` [PATCH v3 2/3] scsi: ufs: override auto suspend tunables for ufs Stanley Chu
2019-09-16 12:33 ` [EXT] " Bean Huo (beanhuo)
2019-09-16 6:47 ` [PATCH v3 3/3] scsi: ufs-mediatek: enable auto suspend capability Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bebea62f-8ab0-528f-5634-9b3c06f47ef7@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=chun-hung.wu@mediatek.com \
--cc=evgreen@chromium.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=pedrom.sousa@synopsys.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=sthumma@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox