Re: [PATCH v2 1/3] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU

[Chengci.Xu <chengci.xu@mediatek.com>]

On Thu, 2022-09-08 at 12:49 +0200, Krzysztof Kozlowski wrote:

Thanks for your review.

> On 31/08/2022 14:55, Chengci.Xu wrote:
> > This patch adds descriptions for mt8188 IOMMU which also use ARM
> > Short-Descriptor translation table format.
> 
> Do not use "This commit/patch".
> 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst*L95__;Iw!!CTRNKA9wMg0ARbw!0FyEQYk5UrJwuW-kVc1X-l58KMwnooLeErNkSwisiEzNf88AvYvMrzE6iYFH0KFOdag$
>  

Thank you for sharing this, I will drop this words.

> 
> >  
> >      then:
> >        required:
> > diff --git a/include/dt-bindings/memory/mediatek,mt8188-memory-
> > port.h b/include/dt-bindings/memory/mediatek,mt8188-memory-port.h
> > new file mode 100644
> > index 000000000000..9363e132c43a
> > --- /dev/null
> > +++ b/include/dt-bindings/memory/mediatek,mt8188-memory-port.h
> > @@ -0,0 +1,482 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
> 
> Why do you license it under BSD-3 clause?
> 

A mediatek internal wiki suggest me use "BSD-3-Clause" without detial
reason. May be it is not suitable for this file.

If you don't approve of this, I can change this license to "GPL-2.0-
only OR BSD-2-Clause", which is perferred by DT bindings file according
to "submitting-patches.rst". 

Do you think "BSD-2-Clause" is OK? Or could you kindly share me another
proper license?


Best regards,
Chengci Xu

> Best regards,
> Krzysztof