From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39CA8C433F5 for ; Tue, 29 Mar 2022 10:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wMR2xKH0ra0BAfS0KxJYY8WZ0Yl3jpXXIKGEfeisneE=; b=r7BgY/W0dq0Zi0 u99Ar4E1huR5cu3Bw98ucX12SM9SM5wlxaYMBwh32aJxsAL/lWYz6giUNEvHqeZnbGerHWMTN2NP+ WFOn+r5injerKB2H/LObXCjYDc2YiO0exuQ4v677Ff7Y4+eU+BzOPLMZ0oyFGaa5LdR7sjr+LWgsA riiNncaiqSiWFFA+Ek+WdgdAoLEoXbnUHLqy1z+gT5AD5szvVrc5c3RsxJhmnWvp7ZvV3MUbM9WNd cshY4TqtrQ+TCs5y+2kUgiv2gtXDUUywGwJ950VoJg3GH1hI3LCAEABvJpnGf76mRJIHVZGTY9vw0 GhriVsDuhQhUfwPKDpIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ8fI-00BkXf-Q5; Tue, 29 Mar 2022 10:01:28 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ8f5-00BkUQ-EL; Tue, 29 Mar 2022 10:01:16 +0000 Received: by mail-wr1-x434.google.com with SMTP id w21so19440333wra.2; Tue, 29 Mar 2022 03:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=m4FFYC8lGa0e93GEJjlQ3+QnjPXNWGNWcnEAZzCv3sM=; b=jzmwQJqPkQjtYfqpaahPYRUlFjFgaqh7YzFgssx0NHXJTapk2V8SYRsKVYC9G/h49H HfULIJdloYL6DUiwFsRGc8Uy57P61i0CsSGjglbAYxfutxhv1rUxpZQ4GlCah/F89GUO fHMLYxAAlLEE8wwPybLM4RluCyfcfdW6y5V3xkifbbeFP0ZZiT3GkHHmDkdaYTVwys/+ Bk4yFgvnIVTsQL+9XEAMwotecAivJ4JcyyhbYajW9Q6u2wSeRQKvVR9evne+8eHx4Mzf 7RhAcdfqACvmIiVDyT6Eg013w+YGid733dW8LFdAFP1cP6JfHS9cjwOOGw1eSqgLu1iG U9rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=m4FFYC8lGa0e93GEJjlQ3+QnjPXNWGNWcnEAZzCv3sM=; b=4uYfWPBJYkZsXbD96iRdr5PqD6r1WhcqsEysKGWRceX+a0rjcOjm8NemB/G6C4G2z1 fQtDxXswl3VIZlEkvsbFRfKtvXerzA0q3eWT/2KF9XJljDjPXgcZIs3w3kNDqHV6v1Di FLGkd+8sOGZdy1zSEeQp09IUp1L3LRu7XJy0HOnRynyZ9yC72K/ZkZzZsx8IJ0+r8LdE T80qTqNW5xwtkIrs9/wvqCdRnPm8isGMlllcRF/TBdNGVpeU7GZ79W0tmGrhEPoEbH7d sb5fRqCQ+WKT60LrJK9eXA0WQbVTtXKdl36SJ/n09iJRLWwjlFF8f7cElKvUY8y3O9Yv /i2g== X-Gm-Message-State: AOAM533r0uCtduCaAbBx/kTI/SJrc9w3bUofoQChWtCSe+t1ju01djhw EThyB40LNWNw0PKGEhbKmKI= X-Google-Smtp-Source: ABdhPJzC16Ey35nHO2vMO312+0ONaIEcW00CaKl7lSRzySNcL2ia+eHDyeaf5+/WYV/KFiwFKrKiWA== X-Received: by 2002:adf:efd2:0:b0:203:db42:c56c with SMTP id i18-20020adfefd2000000b00203db42c56cmr29329158wrp.698.1648548073504; Tue, 29 Mar 2022 03:01:13 -0700 (PDT) Received: from [192.168.1.145] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id v1-20020adf9e41000000b00205c3d212easm4214242wre.51.2022.03.29.03.01.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Mar 2022 03:01:12 -0700 (PDT) Message-ID: Date: Tue, 29 Mar 2022 12:01:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 17/22] arm64: dts: mt8192: Add dpi node Content-Language: en-US To: "allen-kh.cheng" , Rob Herring , Krzysztof Kozlowski Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai , Ryder Lee , Hui Liu References: <20220318144534.17996-1-allen-kh.cheng@mediatek.com> <20220318144534.17996-18-allen-kh.cheng@mediatek.com> <019b1a59-7531-75cf-3b86-d2798ca9823a@gmail.com> From: Matthias Brugger In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220329_030115_525946_8FC337DD X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 29/03/2022 09:45, allen-kh.cheng wrote: > Hi Matthias, > > On Fri, 2022-03-25 at 16:24 +0100, Matthias Brugger wrote: >> >> On 18/03/2022 15:45, Allen-KH Cheng wrote: >>> Add dpi node for mt8192 SoC. >>> >>> Signed-off-by: Allen-KH Cheng >>> --- >>> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 11 +++++++++++ >>> 1 file changed, 11 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi >>> b/arch/arm64/boot/dts/mediatek/mt8192.dtsi >>> index 71ad3adeed51..a77d405dd508 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi >>> @@ -1236,6 +1236,17 @@ >>> power-domains = <&spm >>> MT8192_POWER_DOMAIN_DISP>; >>> }; >>> >>> + dpi0: dpi@14016000 { >>> + compatible = "mediatek,mt8192-dpi"; >>> + reg = <0 0x14016000 0 0x1000>; >>> + interrupts = >> 0>; >>> + clocks = <&mmsys CLK_MM_DPI_DPI0>, >>> + <&mmsys CLK_MM_DISP_DPI0>, >>> + <&apmixedsys CLK_APMIXED_TVDPLL>; >>> + clock-names = "pixel", "engine", "pll"; >>> + status = "disabled"; >> >> We are missing the output port node here. >> >> Regards, >> Matthias >> > > We will add output port in mt8192-asurada.dtsi (inlude mt8192.dtsi) for > board level. > Got it, patch now applied. > Do we need to add any futher information in binding? > Hm, probably we should mark the output port as optional? Can you check how other bindings manage that? Thanks, Matthias > Thanks, > Allen > >>> + }; >>> + >>> iommu0: m4u@1401d000 { >>> compatible = "mediatek,mt8192-m4u"; >>> reg = <0 0x1401d000 0 0x1000>; > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek