Re: [PATCH v4 18/22] arm64: dts: mt8192: Add display nodes

Nícolas F. R. A. Prado
2022-03-22T14:19:58Z

On Tue, Mar 22, 2022 at 02:15:28PM +0800, allen-kh.cheng wrote:
> On Mon, 2022-03-21 at 19:26 -0400, Nícolas F. R. A. Prado wrote:
> > On Fri, Mar 18, 2022 at 10:45:30PM +0800, Allen-KH Cheng wrote:
> > > + aal0: aal@1400b000 {
> > > + compatible = "mediatek,mt8192-disp-aal",
> > > + "mediatek,mt8193-disp-aal";
> >
> > Typo: "mediatek,mt8193-disp-aal" should be "mediatek,mt8173-disp-
> > aal", otherwise
> > the drm driver doesn't even probe. Typos happen, just please make
> > sure you're
> > testing before sending to the list so these kind of issues can be
> > caught
> > earlier.
> >
> > Thanks,
> > Nícolas
> >
> Hi Nícolas,
>
> Thanks for your kindly reminder.
>
> There are two compatibles in drivers/gpu/drm/mediatek/mtk_disp_aal.c
> (mediatek,mt8173-disp-aal adn mediatek,mt8183-disp-aal)
>
> In 8192, We should use mediatek,mt8183-disp-aal because of design.

If that's the case, then the mediatek,aal.yaml binding should be fixed. As it
currently is, the mt8173 compatible is expected as a fallback for mt8192. [1]

>
> Do I need to add some information for this in mediatek,disp.txt?

Note that the mediatek,disp.txt binding was split into several yaml bindings.
The binding for this node is now mediatek,aal.yaml and can be seen in Chun-Kuang
Hu's tree [1].

Thanks,
Nícolas

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/tree/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml?h=mediatek-drm-next