From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96B35C02187 for ; Sun, 19 Jan 2025 17:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zcyrOMr6zvuz/PUU6lJSLE9ffbpG6Aa6FrDGrG0kTrg=; b=S/5PwP1fvgV6lkbApUITtYgbwz M/qPMP/+ws5iI72R6wh2d2oKm++1+bpzTlOuBAchMWmx9WWFLn4hmLiQ4+BfiRLu7yl2iLSW0F4DQ xBAv1ZZKx6TTPPDarRl8a3bDqYJkncWahWvaZ0p4qhB4aYTDCy4AHivk0xb0EpXVJeuFMF57uEDQi LfmrbGs/rLT/pBfn8Q73Yv7tnUAeev2YQr4qSOTxNn39eoDhtMEZ7r/b7A4YFClqbFTQE8mmedTuI N/9O8xT8EnoTiNqJLIdL2G+Ti3T1nU1O55EyT+gFb3JqrRgeTaivTTKL/hI2UsmB2z7qIpOblmFVf ysMDfpcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tZZER-00000004CPE-2ePE; Sun, 19 Jan 2025 17:37:07 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tZZDA-00000004CIr-0EHE; Sun, 19 Jan 2025 17:35:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=zcyrOMr6zvuz/PUU6lJSLE9ffbpG6Aa6FrDGrG0kTrg=; b=c36Dp0WN/a+gMwnf0aWi3xcE4w ic4ZR8EMddMMANdQv7A4gbrEyTpzfF/m2MC6Jv2B4H4b45iIzIUhHPnqx5EzgtVlwLgxsUF64FE0h +zLyznJUiM5fP72AXql0RVleiDIRZq512/CF/hMUeoqkhVxWwwEBD82nTTPAXpFm7xqE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1tZZCw-0066wg-T0; Sun, 19 Jan 2025 18:35:34 +0100 Date: Sun, 19 Jan 2025 18:35:34 +0100 From: Andrew Lunn To: Daniel Golle Cc: Sky Huang , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Qingfang Deng , Matthias Brugger , AngeloGioacchino Del Regno , Simon Horman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Steven Liu Subject: Re: [PATCH net-next 3/3] net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988 Message-ID: References: <20250116012159.3816135-1-SkyLake.Huang@mediatek.com> <20250116012159.3816135-4-SkyLake.Huang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250119_093548_113959_3BBAA53B X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org > Imho it's fine to add the driver without support for the LEDs for now > and add LED support later on. But in that case you also shouldn't call > mtk_phy_leds_state_init(). It is also O.K. to hard code the default LED meanings, different to the reset defaults. But you need to think ahead to when you do add full LED support, you want the defaults to be something which the LED subsystem can represent and take over when it controls the LEDs. Andrew