From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH v1 4/4] thermal: mediatek: minor mtk_thermal.c cleanups Date: Thu, 27 Jul 2017 17:49:33 +0200 Message-ID: References: <1501134417-3505-1-git-send-email-louis.yu@mediatek.com> <1501134417-3505-5-git-send-email-louis.yu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1501134417-3505-5-git-send-email-louis.yu@mediatek.com> Content-Language: en-US Sender: linux-pm-owner@vger.kernel.org To: louis.yu@mediatek.com, Zhang Rui , Eduardo Valentin Cc: Rob Herring , Mark Rutland , dawei.chien@mediatek.com, fan.chen@mediatek.com, eddie.huang@mediatek.com, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com List-Id: linux-mediatek@lists.infradead.org On 07/27/2017 07:46 AM, louis.yu@mediatek.com wrote: > From: Louis Yu > > Move thermal module reset in the beginning and revise clock error > handle flow to pair the clock control. > > Signed-off-by: Louis Yu > --- > drivers/thermal/mtk_thermal.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index f2a7155..5dffdb4 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -712,20 +712,20 @@ static int mtk_thermal_probe(struct platform_device *pdev) > return -EINVAL; > } > > + ret = device_reset(&pdev->dev); > + if (ret) > + return ret; > + > ret = clk_prepare_enable(mt->clk_auxadc); > if (ret) { > dev_err(&pdev->dev, "Can't enable auxadc clk: %d\n", ret); > - return ret; > - } > - > - ret = device_reset(&pdev->dev); > - if (ret) > goto err_disable_clk_auxadc; > + } > > ret = clk_prepare_enable(mt->clk_peri_therm); > if (ret) { > dev_err(&pdev->dev, "Can't enable peri clk: %d\n", ret); > - goto err_disable_clk_auxadc; > + goto err_disable_clk_peri_therm; If you can't enable the clock, there is no use in disable it in the error path. Regards, Matthias > } > > for (i = 0; i < mt->conf->num_banks; i++) >