From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E65DC2BA83 for ; Mon, 10 Feb 2020 02:01:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E33620658 for ; Mon, 10 Feb 2020 02:01:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UZzYFfRx"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="qXpPbmf/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E33620658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uNFbfaMFZiQd4NXXmoux/YEn+R8+nbXaD5d4HTmCx4I=; b=UZzYFfRxmYxTPvm1sPaftevfg IbLLZaydZqlrrfPbNDa1zuNhddGNBZlPoXYzskqKanw+ukDq7IZ9NS+S7H4UcNt0xV7V4cVkg0V6C AkiO7X2jzA5roo1QQzL8KmfMhppZ1qoTXtSsjFPoA+Y0nXhqP/y2hls1jI44lcblm/QL+btQG9KTH CWShfqUz6ecJBlIIi1rTP5nkarY5TatOEGTxfW2dyaeAkU9AE3UXgm8GKEoUFurSt0VsyhDoLlLkB +yE9lVXstQvorHrvNVH7aMuYxLnbJb8wak6vbTXs6jUIGOajS7Ex/Kq20ADrQ92/JzAwYwNjljLyL rvrx3ZzIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j0yNZ-0007Hl-3m; Mon, 10 Feb 2020 02:00:53 +0000 Received: from mail25.static.mailgun.info ([104.130.122.25]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j0yNS-0005dh-1R for linux-mediatek@lists.infradead.org; Mon, 10 Feb 2020 02:00:48 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581300046; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=kn1eCoX1vGFsUPSDIWx1LkICtUFdlC5DFGOw/o4zcls=; b=qXpPbmf/ROfS9ztv9xfqoNjt2pme1kd/fc0RtbaJWAxJkBkecFm+S+/gXj+UzR7APmkj1oTx RHJ5QSxi45iz4isV6VMD7+cvaHF2e/jkC7bJ/BY+dEcAPwcQaaRnLOoIyLTmfliUVHoeqvkC 4MYMx0DmSUObmFxQx7sGyPwfvYk= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI0ZDIyMyIsICJsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e40b949.7f39204587d8-smtp-out-n02; Mon, 10 Feb 2020 02:00:41 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BC86AC4479C; Mon, 10 Feb 2020 02:00:41 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id BDCF7C43383; Mon, 10 Feb 2020 02:00:40 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 10 Feb 2020 10:00:40 +0800 From: Can Guo To: Avri Altman Subject: Re: [PATCH 5/7] scsi: ufs: Fix ufshcd_hold() caused scheduling while atomic In-Reply-To: References: <1581123030-12023-1-git-send-email-cang@codeaurora.org> <1581123030-12023-6-git-send-email-cang@codeaurora.org> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200209_180046_944541_DAD78B56 X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:ARM/Mediatek SoC support" , Stanley Chu , rnayak@codeaurora.org, saravanak@google.com, linux-scsi@vger.kernel.org, Venkat Gopalakrishnan , "James E.J. Bottomley" , nguyenb@codeaurora.org, open list , "moderated list:ARM/Mediatek SoC support" , salyzyn@google.com, Alim Akhtar , "Martin K. Petersen" , Matthias Brugger , Tomas Winkler , Bean Huo , kernel-team@android.com, Bart Van Assche , hongwus@codeaurora.org, asutoshd@codeaurora.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 2020-02-09 15:48, Avri Altman wrote: > You didn't address any of my comments to this patch. > > Thanks, > Avri Replied in that thread. Thanks, Can Guo. >> >> The async version of ufshcd_hold(async == true), which is only called >> in queuecommand path as for now, is expected to work in atomic >> context, >> thus it should not sleep or schedule out. When it runs into the >> condition >> that clocks are ON but link is still in hibern8 state, it should bail >> out >> without flushing the clock ungate work. >> >> Signed-off-by: Can Guo >> Reviewed-by: Hongwu Su >> Reviewed-by: Asutosh Das >> Reviewed-by: Bean Huo >> Reviewed-by: Stanley Chu >> >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index bbc2607..e8f7f9d 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi/ufs/ufshcd.c >> @@ -1518,6 +1518,11 @@ int ufshcd_hold(struct ufs_hba *hba, bool >> async) >> */ >> if (ufshcd_can_hibern8_during_gating(hba) && >> ufshcd_is_link_hibern8(hba)) { >> + if (async) { >> + rc = -EAGAIN; >> + hba->clk_gating.active_reqs--; >> + break; >> + } >> spin_unlock_irqrestore(hba->host->host_lock, >> flags); >> flush_work(&hba->clk_gating.ungate_work); >> spin_lock_irqsave(hba->host->host_lock, >> flags); >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek