public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: peter.wang@mediatek.com, linux-scsi@vger.kernel.org,
	martin.petersen@oracle.com, avri.altman@wdc.com,
	alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
	chun-hung.wu@mediatek.com, alice.chao@mediatek.com,
	cc.chou@mediatek.com, chaotian.jing@mediatek.com,
	jiajie.hao@mediatek.com, yi-fan.peng@mediatek.com,
	qilin.tan@mediatek.com, lin.gui@mediatek.com,
	tun-yu.yu@mediatek.com, eddie.huang@mediatek.com,
	naomi.chu@mediatek.com, ed.tsai@mediatek.com
Subject: Re: [PATCH v1] ufs: core: Change MCQ interrupt enable flow
Date: Tue, 23 Sep 2025 08:54:28 -0700	[thread overview]
Message-ID: <c9f1ce41-b81d-490e-b919-a6105ed34ff0@acm.org> (raw)
In-Reply-To: <20250923090855.2522149-1-peter.wang@mediatek.com>

On 9/23/25 2:08 AM, peter.wang@mediatek.com wrote:
> -static void ufshcd_enable_intr(struct ufs_hba *hba, u32 intrs)
> +void ufshcd_enable_intr(struct ufs_hba *hba, u32 intrs)
>   {
>   	u32 old_val = ufshcd_readl(hba, REG_INTERRUPT_ENABLE);
>   	u32 new_val = old_val | intrs;
> @@ -377,6 +372,7 @@ static void ufshcd_enable_intr(struct ufs_hba *hba, u32 intrs)
>   	if (new_val != old_val)
>   		ufshcd_writel(hba, new_val, REG_INTERRUPT_ENABLE);
>   }
> +EXPORT_SYMBOL_GPL(ufshcd_enable_intr);

Please do not export ufshcd_enable_intr() - this function should not be
called from outside the UFS driver core.

Thanks,

Bart.


  reply	other threads:[~2025-09-23 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23  9:08 [PATCH v1] ufs: core: Change MCQ interrupt enable flow peter.wang
2025-09-23 15:54 ` Bart Van Assche [this message]
2025-09-24  9:13   ` Peter Wang (王信友)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9f1ce41-b81d-490e-b919-a6105ed34ff0@acm.org \
    --to=bvanassche@acm.org \
    --cc=alice.chao@mediatek.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=cc.chou@mediatek.com \
    --cc=chaotian.jing@mediatek.com \
    --cc=chun-hung.wu@mediatek.com \
    --cc=ed.tsai@mediatek.com \
    --cc=eddie.huang@mediatek.com \
    --cc=jejb@linux.ibm.com \
    --cc=jiajie.hao@mediatek.com \
    --cc=lin.gui@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=naomi.chu@mediatek.com \
    --cc=peter.wang@mediatek.com \
    --cc=qilin.tan@mediatek.com \
    --cc=tun-yu.yu@mediatek.com \
    --cc=wsd_upstream@mediatek.com \
    --cc=yi-fan.peng@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox