From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D1AAC5AD49 for ; Fri, 6 Jun 2025 10:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0Wm5Ysxp6GbjttnpPxWFZX/i14ZJHHqOtrosH3lsbGA=; b=aiORHFmz55rXujPjfsWIwt9NcN FCUSSQv7ThfLJNF3cTuTt/WHYqU62nA2Dxke9NNuZiZ0dHl4+L5ZlO3iwwhr3OBA9cgITKd2jov+Z LEGOyW8XKuHkqBBwJfOfV58vOrcFMdqoH2iuBZ/N56aAJkEArIRtFY2D8PRkHqEi4fLWCIA49BRau EW/SNmCdLWPViKOm5ULhW2MWozbz+MnDM5St5bVGTbmqY/g/gfMe+Q0rxmOckfBa4N54JEQFIWPrq V88FnktpYF/9V8tUJqzsYhtyOOL7cslSg5RYBAKQgT44XBaeTZtJRKnCGlhTQkrgzzZGcMz9XvcZW IsH2y2jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uNTs8-000000000C1-1g9q; Fri, 06 Jun 2025 10:00:24 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uNTs6-000000000BN-0Ypa for linux-mediatek@lists.infradead.org; Fri, 06 Jun 2025 10:00:23 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-450d37d4699so12046025e9.0 for ; Fri, 06 Jun 2025 03:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749204020; x=1749808820; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Wm5Ysxp6GbjttnpPxWFZX/i14ZJHHqOtrosH3lsbGA=; b=sa6WBeVLy5VFZ4YXqQdZD0s9ZouLmGjBSoSlUyY09sfCoF0NKWmS65fDOUaJ9RtTYY vm/XlRrEm6zIvgCEWmLUnZtHKc7HlbWKM7FPlHd0q9Xgahx19qDzBASPAohnMJ3w8dsa MgaNom2916nLi0AxXIf2L9yVYEd4k3k8UVLpbSctnw4Llb0F6d3NBK5p9CooJsSYefEj c0XwAAq92nxkGTZk2qQ4aAid0FU9dh5PdamiUnwCF4I440LfbrnyUd7VPcyC9DN1Q0qJ 6MFANIGnbVpaXxBZn7pDyNgJ9kw9PFLvFPzeWqnlpB+7AMxXF3FZYR9hiww+00kWO28b X67Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749204020; x=1749808820; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Wm5Ysxp6GbjttnpPxWFZX/i14ZJHHqOtrosH3lsbGA=; b=rA4J+mwvhwcKFhzhdUXj47YA1mWsk2tWSWxXtyeso9YY2yWi/qkGxJ1Bc0kiskf8Jk dHyzlEtVIqVoEi7wjROFUKev2ovzrsRDmi/iXpNxQiOh6BoW+3MZyWIG5fn2wBnNAPiU ZK2UP86za4DCmzWEExtsDVjClzyLuFOit2SShrx0a2Td+tpVjdlq7KyVqGzcKNC7jSE6 cASVWO0jPxwQQ7G/o60aTW8NceseBjvUFsCRyPXBBb8qQC+B/LFrYJMaYCFg1jcGbTAx IYRLTAD3aH2IetlBv3B2FOJxpa3Lb5/Ua0UyRImoCZa14XbXxn3NgduTTm5uyDrRnsEF v1Lw== X-Forwarded-Encrypted: i=1; AJvYcCXxFyNIocJL/n01lKxxfugxPoPYO9t/whXhl4A+R6iGG0/3ZZ2pl3Fhtf+qcy6ujriwxDx6DCOAWaKfFyV/0Q==@lists.infradead.org X-Gm-Message-State: AOJu0YybJNAvVs4mgFpJHkaTPBCOBZam3I87gpNMgeXX7J5daNC+7YXp +/e2QNW3Tk9K94ROFixpBX4s0chtEifu2RjC8Kfx/iKTkBbA9a2qBg7cGvkJme6WcEI= X-Gm-Gg: ASbGnctB4yAu2yruACK12R//sdWIoMxPC8TV6XUg+STp+2HTs3pbx9XbdCcJ3QRLG6p ZWWEsjqgTj/4eC3r20RkcJr6bsGVW9fzHqwEzi0GOeaAMo8xhtyFcHRIZdCgNArpDmDB7kZw+gX SsGu0pP1+fOoW8k2zyUfhLz0Yf8SrRPDVAcTNm99IjFWLIEmvXC2YPVGBq1EuzTILgs0XfoDsnd +9QurbFfXA3dor0q8X9oD1KHAm/FfmstPY1qqnFP80X8UkgIqBM/8R56aieS8am12huvIm6iRHM tEcDkZ6idugmP5lP1cl1Ch60jMKNBlQeEoxJJ9hoAM2+MgkK51wBsEGaRXvOwaDoNMjbPQ== X-Google-Smtp-Source: AGHT+IHtw37a7aLpgY1NgIlSmAhbyHbRMRvllHSnmnalrMLkUdNldLsfg2cqEgFo08aK/ax73zNvkw== X-Received: by 2002:a05:6000:25c5:b0:3a4:df80:7284 with SMTP id ffacd0b85a97d-3a53188a553mr2530102f8f.1.1749204020520; Fri, 06 Jun 2025 03:00:20 -0700 (PDT) Received: from [192.168.1.221] ([5.30.189.74]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a5324621a4sm1347436f8f.88.2025.06.06.03.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 03:00:18 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 13:00:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dmaengine: mediatek: Fix a flag reuse error in mtk_cqdma_tx_status() To: Qiu-ji Chen Cc: sean.wang@mediatek.com, vkoul@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, stable@vger.kernel.org, kernel test robot References: <20250606071709.4738-1-chenqiuji666@gmail.com> Content-Language: en-US From: Eugen Hristev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250606_030022_179106_F744667D X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 6/6/25 12:14, Qiu-ji Chen wrote: >> On 6/6/25 10:17, Qiu-ji Chen wrote: >>> Fixed a flag reuse bug in the mtk_cqdma_tx_status() function. >> If the first spin_lock_irqsave already saved the irq flags and disabled >> them, would it be meaningful to actually use a simple spin_lock for the >> second lock ? Or rather spin_lock_nested since there is a second nested >> lock taken ? >> >> Eugen >> > > Hello Eugen, > > Thanks for helpful suggestion. The modification has been submitted in > patch v2 as discussed. > > Best regards, > Qiu-ji Chen You are welcome, but in fact I suggested two alternatives. Any reason you picked this one instead of the other ?