From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DE84CEBF7B for ; Fri, 27 Sep 2024 07:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KhtQyrefSaqhSJzfUoA/J9/fh2qANj+W43YRxUZuX+Y=; b=1pPDOmxPVx6mArhIkBd5rlEy9E GsTbb8I4p+tpsIM+RRnuJEMKQSaveYMTJe589v9OzPX/oKRfjvaALXCBuNJbFsjGknQoFpbZWYeCu N193wFNIPqontmcj1zMM0ZCyjZ0LvDneQhP/CP44AIPejt7eM1Xa8dGji/MNAILEtcvouqIW16cyQ qp4XUN4kkVgaV6nJi3czzM9TpevCQoQHHE1JuOfyPQ2I2bQHUsePy93xlXB+yWxQksae/vJlX/CMk FfDRlzo5Gb+Q6tFZr920lMwFDY8pD23WaYEBMoCH+u8EHVHAN7sxhc9CNRfEVODE5/xbTIR75dIX+ 4dF9B43Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1su57C-0000000AJ3R-0Ldd; Fri, 27 Sep 2024 07:10:10 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1su4zk-0000000AHic-2sfN; Fri, 27 Sep 2024 07:02:30 +0000 X-UUID: 724d3dce7c9e11efba0aef63c0775dbf-20240927 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID; bh=KhtQyrefSaqhSJzfUoA/J9/fh2qANj+W43YRxUZuX+Y=; b=sFZxV/xMwDiMvGobRU1JZm9noSsIRRD6f12cT9MGhE0Vt6gX3NbjWyoTEoXCt8GhMJDvXHXjZFhc3uFKRfl1Vsdxq9WpEVsVr1MiQcG8XPB9A+itFlc6Al1om2XlgJxw81u1papC5tARdGLCkbPaRX8Eto6gjMWYYVQKP7cCuEc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.41,REQID:e2bc4d87-851d-4ac5-85a6-b517ee1f0d27,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6dc6a47,CLOUDID:b3f5a69e-8e9a-4ac1-b510-390a86b53c0a,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0|-5,EDM:-3,IP:ni l,URL:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: 724d3dce7c9e11efba0aef63c0775dbf-20240927 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 872547278; Fri, 27 Sep 2024 00:02:23 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 27 Sep 2024 15:02:19 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 27 Sep 2024 15:02:18 +0800 Message-ID: Date: Fri, 27 Sep 2024 15:02:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 5/5] dt-bindings: display: mediatek: dpi: Add mt8195 support in power domains Content-Language: en-US To: Conor Dooley CC: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yong Wu , "Joerg Roedel" , Will Deacon , Robin Murphy , Matthias Brugger , AngeloGioacchino Del Regno , CK Hu , Jitao shi , Tinghan Shen , Seiya Wang , Ben Lok , "Nancy . Lin" , , , , , , , "Alexandre Mergnat" , Bear Wang , "Pablo Sun" , Macpaul Lin , Sen Chu , Chris-qj chen , "MediaTek Chromebook Upstream" , Chen-Yu Tsai References: <20240926111449.9245-1-macpaul.lin@mediatek.com> <20240926111449.9245-5-macpaul.lin@mediatek.com> <20240926-visible-harmonica-a7cda103ff70@spud> From: Macpaul Lin In-Reply-To: <20240926-visible-harmonica-a7cda103ff70@spud> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--11.014300-8.000000 X-TMASE-MatchedRID: L8tZF6zWW2oOwH4pD14DsPHkpkyUphL9MZm0+sEE9ms+zqOf/RM2rvFo ODtDoX2Qa8dzyZlF6/UhzQ5Mp0WQPT7dljlY/nlHSEQN/D/3cG6Vq+okl1rYDwDqzaYhcjeQLPv NvFI8A1X8iIBnP6y347s9OusH9JJyzB1CJ6qmdNrhuXUWQoMQtzQsOZ4mhPfZDO+DX+rUwfZjOk Y6jTBnQ10EtLM2oIeDMPuSmMtOM67I2RqSAXh33hlckvO1m+JcfLPKYyLDlAebKItl61J/ycnjL TA/UDoAoTCA5Efyn8CNo+PRbWqfRDsAVzN+Ov/stFRELSGgUUwRPXFwDjp7875XMMt8JxNIHRRl YMHNv0WZTXkb2/rFPg== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.014300-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: A017A170104B5427D244883B62BFD51C539651236B943B919967563A14DF14A42000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240927_000228_794206_6C3CBF2B X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 9/26/24 23:59, Conor Dooley wrote: > On Thu, Sep 26, 2024 at 07:14:49PM +0800, Macpaul Lin wrote: >> Add power domain binding to the mediatek DPI controller for MT8185. > > This wording is confusing, no binding is being added here, you're just > allowing one property. > >> The dpi node in mt8195.dtsi was triggering a dtbs_check error: >> dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] > > And while it is good to have the warning, it would be better to explain > here that there are actually power domains, since the dts could be wrong > here also. Thanks for the reminder! After MediaTek's internal discussion, a new patch v3 has been submitted. The details has been written in that patch. > Otherwise, > Acked-by: Conor Dooley Since the new patch v3 use a different approach to update the DT Schema, the "Acked-by:" tag has been dropped, please help to review the replacement v3 patch. Thanks! >> Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") >> Signed-off-by: Macpaul Lin >> --- >> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> Changes for v2: >> - Because of the corresponding dts fix has been reviewed with a Reviewed-by: tag. >> [1] https://lore.kernel.org/all/20240925080515.16377-1-macpaul.lin@mediatek.com/ >> We still need this change to fix the 2 dtbs_check errors. >> So keeps no change here. >> Best regards, Macpaul Lin