From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3B94C4345F for ; Tue, 16 Apr 2024 07:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cQoXqxQGz5UdNS/uHt9iOu3c65OCBEQl1AjepevvRYw=; b=XG9fXzCYN0Aij4yMKI/+2ncyQ0 242ppELWuGhIVP9aiYyhqCwNoRtZPsA8rlG452LrduEyA6PU4i9UCiMYFodQBb0lvKr3RkfvORlf/ +9qb1k9aqbLVoAxPFxYCx55lX2ySM1QaFy7bfnE9Oi8lvcQDw4d9Zu+5Ajb4Ge7oEnvG0rUcN9Wan NGaLjo6LmJvKnzgEXzjvBgKyRoAVaxDT7qPluV3QW/GuIo4jsXm0wPDgWAtwYpW7AjnH7OmhES/Rh t0CwZa0ggKmpFlnXAOeBlZ3CoJBTthTP61gRkbk24ISxr+ypdxEY04KSoTVs1GNdz5SNF6UC5gOwq rW7IcX5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwdGt-0000000BHCY-0rZo; Tue, 16 Apr 2024 07:30:27 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwdGk-0000000BH9e-0g1w for linux-mediatek@lists.infradead.org; Tue, 16 Apr 2024 07:30:22 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a4715991c32so515466566b.1 for ; Tue, 16 Apr 2024 00:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713252616; x=1713857416; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cQoXqxQGz5UdNS/uHt9iOu3c65OCBEQl1AjepevvRYw=; b=fTWXbKyWTlB5T+dd5qcb2eiWVgtufJgPC6FBOq39jON889TJDaiWBidwmGUz3Hgiph XQCj6ewGxnNFSXcROzHEASQw0SDKeRo/EZMd6OXpuOOJ65kZJJz3T8LmOHjtc3dJZXVa bNdsvMjwU1Gv3THqbK/NssS+l+XaUZ5U9cunr97uzAf7/gfjPmkceQpPxnhejcOyoO69 GfegkiQWaaivwEztEr8bqZ+FmU11c+GdiSfVKAX0s2Tr8O+9XMtbwrxI6VZISjzAe0K1 AczH3WWwQQVCoywtsigd/BtyHJkAyfHTgNdeJ+l+Eq34IJ0Zunx2tRUj18/4+41OG4CJ vnSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713252616; x=1713857416; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cQoXqxQGz5UdNS/uHt9iOu3c65OCBEQl1AjepevvRYw=; b=NIyOd9itcOLLLIYR13SI47bwR51T5JzFgtpNbzSS0H/bA8QfTKIjeEquoBPwJghSvo 4jz0QVVLApW9jS8SkmfvIbSuGE/LcMbkYpK5GqoUPOSWozsiDdwO4C05aLRNeZOjSBWy /w/sJQwPx81dJsU1w9EAzTikiN907QCb2cPwqyqyHPmOa+25FPmlUeYQtX2g7JkSXmtC CrXBgVOMTTyxCdcX4m0L+IEtyIzdb2bT3n3qJX/cw4xiiIL3Lv9Y73Y/weG/MStGT/Nd vcr2WnoCHARCm4tfLzVxT2syeCjWVQOwIuyHeC21AFVRfgASl9fmuVnuqinlY8io6C2w GNXw== X-Forwarded-Encrypted: i=1; AJvYcCUaC89Cj0YxyatUsM57+1vVHzCaJ/EeLfHCzotJLzlYh846Fu7J8rhkIVvkXBSKAsjWFPUhg5SklSUhpibZLahBOBtx5BpgtsLZWBkrAZaVCf9R X-Gm-Message-State: AOJu0YxmV5F/BKZzUdvjfYh2cfB7fYscnNfwCjj1cPHJWiYqCce7YXlx BfiitSHPKY0jOCvl9xKjYqVvbUXvAaGbuYieFW2iAQhcRHnLvsYrZMt9INqYC3o= X-Google-Smtp-Source: AGHT+IES0flyaPsDqcItqmrdcMlT/9HhmNC59nIBd1+qe6iKBoJLQjAdExVi7n8xHc0r8DPQuGmsnQ== X-Received: by 2002:a17:906:fd89:b0:a52:24b7:b4fc with SMTP id xa9-20020a170906fd8900b00a5224b7b4fcmr9643955ejb.72.1713252616011; Tue, 16 Apr 2024 00:30:16 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id h14-20020a1709070b0e00b00a518c69c4e3sm6421654ejl.23.2024.04.16.00.30.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 00:30:15 -0700 (PDT) Date: Tue, 16 Apr 2024 10:30:11 +0300 From: Dan Carpenter To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 06/35] media: stm32-dcmipp: Remove redundant printk Message-ID: References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-6-477afb23728b@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415-fix-cocci-v1-6-477afb23728b@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_003018_308534_57328AE2 X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2024 at 07:34:23PM +0000, Ricardo Ribalda wrote: > platform_get_irq() already prints an error message. > > Found by cocci: > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c:444:3-10: line 444 is redundant because platform_get_irq() already prints an error > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > index bce821eb71ce..c25027b0ca32 100644 > --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > @@ -439,11 +439,8 @@ static int dcmipp_probe(struct platform_device *pdev) > "Could not get reset control\n"); > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - if (irq != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Could not get irq\n"); > + if (irq <= 0) > return irq ? irq : -ENXIO; platform_get_irq() can never return zero so this should be written as: irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; There is a comment next to platform_get_irq() which documents this. regards, dan carpenter