From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70294C4332F for ; Tue, 18 Oct 2022 13:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aY/hgobPZsNZv7mg2D2+Woh85d7H5Ew2iMo3aX0Jkh4=; b=El56AxFlYNT3nJNwDICufThKks p7PN65K+SjLdUXefGIaaclOlZhaihwTNrQRWVwQwPj8BCPyaR5ElSGDAmC6LCg2ni47LhFUR2vKyQ zmFYzXp1/z+Gx1eIDUe/CfmfiQ6uh6toJ+TVm9LTidpjeyC45VxHgvUnD0x2tkyC+w4WmDNOYcKsM lA/emF9dVAXY5Ldf94Wdx5Bsh9NjaYjL6EMbuE8DVlJQalsLdBo8GRq0aDIdFz0nTqcgWCxiRNIuk jgN/NOaEHoPHeA5SRrVSEV8nv2dg3R+LrfsH6yw0tLGe29L0IAQtWTNtZ/wYdJ3mTW2lrbkWywCc8 T7U9AM8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okmwd-0079Gb-Rl; Tue, 18 Oct 2022 13:47:47 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okmwR-0079Bx-Tv; Tue, 18 Oct 2022 13:47:37 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 13EBB18848B0; Tue, 18 Oct 2022 13:47:28 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id F349E25001FA; Tue, 18 Oct 2022 13:47:27 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id E7C529EC0009; Tue, 18 Oct 2022 13:47:27 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Tue, 18 Oct 2022 15:47:27 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v7 net-next 3/9] net: switchdev: add support for offloading of the FDB locked flag In-Reply-To: References: <20221009174052.1927483-1-netdev@kapio-technology.com> <20221009174052.1927483-4-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_064736_151874_4F66EABB X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 2022-10-18 08:22, Ido Schimmel wrote: > On Thu, Oct 13, 2022 at 08:58:57PM +0200, netdev@kapio-technology.com > wrote: >> On 2022-10-13 16:06, Ido Schimmel wrote: >> > > diff --git a/net/dsa/port.c b/net/dsa/port.c >> > > index e4a0513816bb..eab32b7a945a 100644 >> > > --- a/net/dsa/port.c >> > > +++ b/net/dsa/port.c >> > > @@ -304,7 +304,7 @@ static int dsa_port_inherit_brport_flags(struct >> > > dsa_port *dp, >> > > struct netlink_ext_ack *extack) >> > > { >> > > const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD | >> > > - BR_BCAST_FLOOD | BR_PORT_LOCKED; >> > > + BR_BCAST_FLOOD; >> > >> > Not sure how this is related to the patchset. >> > >> >> In general it is needed as a fix because of the way learning with >> locked >> port is handled in the driver, >> so as with MAB and also locked port in the future needing a non-zero >> Port >> Association Vector (PAV) >> for refresh etc to work, inheritance of the locked port flag is a bad >> idea >> (say bug) and shouldn't have >> been in the first place. > > If it's a fix, then it needs to be submitted to 'net' tree. It is a 'fix' for this patch set, as it changes mv88e6xxx_port_set_lock() to need this change. It is not strictly necessary to change it for earlier hehaviour.