* [PATCH v2 0/9] cpufreq: Add flag to auto-register as cooling
@ 2019-01-21 15:40 Amit Kucheria
2019-01-21 15:40 ` [PATCH v2 6/9] cpufreq: mediatek: Use auto-registration of thermal cooling device Amit Kucheria
0 siblings, 1 reply; 2+ messages in thread
From: Amit Kucheria @ 2019-01-21 15:40 UTC (permalink / raw)
To: linux-kernel
Cc: linux-arm-msm, viresh.kumar, edubezval, swboyd, dianders, mka,
Rafael J. Wysocki, Daniel Lezcano, Matthias Brugger, Sudeep Holla,
Zhang Rui, moderated list:ARM/Mediatek SoC support, linux-pm,
moderated list:ARM/Mediatek SoC support
Add a flag to be used by cpufreq drivers to tell cpufreq core to
auto-register themselves as a thermal cooling device.
There series converts over all the drivers except arm_big_little.c.
Tested on SDM845 with the qcom-cpufreq-hw driver. Only compile-tested the
others.
Things needing fixing (but not a blocker for the series):
- Look at how to detect that we're not in IKS mode in arm_big_little's
.ready callback.
Changes since v1:
- Fix compilation failures with allmodconfig
- Get rid of #ifdef in cpufreq.c
- Removed miscellaneous patches and sent them separately
- Merged patches 1 and 2 from v1
Amit Kucheria (9):
thermal: cpu_cooling: Require thermal core to be compiled in
cpufreq: Auto-register the driver as a thermal cooling device if asked
cpufreq: qcom-hw: Register as a cpufreq cooling device
cpufreq: imx6q: Use auto-registration of thermal cooling device
cpufreq: cpufreq-dt: Use auto-registration of thermal cooling device
cpufreq: mediatek: Use auto-registration of thermal cooling device
cpufreq: qoriq: Use auto-registration of thermal cooling device
cpufreq: scmi: Use auto-registration of thermal cooling device
cpufreq: scpi: Use auto-registration of thermal cooling device
drivers/cpufreq/cpufreq-dt.c | 14 ++------------
drivers/cpufreq/cpufreq.c | 6 ++++++
drivers/cpufreq/imx6q-cpufreq.c | 24 ++----------------------
drivers/cpufreq/mediatek-cpufreq.c | 14 ++------------
drivers/cpufreq/qcom-cpufreq-hw.c | 3 ++-
drivers/cpufreq/qoriq-cpufreq.c | 15 ++-------------
drivers/cpufreq/scmi-cpufreq.c | 14 ++------------
drivers/cpufreq/scpi-cpufreq.c | 14 ++------------
drivers/thermal/Kconfig | 1 +
include/linux/cpufreq.h | 25 +++++++++++++++++++++++++
10 files changed, 46 insertions(+), 84 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 6/9] cpufreq: mediatek: Use auto-registration of thermal cooling device
2019-01-21 15:40 [PATCH v2 0/9] cpufreq: Add flag to auto-register as cooling Amit Kucheria
@ 2019-01-21 15:40 ` Amit Kucheria
0 siblings, 0 replies; 2+ messages in thread
From: Amit Kucheria @ 2019-01-21 15:40 UTC (permalink / raw)
To: linux-kernel
Cc: linux-arm-msm, viresh.kumar, edubezval, swboyd, dianders, mka,
Rafael J. Wysocki, Matthias Brugger, Sean Wang, linux-pm,
linux-arm-kernel, linux-mediatek
Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to
automatically register as a thermal cooling device.
This allows removal of boiler plate code from the driver.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
drivers/cpufreq/mediatek-cpufreq.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index eb8920d39818..9a937f4c63e7 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -14,7 +14,6 @@
#include <linux/clk.h>
#include <linux/cpu.h>
-#include <linux/cpu_cooling.h>
#include <linux/cpufreq.h>
#include <linux/cpumask.h>
#include <linux/module.h>
@@ -48,7 +47,6 @@ struct mtk_cpu_dvfs_info {
struct regulator *sram_reg;
struct clk *cpu_clk;
struct clk *inter_clk;
- struct thermal_cooling_device *cdev;
struct list_head list_head;
int intermediate_voltage;
bool need_voltage_tracking;
@@ -307,13 +305,6 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
#define DYNAMIC_POWER "dynamic-power-coefficient"
-static void mtk_cpufreq_ready(struct cpufreq_policy *policy)
-{
- struct mtk_cpu_dvfs_info *info = policy->driver_data;
-
- info->cdev = of_cpufreq_cooling_register(policy);
-}
-
static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
{
struct device *cpu_dev;
@@ -472,7 +463,6 @@ static int mtk_cpufreq_exit(struct cpufreq_policy *policy)
{
struct mtk_cpu_dvfs_info *info = policy->driver_data;
- cpufreq_cooling_unregister(info->cdev);
dev_pm_opp_free_cpufreq_table(info->cpu_dev, &policy->freq_table);
return 0;
@@ -480,13 +470,13 @@ static int mtk_cpufreq_exit(struct cpufreq_policy *policy)
static struct cpufreq_driver mtk_cpufreq_driver = {
.flags = CPUFREQ_STICKY | CPUFREQ_NEED_INITIAL_FREQ_CHECK |
- CPUFREQ_HAVE_GOVERNOR_PER_POLICY,
+ CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
+ CPUFREQ_AUTO_REGISTER_COOLING_DEV,
.verify = cpufreq_generic_frequency_table_verify,
.target_index = mtk_cpufreq_set_target,
.get = cpufreq_generic_get,
.init = mtk_cpufreq_init,
.exit = mtk_cpufreq_exit,
- .ready = mtk_cpufreq_ready,
.name = "mtk-cpufreq",
.attr = cpufreq_generic_attr,
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-21 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-21 15:40 [PATCH v2 0/9] cpufreq: Add flag to auto-register as cooling Amit Kucheria
2019-01-21 15:40 ` [PATCH v2 6/9] cpufreq: mediatek: Use auto-registration of thermal cooling device Amit Kucheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).