From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E875BC05027 for ; Mon, 6 Feb 2023 21:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:Content-Type:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/HPkf5YsTIOCnzVDtCplioRqVVDpwJJJeFUzxZkAr8c=; b=qYZAHXUXV7jlLiUUQL5qodA34y 4643uKdR+zvqoyRh499FoBhQOLR0n+wxWp3rC82Tc4wV/EPApGvH9vD3sQILyw8x9q9zvKZgOD4yQ XMdsODiWIHlA3MYB1I3aJvUbhRymBa/VbR6DzyNGPFjwDoAsU8Etvl/54YqsJZV8j3i+MXzALBTGj 2rDRY9cdIWuZVA10veBUSOHsuBi4cC7NbJR2ApCFinypEdy3fjkR53cED6jC0wRf4iUlEuL7pvN8J DW2Nfg7iUfa5bponaBDrH4rKf6ro1ckGnCSemfNR3Mv1Ug+DgaDMLlpRDMpyDo9cCUrKbDZ4dsThn j5IttThw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP8b4-009vSV-OV; Mon, 06 Feb 2023 21:00:18 +0000 Received: from sender4-op-o16.zoho.com ([136.143.188.16]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP8at-009vPs-K5; Mon, 06 Feb 2023 21:00:09 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1675717183; cv=none; d=zohomail.com; s=zohoarc; b=YCWwRuDdHCFI3y42hfY/nbUOP+GanWFxDNmJj675CvfKJYeKzDxmVX9oJvxqfKmeAZxDrcnFxYn8jVmadHHq+hiQZ3hyQTOtNCihZxZX6+qnnjtqkp4tVcmQbgerJkSgsfJHur3cqS2Mi7xVr2s55rTALn9DUtOtKFufJo3XkmQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675717183; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=/HPkf5YsTIOCnzVDtCplioRqVVDpwJJJeFUzxZkAr8c=; b=DJmiFPA1+izZIHd/MPAMDzKt1ScYlEM6Cj2tyDZUf4+4wi80rvXWjpUVbPbc0SYr+qLSa/YcvNPju40N86aGq1MwF1of00t1saksy76ZJuBViR4CkRcLLAjDL2AGCnt+9Z3ci2kYruWmsn17WzeZQLOlA/BWj7LyY/T/UHv90Z8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1675717183; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Content-Type:Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Message-Id:Reply-To; bh=/HPkf5YsTIOCnzVDtCplioRqVVDpwJJJeFUzxZkAr8c=; b=XSQBAMOHuPh/M8oUFzk9wiC7zF0vQIbHdqpMfrso1PMoPVtUqVtmH3Nc9kXWTZj9 V32atz5//fuBnfSowrL6am+NLoCKhjENflu3u3SY85+lYet8/fuA0+ksU3lDTh7GPtt /2KS0+rHdGUcWw5ckspUJpNMcaT2u2b35Fc1AKTM= Received: from [10.10.10.3] (31.223.26.239 [31.223.26.239]) by mx.zohomail.com with SMTPS id 1675717182038197.75552933950325; Mon, 6 Feb 2023 12:59:42 -0800 (PST) Content-Type: multipart/mixed; boundary="------------I37axy810XQiqT7HWyRq3zRz" Message-ID: Date: Mon, 6 Feb 2023 23:59:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH net] net: dsa: mt7530: don't change PVC_EG_TAG when CPU port becomes VLAN-aware To: Vladimir Oltean References: <20230205203906.i3jci4pxd6mw74in@skbuf> <20230205235053.g5cttegcdsvh7uk3@skbuf> <116ff532-4ebc-4422-6599-1d5872ff9eb8@arinc9.com> <20230206174627.mv4ljr4gtkpr7w55@skbuf> <5e474cb7-446c-d44a-47f6-f679ae121335@arinc9.com> <20230206203335.6uxfiylftyktut5u@skbuf> <4ee5df8d-618b-db78-9c14-17a45e383b67@arinc9.com> <20230206204228.sa45cvco6bltidwq@skbuf> Content-Language: en-US From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <20230206204228.sa45cvco6bltidwq@skbuf> X-Zoho-Virus-Status: 1 X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230206_130007_745253_6CBDAB73 X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Landen Chao , Florian Fainelli , netdev@vger.kernel.org, Sean Wang , linux-kernel@vger.kernel.org, richard@routerhints.com, DENG Qingfang , Eric Dumazet , linux-mediatek@lists.infradead.org, Matthias Brugger , Jakub Kicinski , Paolo Abeni , erkin.bozoglu@xeront.com, "David S. Miller" , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org This is a multi-part message in MIME format. --------------I37axy810XQiqT7HWyRq3zRz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6.02.2023 23:42, Vladimir Oltean wrote: > On Mon, Feb 06, 2023 at 11:35:50PM +0300, Arınç ÜNAL wrote: >> On 06/02/2023 23:33, Vladimir Oltean wrote: >>> On Mon, Feb 06, 2023 at 10:41:47PM +0300, Arınç ÜNAL wrote: >>>> One last thing. Specific to MT7530 switch in MT7621 SoC, if port@5 is the >>>> only CPU port defined on the devicetree, frames sent from DSA master appears >>>> malformed on the user port. Packet capture on computer connected to the user >>>> port is attached. >>>> >>>> The ARP frames on the pcapng file are received on the DSA master, I captured >>>> them with tcpdump, and put it in the attachments. Then I start pinging from >>>> the DSA master and the malformed frames appear on the pcapng file. >>>> >>>> It'd be great if you could take a look this final issue. >>> >>> What phy-mode does port@5 use when it doesn't work? What about the DSA master? >> >> It's rgmii on port@5 and gmac1. > > What kind of RGMII? Plain "rgmii" on both ends, with no internal delays? > With RGMII, somebody must add a skew to the clock signal relative to the > data signals, so that setup/hold times at the other end are not violated. > Either the transmitter or the receiver can add RGMII delays in each > direction of communication, but someone must do it, and no more than one > entity should do it. > > So my question would be: could you retry after replacing phy-mode = "rgmii" > with phy-mode = "rgmii-id" on port@5? And if that doesn't change anything > (unlikely but possible), also try "rgmii-txid" and "rgmii-rxid" in port@5? > Don't change the phy-mode on gmac1. Still getting malformed frames. Packet capture for each phy-mode is attached. Made sure the phy-mode with: # cat /proc/device-tree/ethernet@1e100000/mac@1/phy-mode rgmii # cat /proc/device-tree/ethernet@1e100000/mdio-bus/switch@1f/ports/port@5/phy-mode rgmii-id # cat /proc/device-tree/ethernet@1e100000/mdio-bus/switch@1f/ports/port@5/phy-mode rgmii-txid # cat /proc/device-tree/ethernet@1e100000/mdio-bus/switch@1f/ports/port@5/phy-mode rgmii-rxid Arınç --------------I37axy810XQiqT7HWyRq3zRz Content-Type: application/x-pcapng; name="rgmii-id.pcapng" Content-Disposition: attachment; filename="rgmii-id.pcapng" Content-Transfer-Encoding: base64 Cg0NCrgAAABNPCsaAQAAAP//////////AgA2AEludGVsKFIpIENvcmUoVE0pIGk3LTg3MDBL IENQVSBAIDMuNzBHSHogKHdpdGggU1NFNC4yKQAAAwAXAExpbnV4IDUuMTkuMC0yOS1nZW5l cmljAAQAOgBEdW1wY2FwIChXaXJlc2hhcmspIDMuNi43IChHaXQgdjMuNi43IHBhY2thZ2Vk IGFzIDMuNi43LTEpAAAAAAAAuAAAAAEAAABIAAAAAQAAAAAABAACAAYAZW5wOXMwAAAJAAEA CQAAAAwAFwBMaW51eCA1LjE5LjAtMjktZ2VuZXJpYwAAAAAASAAAAAYAAABcAAAAAAAAAIZX QRcJjCxpPAAAADwAAAD//17/mlc+eMWU+oItpwABCAAGAAABPnjFlNqCgKgCAQAAAAAAoMCo AgIAAAAAAAAAAAAAAAAAAKg7CMJcAAAABgAAAFwAAAAAAAAAhldBF1VSMKU8AAAAPAAAAP// //+f98CoAgIAAAAgAAAAAAAAAAAAAKg7GNIAAMUlNeOI8QgQKBicy8gTkRXjpE2mzAu1N5fC ZpsOEVwAAAAGAAAAXAAAAAAAAACGV0EXPGk54jwAAAA8AAAA/////5//PnjFlNqCKaYAAQgA hgAIAT54xZTagoCgAgEAAAAAACDAqAICAAAAAAAAAAAAAAAAAACoOxjWXAAAAAYAAABcAAAA AAAAAIdXQRemS31YPAAAADwAAAD////////AqAICAAAAIAAAAAAAAAAAAACoOxjWAAACDL7U AAMAAwAAAAQAAACEAAAAAQAAAKMAAAAEAABcAAAABgAAAFwAAAAAAAAAh1dBFx2PhZU8AAAA PAAAAP///v+f9z54xZTagimmAAEIAIYACAE+eMWUWoKAgAIBAAAAAAAgwKgCAgAAAAAAAAAA AAAAAAAAqDsY1lwAAAAGAAAAXAAAAAAAAACHV0EXWQaP0jwAAAA8AAAA///+/5//wKgCAgAA ACAAAAAAAAAAAAAAqDsYwgAAAgxA8wADAAQAAAFwSDICAAAAAAMAACEEAAAAAAAAXAAAAAYA AABcAAAAAAAAAIhXQRcL1d5HPAAAADwAAAD//17/mhc+eMWU2oIppgABCAAGAAABPnjFlNqC gKACAQAAAAAAqMCoAgIAAAAAAAAAAAAAAAAAAKg7GNJcAAAABgAAAFwAAAAAAAAAiFdBFwv8 8oM8AAAAPAAAAP//Xv+aFz54xZTagimmAAEIAAYAAAE+eMWU2oKAqAIBAAAAAACgwKgCAgAA AAAAAAAAAAAAAAAAqDsY0lwAAAAGAAAAXAAAAAAAAACIV0EXmJT8wDwAAAA8AAAA///+/5/3 wKgCAgAAACAAAAAAAAAAAAAAqDsY1gAAAAAADwAAAAAAAAABQnAQADAAAAAAACUDAAAABAAA XAAAAAUAAABsAAAAAAAAAA70BQA9YaQ3AQAcAENvdW50ZXJzIHByb3ZpZGVkIGJ5IGR1bXBj YXACAAgADvQFAD6QqTYDAAgADvQFAHlgpDcEAAgACQAAAAAAAAAFAAgAAAAAAAAAAAAAAAAA bAAAAA== --------------I37axy810XQiqT7HWyRq3zRz Content-Type: application/x-pcapng; name="rgmii-rxid.pcapng" Content-Disposition: attachment; filename="rgmii-rxid.pcapng" Content-Transfer-Encoding: base64 Cg0NCrgAAABNPCsaAQAAAP//////////AgA2AEludGVsKFIpIENvcmUoVE0pIGk3LTg3MDBL IENQVSBAIDMuNzBHSHogKHdpdGggU1NFNC4yKQAAAwAXAExpbnV4IDUuMTkuMC0yOS1nZW5l cmljAAQAOgBEdW1wY2FwIChXaXJlc2hhcmspIDMuNi43IChHaXQgdjMuNi43IHBhY2thZ2Vk IGFzIDMuNi43LTEpAAAAAAAAuAAAAAEAAABIAAAAAQAAAAAABAACAAYAZW5wOXMwAAAJAAEA CQAAAAwAFwBMaW51eCA1LjE5LjAtMjktZ2VuZXJpYwAAAAAASAAAAAYAAADEAAAAAAAAAMBX QReEiPzzpAAAAKQAAAD//17/mleyZWfY8I8ppsCoAgIAAAAAAAAAAAAAAAAAAA6eHugAAH1M T36UCwIFhBg2/lTKHLbrDyHj2osMmkMN3Nmdf7s8mqk09L/dL5hiGMth+MQYbYLBPJ9WSoB2 4KzC1wTictugSsWV2nvXIHxyvSOKKewscluykrxdEKTEgR1lK7Ug4YZ4UU4PrzCBoT715RUG gKzdMf/3sgByKPi5NocG0MQAAAAGAAAA3AAAAAAAAADBV0EX3lO4MLoAAAC6AAAA//9e/5v3 smVn2PCPKaYAAQgABgQAAbJlZ9hQj4AAAgEAAAAAAKDAqAICAAAAAAAAAAAAAAAAAAAOnl7o AADFJTXjiPEIACgYnMuIE5kd46RNpkwLsTaXwmabDgGyhNUjnjAEOxykGGi5hMlQMYc8/GV5 HBggo/o/wrEQETQGYQBv6rIbV9ZQ5Tn1AYJigtqtTpk4DbOD3VNgUgrXhsQ1qItcAhEiZmTS ND8fIhBAlC49vY+v9y8woTP8AADcAAAABgAAAFwAAAAAAAAAwVdBF3/twG08AAAAPAAAAP// Xv+aV7JlZ9jwjymmAAEIAAYEAAHAqAICAAAAAAAAAAAAAAAAAAAOng7oAACZoGH+gEoQA0vo WlEa0FwAAAAGAAAAXAAAAAAAAADBV0EX2N5L4zwAAAA8AAAA//9e/5pXwKgCAqAAIakAAAAA AAAAAAAADp7e6AAAAgyrhwADAAIAAAACAAAAAHJlZ3VMYRBHci0zdjIAXAAAAAYAAABcAAAA AAAAAMJXQRf4eCMfPAAAADwAAAD//17/m9fAqAICAAAhIAAAAAAAAAAAAAAOnl7oAAACDH78 gAMAAwAAAAQAAAAEAAAAAQAAAKMAAAAEAABcAAAABgAAAFwAAAAAAAAAwldBF2xSK1w8AAAA PAAAAP//Xv+bV7JlZ9jwjymmAAEIAAYEAAGyZWfYAI+AAQIBAAAAAACowKgCAgAAAADAqAIC AAAAAAAAAAAAAFwAAAAFAAAAbAAAAAAAAAAO9AUAQ8J2RgEAHABDb3VudGVycyBwcm92aWRl ZCBieSBkdW1wY2FwAgAIAA70BQA1wqdFAwAIAA70BQCuwXZGBAAIAAYAAAAAAAAABQAIAAAA AAAAAAAAAAAAAGwAAAA= --------------I37axy810XQiqT7HWyRq3zRz Content-Type: application/x-pcapng; name="rgmii-txid.pcapng" Content-Disposition: attachment; filename="rgmii-txid.pcapng" Content-Transfer-Encoding: base64 Cg0NCrgAAABNPCsaAQAAAP//////////AgA2AEludGVsKFIpIENvcmUoVE0pIGk3LTg3MDBL IENQVSBAIDMuNzBHSHogKHdpdGggU1NFNC4yKQAAAwAXAExpbnV4IDUuMTkuMC0yOS1nZW5l cmljAAQAOgBEdW1wY2FwIChXaXJlc2hhcmspIDMuNi43IChHaXQgdjMuNi43IHBhY2thZ2Vk IGFzIDMuNi43LTEpAAAAAAAAuAAAAAEAAABIAAAAAQAAAAAABAACAAYAZW5wOXMwAAAJAAEA CQAAAAwAFwBMaW51eCA1LjE5LjAtMjktZ2VuZXJpYwAAAAAASAAAAAYAAABcAAAAAAAAAKlX QRdItN2pPAAAADwAAAD//17/mlcSyYnwpeIppgABCAAGAAABEsmJ8KXigKgCAQAAAAAAqMCo AgIAAAAAAAAAAAAAAAAAAEg0FohcAAAABgAAAFwAAAAAAAAAqVdBF3R3Hec8AAAAPAAAAP// DvuaBxLJifCl4immAAEIAAYAAAESyYnwBOKAAAIBAAAAAACowKgCAgAAAAAAAAAAAAAAAAAA SDQWiFwAAAAGAAAAXAAAAAAAAACqV0EXn/YlJDwAAAA8AAAA//9e/5pXEsmJ8KXiKacAAQgA BgAIARLJifCl4sCoAgEAAAAAAKjAqAICAAAAAAAAAAAAAAAAAABINBaIXAAAAAYAAABcAAAA AAAAAKpXQRe38TaZPAAAADwAAAD//177mgcSyYnwpeIppgABCAAGAAABEsmJ8CTigKACAQAA AAAAoMCoAgIAAAAAAAAAAAAAAAAAAEg0FohcAAAABgAAAFwAAAAAAAAAqldBFwskh9U8AAAA PAAAAP//HvuaBxLJifCl4imnAAEIAAYAAAESyYnwBOKAoAIBAAAAAACowKgCAgAAAAAAAAAA AAAAAAAASDQWiFwAAAAGAAAAXAAAAAAAAACrV0EXY8OPEjwAAAA8AAAA//8e+5oHEsmJ8KXi KSYAAQgABgQAARLJifAE4oAAAgEAAAAAAKDAqAICAAAAAAAAAAAAAAAAAABINFaIXAAAAAYA AABcAAAAAAAAAKtXQRfUuZSIPAAAADwAAAD//x77mgfAqAICAAAhqQAAAAAAAAAAAABINFaI AAACDB9vAAMABAAAAXAIMgIAAAAAAwAAIQQAAAAAAABcAAAABgAAAFwAAAAAAAAAq1dBF8Lp 2cU8AAAAPAAAAP//Xv+aVxLJifCl4imnAAEIAAYAAAESyYnwpeLAqAIBAAAAAACowKgCAgAA AAAAAAAAAAAAAAAASDQWiFwAAAAGAAAAXAAAAAAAAACsV0EXJefhAjwAAAA8AAAA//9e+5pH EsmJ8KXiKaYAAQgABgAAARLJifCl4oCgAgEAAAAAAKjAqAICAAAAAAAAAAAAAAAAAABINBaI XAAAAAUAAABsAAAAAAAAAA70BQCBXKVAAQAcAENvdW50ZXJzIHByb3ZpZGVkIGJ5IGR1bXBj YXACAAgADvQFAKnb2T8DAAgADvQFAO1bpUAEAAgACQAAAAAAAAAFAAgAAAAAAAAAAAAAAAAA bAAAAA== --------------I37axy810XQiqT7HWyRq3zRz--