From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFF99C4167D for ; Thu, 14 Dec 2023 10:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P6kA/TcTtHmmCSA/0udfKgMiWzW+AjYlMCnXuY0z2Ec=; b=XTHvvAizyq7BQXDFBxEto2NUXj yGf/MKqR/qc4W8t3i1PMRkpuGqEuzSdw9evFuskBltT6oqhbUh2pW+7lMQd9SRMaz1cfgAZlIRtNM MwGmP128x7aqCk2+wiQSX1MqNZqbTl4oLWKE6pl75iTS+wdjXOm7Wy2t/dcb9SmfnJfKoMuEEUVyf FKeQYr2r7HM75IVswrUi28T6SW10JG0NLp6x1dW62G31ed8C2YNMpLxxXamgqkfzMx6Mtuz+9H3vz a4djOIwbLk6X1YApo5oFME/G3IXjlkLxA8CbEB51r79X9yC8rT+MZpPjGLPMe453XvcJUTfrQBPiS aE6fiakA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDjCj-00HW1k-03; Thu, 14 Dec 2023 10:44:33 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDjCf-00HW0T-02; Thu, 14 Dec 2023 10:44:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702550667; bh=cAT6HmiYeTlVqmi2uXEf6RyUkhAQ2o/TgivLiKg7xng=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oWZ3jLXIEj3UPozYna6D0FNBFm7legTk4Y4t7BniXyaUMxwmAwhzkg9r8Gp3XQe4j tbZqks35ReyaJajZ0HLf0nWlB3zhDnGXnQ0L8Qz4QXwFFQcJu0fthEka0uiG/MGgrt aKW5P+8QbPvl9Dt00r7ggoWmVFcO+D+P8iWrXjGIUONSQgiS5kJhgiV9TURHNpeiVm pz2GZYxVFMALQGy/UyzsDmWqZY5uCIaSWIN4qVXaYZgKLvKGVinPLa0AaxYby8bwwY iJFjB5zAdjqbDv763gVeFJpSbH7+MQw4dRYjNZQLFs5dQ1j31gMm3WwkIWp/cjyrwZ dDuJq6BjOpeSA== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id CD23D378000B; Thu, 14 Dec 2023 10:44:26 +0000 (UTC) Message-ID: Date: Thu, 14 Dec 2023 11:44:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: mediatek: mt8186: Add venc node Content-Language: en-US To: Eugen Hristev , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, Kyrie Wu , Allen-KH Cheng , Hsin-Yi Wang References: <20231213122017.102100-1-eugen.hristev@collabora.com> <20231213122017.102100-4-eugen.hristev@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20231213122017.102100-4-eugen.hristev@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_024429_186428_FC769783 X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 13/12/23 13:20, Eugen Hristev ha scritto: > From: Kyrie Wu > > Add video encoder node. > > Signed-off-by: Kyrie Wu > Signed-off-by: Allen-KH Cheng > Reviewed-by: Hsin-Yi Wang > [eugen.hristev@collabora.com: minor cleanup] > Signed-off-by: Eugen Hristev > --- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi > index 66ead3f23336..8535ff2b44e9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi > @@ -1993,6 +1993,30 @@ larb7: smi@17010000 { > power-domains = <&spm MT8186_POWER_DOMAIN_VENC>; > }; > > + venc: venc@17020000 { > + compatible = "mediatek,mt8183-vcodec-enc"; > + #address-cells = <2>; > + #size-cells = <2>; > + reg = <0 0x17020000 0 0x2000>; > + interrupts = ; > + iommus = <&iommu_mm IOMMU_PORT_L7_VENC_RCPU>, > + <&iommu_mm IOMMU_PORT_L7_VENC_REC>, > + <&iommu_mm IOMMU_PORT_L7_VENC_BSDMA>, > + <&iommu_mm IOMMU_PORT_L7_VENC_SV_COMV>, > + <&iommu_mm IOMMU_PORT_L7_VENC_RD_COMV>, > + <&iommu_mm IOMMU_PORT_L7_VENC_CUR_LUMA>, > + <&iommu_mm IOMMU_PORT_L7_VENC_CUR_CHROMA>, > + <&iommu_mm IOMMU_PORT_L7_VENC_REF_LUMA>, > + <&iommu_mm IOMMU_PORT_L7_VENC_REF_CHROMA>; > + dma-ranges = <0x1 0x0 0x1 0x0 0x1 0x0>; > + mediatek,scp = <&scp>; > + clocks = <&vencsys CLK_VENC_CKE1_VENC>; > + clock-names = "MT_CG_VENC"; clock-names = "venc"; (please no underscores and please lower case) > + assigned-clocks = <&topckgen CLK_TOP_VENC>; > + assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL_D3>; > + power-domains = <&spm MT8186_POWER_DOMAIN_VENC>; > + }; ....also: The following order of properties in device nodes is preferred: 1. "compatible" 2. "reg" 3. "ranges" 4. Standard/common properties (defined by common bindings, e.g. without vendor-prefixes) 5. Vendor-specific properties 6. "status" (if applicable) 7. Child nodes, where each node is preceded with a blank line Documentation/devicetree/bindings/dts-coding-style.rst Please reorder as per the DTS coding style document, and also please rename the venc node to use a generic name, such as "video-encoder@xxxx" Cheers, Angelo