From: Stanley Chu <stanley.chu@mediatek.com>
To: Miles Chen <miles.chen@mediatek.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bart Van Assche <bvanassche@acm.org>,
Martin Kepplinger <martink@posteo.de>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<wsd_upstream@mediatek.com>
Subject: Re: [PATCH] scsi: sd: fix crashes in sd_resume_runtime
Date: Fri, 15 Oct 2021 21:33:08 +0800 [thread overview]
Message-ID: <d656179616d61623e1c2b45c1df219c0693749a1.camel@mediatek.com> (raw)
In-Reply-To: <20211015074654.19615-1-miles.chen@mediatek.com>
Hi Miles,
On Fri, 2021-10-15 at 15:46 +0800, Miles Chen wrote:
> After merging commit ed4246d37f3b ("scsi: sd: REQUEST SENSE for
> BLIST_IGN_MEDIA_CHANGE devices in runtime_resume()"), I hit the
> following crash on my device.
>
> static int sd_resume_runtime(struct device *dev)
> {
> struct scsi_disk *sdkp = dev_get_drvdata(dev);
> struct scsi_device *sdp = sdkp->device; // sdkp == NULL and
> crash
>
> if (sdp->ignore_media_change) {
> ...
> }
>
> I checked sd_resume() and found that sdkp is possbile to be NULL, and
> there is a null pointer test in sd_resume() for this case.
> To fix this crash, follow sd_resume() to test if sdkp is NULL
> before dereferencing it.
LGTM.
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-10-15 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 7:46 [PATCH] scsi: sd: fix crashes in sd_resume_runtime Miles Chen
2021-10-15 7:55 ` Martin Kepplinger
2021-10-15 13:33 ` Stanley Chu [this message]
2021-10-15 17:54 ` Bart Van Assche
2021-10-15 20:11 ` miles.chen
2021-10-15 21:14 ` Bart Van Assche
2021-10-15 23:18 ` Miles Chen
2021-10-19 3:43 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d656179616d61623e1c2b45c1df219c0693749a1.camel@mediatek.com \
--to=stanley.chu@mediatek.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=martink@posteo.de \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox