Re: [PATCH v6 07/11] dt-bindings: usb: Support MediaTek MT8189 evb board xhci

Conor Dooley
2025-10-30T19:32:40Z

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

On Thu, Oct 30, 2025 at 09:44:39PM +0800, Jack Hsu wrote:
> modify dt-binding for support mt8189 evb board dts node of xhci
>
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> ---
> .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index 004d3ebec091..05cb6a219e5c 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -34,6 +34,7 @@ properties:
> - mediatek,mt8183-xhci
> - mediatek,mt8186-xhci
> - mediatek,mt8188-xhci
> + - mediatek,mt8189-xhci
> - mediatek,mt8192-xhci
> - mediatek,mt8195-xhci
> - mediatek,mt8365-xhci
> @@ -119,6 +120,9 @@ properties:
> resets:
> maxItems: 1
>
> + reset-names:
> + maxItems: 1

Is this reset required on mt8189? Does it appear on other mediatek xhci
controllers?

> +
> usb3-lpm-capable: true
>
> usb2-lpm-disable: true
> @@ -168,7 +172,8 @@ properties:
> 104 - used by mt8195, IP1, specific 1.04;
> 105 - used by mt8195, IP2, specific 1.05;
> 106 - used by mt8195, IP3, specific 1.06;
> - enum: [1, 2, 101, 102, 103, 104, 105, 106]
> + 110 - used by mt8189, IP4, specific 1.10;
> + enum: [1, 2, 101, 102, 103, 104, 105, 106, 110]
>
> mediatek,u3p-dis-msk:
> $ref: /schemas/types.yaml#/definitions/uint32
> --
> 2.45.2
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]