From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF81AEB64DA for ; Thu, 20 Jul 2023 11:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yTDYqoLVnrC2j+RmnA0HWXEdxr46fXdbmO0eDhf12+U=; b=np2iJpIUYJlmv/lpFw9RYtEn6i I8653hd6KsW/+KLwfrp6SNGdwPrdwGsG1q3JGX7yj8Nq6xWxSzSljKqQROAemdpRqp/5Pd/miqCo6 YhMIpecUCzRzA00hImckCYmXz0fIMNQZszfRwg4O3HbFHwVXIksb22z5UxtG3vuMyX64D3IadRzj6 XaGs+BhwnFcuNiJXAeIRFB1aHAAAIH1D8MGM/si1UBQnvAg8wzpExAT7uc5Fsps13X6R20mCaqNRE 0XK9rtq95/cwN2EUkZXDf65MM9iVBVGumDK0tjUtoK0ZgA7Ai7hiUHXSrfcIrJMFtUgG2bCbrcrCz mx2p419w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMSD8-00B2U7-2S; Thu, 20 Jul 2023 11:52:46 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMSD5-00B2Ry-1y; Thu, 20 Jul 2023 11:52:45 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 563926607083; Thu, 20 Jul 2023 12:52:38 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1689853959; bh=j6JBGmm4BC6EWYmzoUGSqSenhIca3LpJaT76xsHZwTE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Xt7dJTYXN55pPb9ezM3gpK0FtimTlDw7eTmN3DLYu08lxxv4dULmDgIaFCwqKpXvU fiG2EzYCp8fB+UTzq6z7slCqfMQf5u1p55ad1Aqvi4ExKDjm7dsgpaSa4dtFRoXkKT 9/xR7zKY3lu6JJltvecbzCjKZv/d1sYlAoC9ZTxbIYIKy6AX1kr5/rTwNR/kH6A9eH vyzAu2pTQQksxKIvYazhCByzBKnBAXZJwPJ0fj+ePBAaxZhoklRT+yAJqhyKb8+Lp0 aasAo/fJ/rtk4CH7TqyrftTCZTiNxTnVPQhyVIp7o3UWoESWUX9iUh+5qdr1DY3CNA sFFv0X/sG+5zA== Message-ID: Date: Thu, 20 Jul 2023 13:52:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/3] arm64: dts: mediatek: mt6795: Add support for display blocks and DPI/DSI Content-Language: en-US To: Alexandre Mergnat , matthias.bgg@gmail.com Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, kernel@collabora.com References: <20230720091559.86406-1-angelogioacchino.delregno@collabora.com> <20230720091559.86406-2-angelogioacchino.delregno@collabora.com> <0809ac02-b8bf-ed63-9e2e-e77cd7e93464@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <0809ac02-b8bf-ed63-9e2e-e77cd7e93464@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_045243_783939_E9CF6E87 X-CRM114-Status: GOOD ( 16.72 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 20/07/23 13:35, Alexandre Mergnat ha scritto: > > > On 20/07/2023 11:15, AngeloGioacchino Del Regno wrote: >> Introduce all nodes for all of the display blocks in the MediaTek Helio >> X10 MT6795 SoC, including the DSI PHY and DSI/DPI interfaces: those are >> left disabled as usage is board specific. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >>   arch/arm64/boot/dts/mediatek/mt6795.dtsi | 252 +++++++++++++++++++++++ >>   1 file changed, 252 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> b/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> index 597bce2fed72..d805d7a63024 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi >> @@ -2,6 +2,9 @@ >>   /* >>    * Copyright (c) 2015 MediaTek Inc. >>    * Author: Mars.C >> + * >> + * Copyright (C) 2023 Collabora Ltd. >> + *                    AngeloGioacchino Del Regno >> > > Shouldn't be like this ? > >  * Copyright (c) 2015 MediaTek Inc. >  * Copyright (C) 2023 Collabora Ltd. >  * Authors: Mars.C >  *          AngeloGioacchino Del Regno > > I don't think that there's any rule about this? Also I don't really mind the strings order, but if anyone really does, I can change it.... >>    */ >>   #include ... >> @@ -708,6 +953,13 @@ smi_common: smi@14022000 { >>               clock-names = "apb", "smi"; >>           }; >> +        od@14023000 { >> +            compatible = "mediatek,mt6795-disp-od", "mediatek,mt8173-disp-od"; >> +            reg = <0 0x14023000 0 0x1000>; >> +            clocks = <&mmsys CLK_MM_DISP_OD>; >> +            mediatek,gce-client-reg = <&gce SUBSYS_1402XXXX 0x3000 0x1000>; >> +        }; >> + >>           larb2: larb@15001000 { >>               compatible = "mediatek,mt6795-smi-larb"; >>               reg = <0 0x15001000 0 0x1000>; > > Reviewed-by: Alexandre Mergnat >