From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B531AC2D0DA for ; Wed, 25 Dec 2019 08:21:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 889942072A for ; Wed, 25 Dec 2019 08:21:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OgnTErtx"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Y/8W9RJ2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 889942072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GtismjyTiZrjy0lP0pgpRFdWTlrBlgNaMpo+MkIc6F4=; b=OgnTErtxA7VH+9EcwEU66GEFT 6XgmuZLnKkVoSnuHjvf54p0owPWu8I+/bI5rQKF0CJrlerbx+eyV1LTGoIDQeaprSlp9UQhGUHGVa mgDfi6+LyYS2OIHGgxtM13cw6fb438bxa8b2k4PqRp8hBhlwl2w5Gp15SiMLyLskxRecTwObHvGNp eM9nkwR2s68DpW/zcBtESz8OWc0oJ1cvprB/5SRgMXANGzOJhxZfkarJC/SF6YpgBfaotso6NNlUP AFRqDK2iFnLecb52+8vJG2boOlXgQ2esl/qAMvoTDyLciRlHdhWEzaSHRrOW2cwOJQxvD1mGFbfOD EakHMjIRA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ik1v9-0004b8-Vu; Wed, 25 Dec 2019 08:21:31 +0000 Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ik1v7-0004aH-1G for linux-mediatek@lists.infradead.org; Wed, 25 Dec 2019 08:21:30 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1577262087; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=K83HIkx3t93SDXJyO1FB5pObJwAm8xvbYEkqpHJP7VU=; b=Y/8W9RJ2C/a3gGCnpbdWY1D1RIfkFrDXBy5BmpeqjLv4fXn2xek5Kn+wXnekJGrTnmW0akwF gkTKYZLO9lcJN7DQ5Nzw3Vt0fRuCCcFEcc2NHM7NOcgwB7RXOauTAdVAk+t/ZF0AwtLzyqtd km0uEFNm/2GWk7IzSyh/AsSZcuA= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0ZDIyMyIsICJsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e031c06.7fdadd69fbc8-smtp-out-n02; Wed, 25 Dec 2019 08:21:26 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AC96DC433A2; Wed, 25 Dec 2019 08:21:25 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 09744C433CB; Wed, 25 Dec 2019 08:21:25 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 25 Dec 2019 16:21:25 +0800 From: Can Guo To: Stanley Chu Subject: Re: [PATCH v1 1/2] scsi: ufs: unify scsi_block_requests usage In-Reply-To: <1577192466-20762-2-git-send-email-stanley.chu@mediatek.com> References: <1577192466-20762-1-git-send-email-stanley.chu@mediatek.com> <1577192466-20762-2-git-send-email-stanley.chu@mediatek.com> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191225_002129_139932_873B32E9 X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, andy.teng@mediatek.com, jejb@linux.ibm.com, chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org, avri.altman@wdc.com, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, alim.akhtar@samsung.com, matthias.bgg@gmail.com, pedrom.sousa@synopsys.com, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 2019-12-24 21:01, Stanley Chu wrote: > Currently UFS driver has ufshcd_scsi_block_requests() with > reference counter mechanism to avoid possible racing of blocking and > unblocking requests flow. Unify all users in UFS driver to use the > same function. > > Signed-off-by: Stanley Chu > --- > drivers/scsi/ufs/ufshcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index ed02a70..b6b9665 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -5177,7 +5177,7 @@ static void > ufshcd_exception_event_handler(struct work_struct *work) > hba = container_of(work, struct ufs_hba, eeh_work); > > pm_runtime_get_sync(hba->dev); > - scsi_block_requests(hba->host); > + ufshcd_scsi_block_requests(hba); > err = ufshcd_get_ee_status(hba, &status); > if (err) { > dev_err(hba->dev, "%s: failed to get exception status %d\n", > @@ -5191,7 +5191,7 @@ static void > ufshcd_exception_event_handler(struct work_struct *work) > ufshcd_bkops_exception_event_handler(hba); > > out: > - scsi_unblock_requests(hba->host); > + ufshcd_scsi_unblock_requests(hba); > pm_runtime_put_sync(hba->dev); > return; > } Reviewed-by: Can Guo _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek