From: Bart Van Assche <bvanassche@acm.org>
To: Asutosh Das <asutoshd@codeaurora.org>
Cc: Peter Wang <peter.wang@mediatek.com>,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
linux-scsi@vger.kernel.org, wsd_upstream@mediatek.com,
linux-mediatek@lists.infradead.org, chun-hung.wu@mediatek.com,
alice.chao@mediatek.com, cc.chou@mediatek.com,
chaotian.jing@mediatek.com, jiajie.hao@mediatek.com,
powen.kao@mediatek.com, qilin.tan@mediatek.com,
lin.gui@mediatek.com, avri.altman@wdc.com,
alim.akhtar@samsung.com, jejb@linux.ibm.com
Subject: Re: [PATCH v1 0/2] ufs: allow vendor disable wb toggle in clock scaling
Date: Mon, 1 Aug 2022 09:43:31 -0700 [thread overview]
Message-ID: <dadc85ee-1252-38e8-a34f-3d1935f16b29@acm.org> (raw)
In-Reply-To: <ca760b93-e6e9-abea-f2b2-dbb0c592690b@mediatek.com>
On 8/1/22 07:30, Peter Wang wrote:
> Or, do you think we can direct remove ufshcd_wb_toggle in clock scaling
> and only let sysfs to control wb behavior?
I think it's worth asking the people who introduced this feature whether
it can be removed.
Hi Asutosh,
Commit 3d17b9b5ab11 ("scsi: ufs: Add write booster feature support")
introduced the following code in ufshcd_devfreq_scale():
+ /* Enable Write Booster if we have scaled up else disable it */
+ up_write(&hba->clk_scaling_lock);
+ ufshcd_wb_ctrl(hba, scale_up);
+ down_write(&hba->clk_scaling_lock);
Would you mind if the code for enabling/disabling the WriteBooster is
removed again from ufshcd_devfreq_scale() and that a new mechanism is
introduced for controlling the WriteBooster mechanism?
Thanks,
Bart.
next prev parent reply other threads:[~2022-08-01 16:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 7:16 [PATCH v1 0/2] ufs: allow vendor disable wb toggle in clock scaling peter.wang
2022-07-28 7:16 ` [PATCH v1 1/2] ufs: core: interduce a choice of " peter.wang
2022-07-28 21:41 ` Bean Huo
2022-08-01 14:31 ` Peter Wang
2022-07-28 7:16 ` [PATCH v1 2/2] ufs: host: support wb toggle with " peter.wang
2022-07-28 21:57 ` Bean Huo
2022-08-01 14:32 ` Peter Wang
2022-07-28 20:43 ` [PATCH v1 0/2] ufs: allow vendor disable wb toggle in " Avri Altman
2022-08-01 14:28 ` Peter Wang
2022-07-28 21:09 ` Bart Van Assche
2022-07-28 21:26 ` Bean Huo
2022-08-01 2:11 ` Stanley Chu
2022-08-01 14:30 ` Peter Wang
2022-08-01 16:43 ` Bart Van Assche [this message]
2022-08-01 17:58 ` Asutosh Das (asd)
2022-08-01 17:57 ` Christoph Hellwig
2022-08-01 18:12 ` Bart Van Assche
2022-08-01 18:14 ` Christoph Hellwig
2022-08-02 3:25 ` Peter Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dadc85ee-1252-38e8-a34f-3d1935f16b29@acm.org \
--to=bvanassche@acm.org \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).