From: Alexandre Mergnat <amergnat@baylibre.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
jic23@kernel.org
Cc: lars@metafoo.de, matthias.bgg@gmail.com, ruanjinjie@huawei.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, wenst@chromium.org,
kernel@collabora.com
Subject: Re: [PATCH] iio: adc: mt6577_auxadc: Fix kernel panic on suspend
Date: Tue, 10 Oct 2023 14:34:36 +0200 [thread overview]
Message-ID: <dc50d8ec-b43a-4beb-9fdf-773b0ee30d0c@baylibre.com> (raw)
In-Reply-To: <20231010121940.159696-1-angelogioacchino.delregno@collabora.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
On 10/10/2023 14:19, AngeloGioacchino Del Regno wrote:
> Commit a2d518fbe376 ("iio: adc: mt6577_auxadc: Simplify with device
> managed function") simplified the driver with devm hooks, but wrongly
> states that the platform_set_drvdata(), platform_get_drvdata() are
> unused after the simplification: the driver data is infact used in
> .suspend() and .resume() PM callbacks, currently producing a kernel
> panic. Reintroduce the call to platform_set_drvdata() in the probe function
--
Regards,
Alexandre
next prev parent reply other threads:[~2023-10-10 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 12:19 [PATCH] iio: adc: mt6577_auxadc: Fix kernel panic on suspend AngeloGioacchino Del Regno
2023-10-10 12:34 ` Alexandre Mergnat [this message]
2023-10-10 12:44 ` Markus Schneider-Pargmann
2023-10-10 15:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc50d8ec-b43a-4beb-9fdf-773b0ee30d0c@baylibre.com \
--to=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox