Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "dan.carpenter@linaro.org" <dan.carpenter@linaro.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [bug report] scsi: ufs: host: mediatek: Set IRQ affinity policy for MCQ mode
Date: Mon, 4 Aug 2025 05:59:17 +0000	[thread overview]
Message-ID: <ddccb7332dbd4eea22e12f00e35d84f8183a16ff.camel@mediatek.com> (raw)
In-Reply-To: <aIy-t8rS0b8vhfmL@stanley.mountain>

On Fri, 2025-08-01 at 16:18 +0300, Dan Carpenter wrote:
> 
> 
>     821         if (q_index > nr) {
> 
> This really looks like it should be ">= nr" instead of "> nr" but I'm
> not
> certain enough to send a patch for it.  Could you take a look?
> 
>     822                 dev_err(hba->dev, "hwq index %d exceed %d\n",
>     823                         q_index, nr);
>     824                 return MTK_MCQ_INVALID_IRQ;
>     825         }
>     826
> --> 827         return host->mcq_intr_info[q_index].irq;
>     828 }
> 
> regards,
> dan carpenter

Hi Dan,

Yes, this is indeed a coding defect that needs to be fixed.
I will correct it.

Thanks.
Peter


      reply	other threads:[~2025-08-04  5:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01 13:18 [bug report] scsi: ufs: host: mediatek: Set IRQ affinity policy for MCQ mode Dan Carpenter
2025-08-04  5:59 ` Peter Wang (王信友) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddccb7332dbd4eea22e12f00e35d84f8183a16ff.camel@mediatek.com \
    --to=peter.wang@mediatek.com \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox