From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 155DECA0ED1 for ; Mon, 11 Aug 2025 18:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qaouqb4fO7JIvY1JD8PEt300KWG5mGmc4W0R7yQs6hc=; b=Nz3KPUXGTvBx8I/6wIFLlayGa0 RzlrCd46DuCpzBNShThVHUEz/JyyLnpXRS1NVPPrE1+ekuwjd+BGJkCpdvAszNARd2O6q2jXT+hnu TxaxMX02S6PDeAjPa0SRQURQ6Sgb5KknS6akD/J6vr9nWeOPFreQxBZS/dL1xI20/unxJ9oog9B0c 9OvdZ9To34hiBlmsXEG38mCE0M+7JAKgA6AuVio8cX7TOYhQy0mkGBGtbKFyI1/RIf89aZ5WLBKBn gT73HPycA1EK1vq8ELIZm94JW8v5pQge/G4n1vYRw8nBlUzmFmh/QalQSE4h1932EmK8+Nbi7hYwK 7bfl+vEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulXat-00000008q0u-06LM; Mon, 11 Aug 2025 18:50:03 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulUyt-00000008Jse-2dQF; Mon, 11 Aug 2025 16:02:40 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-af968aa2de4so828781066b.1; Mon, 11 Aug 2025 09:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754928158; x=1755532958; darn=lists.infradead.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qaouqb4fO7JIvY1JD8PEt300KWG5mGmc4W0R7yQs6hc=; b=MRD+DvCLJeP7fttyDIkWPyFOCIZUsFlC//ZDhsbeiNttD2elISlYR5LRwFdNJQbcoD hVywrSUFrRDxLIaDmxpU2auP6rYKYaPO7ilOVlzpU3LqDXzVQVxhD/C70qsDMtO/g1ve lQIhtd7z1YApqB9/bIfo55WcTm49GKC/FeMhihCZ3mDB15PFOT2j2hi4wYgUtO/bdv3M loELjujrambdmGfgy/3MzQlBm6A6CM7438KCkf/h8KReFzV3bldl79CQTKSJu2H6Qucn QBKk6HaDhXv4pL3hHGgq+6vPKn3bYumhrGr/YV9Afl2AOw9p7k0BwKA5j/O78CDezxzo y/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754928158; x=1755532958; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qaouqb4fO7JIvY1JD8PEt300KWG5mGmc4W0R7yQs6hc=; b=hBPenEdyakpdAvCI1Dua8mwu6m8vQH5VM1n6tSTdCYiCVfHboCIjkGvq35l2mIKg7q ug6Y1oF3639X4a3LKbcHaVHfcJYqQ6aXeC17EadGzcJjUDQcEnAuZRPhGfUWoDkHKwLI ik0XMY3bhCC+pUF6Nz6xZEz98Mst4MI5CJY/bQtAccsy12RYP6sQz0exsrgJXMHiTzxY UOhMYfsN5JXOhSSAgjUiqQ4vmKmiY+OhR3EXpFy+mZlxuqAKA6VcppJdlcBHf2OP2ncg wN7DBVcX/E3lnYcQVsHyOg67yZ5c3mC/P2BszRGFM2zb1JmoLnDnz8eFu82QMqHbgR3u 9/mQ== X-Forwarded-Encrypted: i=1; AJvYcCULw0AlEdxPPrsKDoxVpNJy4kB9FV7VNhk5KOyujky3LaGb6bAHBZghFBghqaFKi57j2NlSq03WbSGyUkPc@lists.infradead.org, AJvYcCW9WIY0Jy93RuCfqQIaAlTnpLLSFadVnSTHAaiPT9mxA+89QCt0wfDvfo95BuqJNZ7qR6RcybIZNP8jyWsHJ1s=@lists.infradead.org, AJvYcCWtt9kGRYg3J0jcLGHrIAD4M+kvHBRnSTOTbabKdYYS1iyj75TfP4sGj83O1FYWWM9eftJlKhiC1MI8mgU=@lists.infradead.org, AJvYcCXG29dXMt1R5FtaG4x7uZKYlfut3J4CaU7nvGHY8T7HPe/rBF5xDcY4rDxw1TXkshdtmJBEt69HmwcTLf19Ra23/Q==@lists.infradead.org, AJvYcCXbBAFQvRSmuaOsiLezhhM/35x0oF1bmUonST61kSNCL/BypNaFMGET8QZgZJ/GUUdnDFi9ogLjPM1aEGJFwjU=@lists.infradead.org X-Gm-Message-State: AOJu0Yw3h+htgDW4kL7AocdHOw8YkX37OenmCo98OcwXU7vzNVO6ZLgA i9EY8IvjHcKH1sCy+4mfRLO+O8XtstITKaFr/0/YRNhqVhNC/ogQCqMX X-Gm-Gg: ASbGnctdPFoy/PSfJmAwccU0PMt9/5aLGtW+HRt0Qokcgf/Q9kHdT61nw37zxiKEcxf cX6mmcppLpMPsQve5EdUcaUiMEuovEFH1VKUQS3od7iYsVhblScTXzb50TbKQ6lNvRfHmJr9zB5 zXUHP+A3g0KQ1h4Nj7eTjs4mkZ/iiy9nGVBSGf8mT7W/nvlHxBby3Dty9LQDXUYYetKBBG8xzMu nG2TqNrzmV3o8/3wXdUEgOOGzecrUEhe8hA1jFGaJlkpjKWBVQVog9yzEen/EYAbQ3sCS6WH+g7 Ui2KcbKs5mFKMSGgKmsATrMeAaB5Au8dq9BEjaLc1pVY1k1remyJU9mvdftz/sOqGTwGMi6c3rz CUVN4KFFAURJOsG1i+K4MxmzwY+RCM9ZsnJ3acWY= X-Google-Smtp-Source: AGHT+IFlPGC8RqUZcNmE1sb0v/JytUS2YpnMYnX0fy/68mQiQooD3eH6nJnAu7hadMRuF3cZL/qgqg== X-Received: by 2002:a17:907:7f1a:b0:ae0:d78a:2366 with SMTP id a640c23a62f3a-af9c63b0a5bmr1282562266b.4.1754928157418; Mon, 11 Aug 2025 09:02:37 -0700 (PDT) Received: from giga-mm.home ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a1e6cecsm2050387666b.70.2025.08.11.09.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 09:02:36 -0700 (PDT) Message-ID: Subject: Re: [PATCH 111/114] clk: divider: remove round_rate() in favor of determine_rate() From: Alexander Sverdlin To: bmasney@redhat.com, Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?ISO-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Date: Mon, 11 Aug 2025 18:02:33 +0200 In-Reply-To: <20250811-clk-for-stephen-round-rate-v1-111-b3bf97b038dc@redhat.com> References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-111-b3bf97b038dc@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250811_090239_667631_FF55D88F X-CRM114-Status: GOOD ( 17.78 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2025-08-11 at 11:19 -0400, Brian Masney via B4 Relay wrote: > From: Brian Masney >=20 > This driver implements both the determine_rate() and round_rate() clk > ops, and the round_rate() clk ops is deprecated. When both are defined, > clk_core_determine_round_nolock() from the clk core will only use the > determine_rate() clk ops. Also all clk drivers that directly calls > divider's round_rate() have been migrated over to determine_rate(). So > let's remove the round_rate() clk ops. >=20 > Signed-off-by: Brian Masney Reviewed-by: Alexander Sverdlin > --- > =C2=A0drivers/clk/clk-divider.c | 23 ----------------------- > =C2=A01 file changed, 23 deletions(-) >=20 > diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c > index c1f426b8a5043cb5a1de08e1da385928ec54a2ed..2601b6155afb7391c6a0ffb91= c58fa66cde98197 100644 > --- a/drivers/clk/clk-divider.c > +++ b/drivers/clk/clk-divider.c > @@ -431,27 +431,6 @@ long divider_ro_round_rate_parent(struct clk_hw *hw,= struct clk_hw *parent, > =C2=A0} > =C2=A0EXPORT_SYMBOL_GPL(divider_ro_round_rate_parent); > =C2=A0 > -static long clk_divider_round_rate(struct clk_hw *hw, unsigned long rate= , > - unsigned long *prate) > -{ > - struct clk_divider *divider =3D to_clk_divider(hw); > - > - /* if read only, just return current value */ > - if (divider->flags & CLK_DIVIDER_READ_ONLY) { > - u32 val; > - > - val =3D clk_div_readl(divider) >> divider->shift; > - val &=3D clk_div_mask(divider->width); > - > - return divider_ro_round_rate(hw, rate, prate, divider->table, > - =C2=A0=C2=A0=C2=A0=C2=A0 divider->width, divider->flags, > - =C2=A0=C2=A0=C2=A0=C2=A0 val); > - } > - > - return divider_round_rate(hw, rate, prate, divider->table, > - =C2=A0 divider->width, divider->flags); > -} > - > =C2=A0static int clk_divider_determine_rate(struct clk_hw *hw, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct clk_rate_request *req) > =C2=A0{ > @@ -527,7 +506,6 @@ static int clk_divider_set_rate(struct clk_hw *hw, un= signed long rate, > =C2=A0 > =C2=A0const struct clk_ops clk_divider_ops =3D { > =C2=A0 .recalc_rate =3D clk_divider_recalc_rate, > - .round_rate =3D clk_divider_round_rate, > =C2=A0 .determine_rate =3D clk_divider_determine_rate, > =C2=A0 .set_rate =3D clk_divider_set_rate, > =C2=A0}; > @@ -535,7 +513,6 @@ EXPORT_SYMBOL_GPL(clk_divider_ops); > =C2=A0 > =C2=A0const struct clk_ops clk_divider_ro_ops =3D { > =C2=A0 .recalc_rate =3D clk_divider_recalc_rate, > - .round_rate =3D clk_divider_round_rate, > =C2=A0 .determine_rate =3D clk_divider_determine_rate, > =C2=A0}; > =C2=A0EXPORT_SYMBOL_GPL(clk_divider_ro_ops); --=20 Alexander Sverdlin.