public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: "Bernhard Rosenkränzer" <bero@baylibre.com>, devicetree@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	krzysztof.kozlowski@linaro.org, khilman@baylibre.com,
	mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com
Subject: Re: [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered
Date: Mon, 21 Nov 2022 13:33:44 +0100	[thread overview]
Message-ID: <e0a35381-0ef3-c134-e1ef-b073a28458c9@gmail.com> (raw)
In-Reply-To: <20221121015451.2471196-2-bero@baylibre.com>



On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Remove the check for the unnecessary pins-are-numbered Devicetree property.
> 
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 076ae0b38e3d7..553d16703475b 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -1057,7 +1057,6 @@ int mtk_pctrl_init(struct platform_device *pdev,
>   	struct pinctrl_pin_desc *pins;
>   	struct mtk_pinctrl *pctl;
>   	struct device_node *np = pdev->dev.of_node, *node;
> -	struct property *prop;
>   	int ret, i;
>   
>   	pctl = devm_kzalloc(&pdev->dev, sizeof(*pctl), GFP_KERNEL);
> @@ -1066,11 +1065,6 @@ int mtk_pctrl_init(struct platform_device *pdev,
>   
>   	platform_set_drvdata(pdev, pctl);
>   
> -	prop = of_find_property(np, "pins-are-numbered", NULL);
> -	if (!prop)
> -		return dev_err_probe(dev, -EINVAL,
> -				     "only support pins-are-numbered format\n");
> -
>   	node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
>   	if (node) {
>   		pctl->regmap1 = syscon_node_to_regmap(node);


  parent reply	other threads:[~2022-11-21 12:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21  1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
2022-11-21  1:54 ` [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered Bernhard Rosenkränzer
2022-11-21  9:00   ` AngeloGioacchino Del Regno
2022-11-21 12:33   ` Matthias Brugger [this message]
2022-11-21 12:35   ` Krzysztof Kozlowski
2022-11-21 18:20   ` Kevin Hilman
2022-11-21  1:54 ` [PATCH 2/9] pinctrl: stm32: " Bernhard Rosenkränzer
2022-11-21 12:34   ` Matthias Brugger
2022-11-21 12:35   ` Krzysztof Kozlowski
2022-11-21  1:54 ` [PATCH 3/9] dt-bindings: pinctrl: mediatek,mt65xx: Make pins-are-numbered optional Bernhard Rosenkränzer
2022-11-21  8:00   ` Krzysztof Kozlowski
2022-11-21 12:32     ` Matthias Brugger
2022-11-21 12:36       ` Matthias Brugger
2022-11-21  1:54 ` [PATCH 4/9] dt-bindings: pinctrl: st,stm32: Don't list pins-are-numbered as required Bernhard Rosenkränzer
2022-11-21  1:54 ` [PATCH 5/9] arm64: dts: mediatek: Remove pins-are-numbered property Bernhard Rosenkränzer
2022-11-21  9:00   ` AngeloGioacchino Del Regno
2022-11-21 18:21   ` Kevin Hilman
2022-11-21  1:54 ` [PATCH 6/9] ARM: " Bernhard Rosenkränzer
2022-11-21  9:00   ` AngeloGioacchino Del Regno
2022-11-21 18:21   ` Kevin Hilman
2022-11-21  1:54 ` [PATCH 7/9] ARM: dts: stm32: Remove the " Bernhard Rosenkränzer
2022-11-21  1:54 ` [PATCH 8/9] dt-bindings: pinctrl: mediatek,mt65xx: Drop " Bernhard Rosenkränzer
2022-11-21 12:36   ` Krzysztof Kozlowski
2022-11-21  1:54 ` [PATCH 9/9] dt-bindings: pinctrl: st,stm32: Remove " Bernhard Rosenkränzer
2022-11-21 12:31 ` [PATCH 0/9] Remove the pins-are-numbered DT property Matthias Brugger
2022-11-21 12:37   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0a35381-0ef3-c134-e1ef-b073a28458c9@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=bero@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox