From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30F87ECAAD8 for ; Fri, 23 Sep 2022 09:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P6TlqT22EcPKwVhF1BHpRWPHqFWUaO5gYCaz5aDtGTs=; b=YOrqY0+oBTZEsQFhpTZYBnGEIm ZTjhufmCQBqD8zEAI3I+YGH+BnQc/IIEbOa7uO0yM0ETOKVT5k8xJUCRgajbEqdC0o+Vl2nNa8K04 O3aIDNGSn3ssv+nH8plpDB5WFImzcgNKGLkp1wY2Sd+FIiI5gUVHesOR9LLpGcQiInyTUScxHTP0R +zcS46MouLQ7/RTaDr2EdYHLXKo4JRIxM3UFIgZzNCy8PyRnv6q5fMiFcHzB2ivuv91uT/3FtVtfD aCXR8usiCQLTudo2lV/e6bfVVKi+FZZpEJd4uBeMBXzwazMmKV/z9T0VSiUqSr7+6uxpVuIafp4ef A3WqGCvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obeiE-003CLf-1i; Fri, 23 Sep 2022 09:11:10 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obehy-003CEy-0G; Fri, 23 Sep 2022 09:10:55 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 64B1C6602038; Fri, 23 Sep 2022 10:10:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663924252; bh=5dQSl61o3/d45Zc6JtCNy5byEWYtp/sXtn/FPR8mee0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TcjIIpAmezqk2QInoHN7/joAu1zk07/Kfi7cH9ft9WKzxDKDSNEldxLKkANAX6gGy HAeHai4DWD0fqncMVAK1e3wiBRq2xtkmBGERLqjeGmOyFFn2TisGGgqCCuIFpLJRDu 1i62xgUq8U/9aDBXM4sYqRWTb+smoi/nXRFqVTZmNgaD4Ra1969DyhAckqLVWb9Uvj 3MRMA/JRsEEwGP6M0saTXuzRpkbM6g91Q37wHAtjLF+eAgMp2blQalZvvPRWvO8/Cw Bs+WK5Lq5/QhU4m4l8Kzj191h86d8vUG/fGPYsFnq20sxUB+XG/NAzs7whejtpteYg 3QH9MNcbetMIg== Message-ID: Date: Fri, 23 Sep 2022 11:10:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v5 4/4] net: stmmac: Update the name of property 'clk_csr' Content-Language: en-US To: Jianguo Zhang , "David S . Miller" , Rob Herring , Krzysztof Kozlowski Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Matthias Brugger , Biao Huang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220923052828.16581-1-jianguo.zhang@mediatek.com> <20220923052828.16581-5-jianguo.zhang@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220923052828.16581-5-jianguo.zhang@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220923_021054_219836_A83480B5 X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 23/09/22 07:28, Jianguo Zhang ha scritto: > Update the name of property 'clk_csr' as 'snps,clk-csr' to align with > the property name in the binding file. > > Signed-off-by: Jianguo Zhang > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 9f5cac4000da..18f9952d667f 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -444,7 +444,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) > * or get clk_csr from device tree. > */ > plat->clk_csr = -1; > - of_property_read_u32(np, "clk_csr", &plat->clk_csr); > + of_property_read_u32(np, "snps,clk-csr", &plat->clk_csr); This is going to break MT2712e on old devicetrees. The right way of doing that is to check the return value of of_property_read_u32() for "snps,clk-csr": if the property is not found, fall back to the old "clk_csr". Regards, Angelo > > /* "snps,phy-addr" is not a standard property. Mark it as deprecated > * and warn of its use. Remove this when phy node support is added.