From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Subject: Re: [PATCH v7 6/6] mailbox: Add support for i.MX7D messaging unit Date: Thu, 26 Jul 2018 13:42:27 +0200 Message-ID: References: <20180726065331.6186-1-o.rempel@pengutronix.de> <20180726065331.6186-7-o.rempel@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6005279572962109607==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jassi Brar Cc: Mark Rutland , "A.s. Dong" , Devicetree List , Rob Herring , ", linux-arm-kernel"@lists.infradead.org, Vladimir Zapolskiy , ", Sascha Hauer" , Fabio Estevam , srv_heupstream , Shawn Guo , srv_heupstream , dl-linux-imx List-Id: linux-mediatek@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6005279572962109607== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oFXFHtH6ZXj9lCmUePKXnIJdUdPR4oSio" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oFXFHtH6ZXj9lCmUePKXnIJdUdPR4oSio Content-Type: multipart/mixed; boundary="LtgkWXEkcUDgB04YeQjvQ1Zd9ZqdHb3jq"; protected-headers="v1" From: Oleksij Rempel To: Jassi Brar Cc: Mark Rutland , "A.s. Dong" , Devicetree List , Rob Herring , ", linux-arm-kernel"@lists.infradead.org, ", linux-arm-kernel"@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream , srv_heupstream , ", Sascha Hauer" , Fabio Estevam , Shawn Guo , Vladimir Zapolskiy , dl-linux-imx Message-ID: Subject: Re: [PATCH v7 6/6] mailbox: Add support for i.MX7D messaging unit References: <20180726065331.6186-1-o.rempel@pengutronix.de> <20180726065331.6186-7-o.rempel@pengutronix.de> In-Reply-To: --LtgkWXEkcUDgB04YeQjvQ1Zd9ZqdHb3jq Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 26.07.2018 13:09, Jassi Brar wrote: > On Thu, Jul 26, 2018 at 4:21 PM, Oleksij Rempel wrote: >=20 >>> >>>> +struct imx_mu_con_priv { >>>> + int irq; >>>> + unsigned int idx; >>>> + char *irq_desc; >>>> >>> Having char irq_desc[16]; seems simpler than free/kfree upon= >>> each startup/shutdown. Simply use snprintf() in probe(). >> >> Currently all known configurations use one or two channels. I don't se= e >> any sense to allocate all at the probe. >> > Just because only 2 out of 4 channels are being used, it doesn't make s= ense? >=20 > What is the concern? "wasting" 16x2 bytes of memory? How many bytes, > LOC and execution time does kasprintf() waste? Startup or shutdown is not speed critical path in this driver, or do i miss some thing? Speed vs size is not valid argumentation here. --LtgkWXEkcUDgB04YeQjvQ1Zd9ZqdHb3jq-- --oFXFHtH6ZXj9lCmUePKXnIJdUdPR4oSio Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEpENFL0P3hvQ7p0DDdQOiSHVI77QFAltZs6MACgkQdQOiSHVI 77Rtfgf/fSqT7JxQB3Hck/vywVzUZPWRlhcxKecZ7WVcMXEX26Xn2t67WBvHPt9c /ZpP6MQ9avjHeAk5s6AKa618/vSc3xj3L03bUVK+xvBECKrE7wh4F/93d88fT4iH wZpBrDapj7lyO5JLSH14Q6SDAaSaXvaRRs9JgrgzKFxD+kyPeFNWdzGl5n2d5JQm Nuo6S4o21RQKt9gkC6OlzHTqvDlB+/3pFFysfnku1tUwYPfQwKxOmrMC6FzJlohA oNpgWpuGNa+QklQV1emnRhC2oiwgnKLbJPYIyqns0KBBIjcNyjBC/pdTEtD2NSZI kviiyyPy9WCqndnyGUUn976hXrP9GQ== =GO8o -----END PGP SIGNATURE----- --oFXFHtH6ZXj9lCmUePKXnIJdUdPR4oSio-- --===============6005279572962109607== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6005279572962109607==--