From: Can Guo <cang@codeaurora.org>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: jiajie.hao@mediatek.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, huadian.liu@mediatek.com,
andy.teng@mediatek.com, jejb@linux.ibm.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, cc.chou@mediatek.com,
avri.altman@wdc.com, alice.chao@mediatek.com,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
alim.akhtar@samsung.com, matthias.bgg@gmail.com,
asutoshd@codeaurora.org, chaotian.jing@mediatek.com,
bvanassche@acm.org, linux-arm-kernel@lists.infradead.org,
beanhuo@micron.com
Subject: Re: [PATCH v1 1/3] scsi: ufs: Add error history for abort event in UFS Device W-LUN
Date: Thu, 03 Dec 2020 13:33:32 +0800 [thread overview]
Message-ID: <e22b55de9d0b0dd26b26b1425180592c@codeaurora.org> (raw)
In-Reply-To: <20201126053839.25889-2-stanley.chu@mediatek.com>
On 2020-11-26 13:38, Stanley Chu wrote:
> Add error history for abort event in UFS Device W-LUN.
> Besides, use specified value as parameter of ufshcd_update_reg_hist()
> to identify the aborted tag or LUNs.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 0e5473d4699b..28e4def13f21 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6742,8 +6742,10 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
> * To avoid these unnecessary/illegal step we skip to the last error
> * handling stage: reset and restore.
> */
> - if (lrbp->lun == UFS_UPIU_UFS_DEVICE_WLUN)
> + if (lrbp->lun == UFS_UPIU_UFS_DEVICE_WLUN) {
> + ufshcd_update_reg_hist(&hba->ufs_stats.task_abort, lrbp->lun);
> return ufshcd_eh_host_reset_handler(cmd);
> + }
>
> ufshcd_hold(hba, false);
> reg = ufshcd_readl(hba, REG_UTP_TRANSFER_REQ_DOOR_BELL);
> @@ -6767,7 +6769,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
> */
> scsi_print_command(hba->lrb[tag].cmd);
> if (!hba->req_abort_count) {
> - ufshcd_update_reg_hist(&hba->ufs_stats.task_abort, 0);
> + ufshcd_update_reg_hist(&hba->ufs_stats.task_abort, tag);
> ufshcd_print_host_regs(hba);
> ufshcd_print_host_state(hba);
> ufshcd_print_pwr_info(hba);
Reviewed-by: Can Guo <cang@codeaurora.org>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-12-03 5:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 5:38 [PATCH v1 0/3] Refine error history and introduce notify_event vop Stanley Chu
2020-11-26 5:38 ` [PATCH v1 1/3] scsi: ufs: Add error history for abort event in UFS Device W-LUN Stanley Chu
2020-12-03 5:33 ` Can Guo [this message]
2020-11-26 5:38 ` [PATCH v1 2/3] scsi: ufs: Refine error history functions Stanley Chu
2020-12-03 5:46 ` Can Guo
2020-11-26 5:38 ` [PATCH v1 3/3] scsi: ufs: Introduce notify_event variant function Stanley Chu
2020-12-03 5:49 ` Can Guo
2020-12-05 2:45 ` [PATCH v1 0/3] Refine error history and introduce notify_event vop Asutosh Das (asd)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e22b55de9d0b0dd26b26b1425180592c@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=huadian.liu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).