From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50A68C55162 for ; Thu, 30 Jul 2026 16:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U8MQ+sboj6Emxgip/vMO33V3JD1l2EBPOqtHqVRFw3I=; b=orU8AQRXdS3tegZjtyIKoF70CS /6a4Ss9T/NL6V9YDima6mb0uDbmKQ7aM+uSpdLPyg/dJmgGbaBDxR7O847e03rRrgRMgcEwGZcvbW am4osTuYqIc8H4JT21IX+8zJbTZsU4r+IkqB22bBmEzO9vY6540UMjf/s+xPMv7Hbf5hxFnJDWe9w Jg/XZOI4qXUuPSUosvdq6q0nOCZZnreE0NN24TYX1MzNMeDi9Jg+tz8zhYw/TLJpd0Vwx5jOUZf9x /gn/oyM7C3ojgNbZO8TyfdHJCKSMK0dWWIj80utjqmflovZhHeM/jZ+xGPLncnbl2g+PACeSXXbXV WhRY/4iQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpTOE-0000000AxPS-0Liv; Thu, 30 Jul 2026 16:13:46 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpTOB-0000000AxO2-46kt; Thu, 30 Jul 2026 16:13:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=U8MQ+sboj6Emxgip/vMO33V3JD1l2EBPOqtHqVRFw3I=; b=QJHbkG9inB4HeB0zhPf1Ecu+Jd PDG/oyKlbHHjqGSmdYTafJnH93wJVo47oZ4UcPWG1nshVtZbn1+iGB/krH9MxR5Vt8ty4rvEjUneS o4x4KUf9tAEAvjtZVhgHcnRDYAyZTyOPenqKYB8uxIPn16mpoIYXIJxcjhoHt1W5Q3jo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wpTNh-00F29y-48; Thu, 30 Jul 2026 18:13:13 +0200 Date: Thu, 30 Jul 2026 18:13:13 +0200 From: Andrew Lunn To: Daniel Golle Cc: "Chester A. Unal" , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Alexander Couzens , Heiner Kallweit , Russell King , Russell King , Landen Chao , Florian Fainelli , Sean Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net 1/4] net: pcs: mtk-lynxi: check regmap reads in mtk_pcs_lynxi_get_state() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260730_091344_015366_35EFFA15 X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jul 30, 2026 at 05:03:11PM +0100, Daniel Golle wrote: > mtk_pcs_lynxi_get_state() ignores regmap_read()'s return value; a > failed read leaves bm and adv holding uninitialized stack values > which are then decoded into the reported link state. The regmaps > backing the MT7531 SGMII PCS instances sit on an MDIO bus where > reads can fail. Check both reads and leave the state untouched on > error. > > Fixes: 4765a9722e09 ("net: pcs: add driver for MediaTek SGMII PCS") > Signed-off-by: Daniel Golle Reviewed-by: Andrew Lunn Andrew