Re: [PATCH v2 00/15] drm/drm_simple: remove drm_simple_encoder_init

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi

Am 20.07.26 um 17:40 schrieb Diogo Silva:
> The simple KMS helpers are deprecated because they only add an
> intermediate layer between drivers and atomic modesetting.
>
> This series open-codes all remaining drm_simple_encoder_init() users by
> calling drm_encoder_init() directly and providing driver-local
> drm_encoder_funcs where needed. After the driver conversions, the helper
> is removed and the completed DRM todo item is dropped.
>
> Signed-off-by: Diogo Silva <diogompaissilva@gmail.com>

For the whole series:

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Diogo, do you want to send out another revision? Otherwise it's time to 
get these patches merged.

Best regards
Thomas



> ---
> Changes in v2:
> - Change logging to consistently use drm_err()
> - Link to v1: https://patch.msgid.link/20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com
>
> To: Jingoo Han <jingoohan1@gmail.com>
> To: Inki Dae <inki.dae@samsung.com>
> To: Seung-Woo Kim <sw0312.kim@samsung.com>
> To: Kyungmin Park <kyungmin.park@samsung.com>
> To: David Airlie <airlied@gmail.com>
> To: Simona Vetter <simona@ffwll.ch>
> To: Krzysztof Kozlowski <krzk@kernel.org>
> To: Peter Griffin <peter.griffin@linaro.org>
> To: Alim Akhtar <alim.akhtar@samsung.com>
> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> To: Maxime Ripard <mripard@kernel.org>
> To: Thomas Zimmermann <tzimmermann@suse.de>
> To: Michal Simek <michal.simek@amd.com>
> To: Thierry Reding <thierry.reding@kernel.org>
> To: Mikko Perttunen <mperttunen@nvidia.com>
> To: Jonathan Hunter <jonathanh@nvidia.com>
> To: Stefan Agner <stefan@agner.ch>
> To: Alison Wang <alison.wang@nxp.com>
> To: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
> To: David Airlie <airlied@redhat.com>
> To: Gerd Hoffmann <kraxel@redhat.com>
> To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> To: Gurchetan Singh <gurchetansingh@chromium.org>
> To: Chia-I Wu <olvaffe@gmail.com>
> To: Jyri Sarha <jyri.sarha@iki.fi>
> To: Liu Ying <victor.liu@nxp.com>
> To: Frank Li <Frank.Li@nxp.com>
> To: Sascha Hauer <s.hauer@pengutronix.de>
> To: Pengutronix Kernel Team <kernel@pengutronix.de>
> To: Fabio Estevam <festevam@gmail.com>
> To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> To: Philipp Zabel <p.zabel@pengutronix.de>
> To: Matthias Brugger <matthias.bgg@gmail.com>
> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> To: Geert Uytterhoeven <geert+renesas@glider.be>
> To: Xinliang Liu <xinliang.liu@linaro.org>
> To: Sumit Semwal <sumit.semwal@linaro.org>
> To: Yongqin Liu <yongqin.liu@linaro.org>
> To: John Stultz <jstultz@google.com>
> To: Liviu Dudau <liviu.dudau@arm.com>
> To: Neil Armstrong <neil.armstrong@linaro.org>
> To: Kevin Hilman <khilman@baylibre.com>
> To: Jerome Brunet <jbrunet@baylibre.com>
> To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> To: Jonathan Corbet <corbet@lwn.net>
> To: Shuah Khan <skhan@linuxfoundation.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Cc: virtualization@lists.linux.dev
> Cc: imx@lists.linux.dev
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-doc@vger.kernel.org
>
> ---
> Diogo Silva (15):
>        drm/exynos: remove dependency on DRM simple helpers
>        drm/xlnx/zynqmp_dpsub: remove dependency on DRM simple helpers
>        drm/tegra: remove dependency on DRM simple helpers
>        drm/fsl-dcu: remove dependency on DRM simple helpers
>        drm/kmb: remove dependency on DRM simple helpers
>        drm/virtio: remove dependency on DRM simple helpers
>        drm/tidss: remove dependency on DRM simple helpers
>        drm/imx: remove dependency on DRM simple helpers
>        drm/mediatek: remove dependency on DRM simple helpers
>        drm/renesas/shmobile: remove dependency on DRM simple helpers
>        drm/hisilicon/kirin: remove dependency on DRM simple helpers
>        drm/arm/komeda: remove dependency on DRM simple helpers
>        drm/meson: remove dependency on DRM simple helpers
>        drm/drm_simple: remove deprecated drm_simple_encoder_init function
>        Documentation/gpu: remove completed drm_simple_encoder_init() todo
>
>   Documentation/gpu/todo.rst                        | 15 ---------------
>   drivers/gpu/drm/arm/display/komeda/komeda_crtc.c  |  9 +++++++--
>   drivers/gpu/drm/drm_simple_kms_helper.c           | 13 ++-----------
>   drivers/gpu/drm/exynos/exynos_dp.c                | 13 +++++++++++--
>   drivers/gpu/drm/exynos/exynos_drm_dpi.c           | 13 +++++++++++--
>   drivers/gpu/drm/exynos/exynos_drm_dsi.c           | 11 +++++++++--
>   drivers/gpu/drm/exynos/exynos_drm_vidi.c          | 13 +++++++++++--
>   drivers/gpu/drm/exynos/exynos_hdmi.c              | 14 ++++++++++++--
>   drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c         | 10 +++++++---
>   drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c      |  9 +++++++--
>   drivers/gpu/drm/imx/dc/dc-kms.c                   |  8 ++++++--
>   drivers/gpu/drm/kmb/kmb_dsi.c                     |  9 +++++++--
>   drivers/gpu/drm/mediatek/mtk_dsi.c                | 10 +++++++---
>   drivers/gpu/drm/meson/meson_encoder_cvbs.c        | 11 ++++++++---
>   drivers/gpu/drm/meson/meson_encoder_dsi.c         | 11 ++++++++---
>   drivers/gpu/drm/meson/meson_encoder_hdmi.c        | 11 ++++++++---
>   drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 10 +++++++---
>   drivers/gpu/drm/tegra/dsi.c                       | 16 +++++++++++++---
>   drivers/gpu/drm/tegra/rgb.c                       | 15 +++++++++++++--
>   drivers/gpu/drm/tidss/tidss_encoder.c             | 10 +++++++---
>   drivers/gpu/drm/virtio/virtgpu_display.c          | 12 ++++++++++--
>   drivers/gpu/drm/xlnx/zynqmp_kms.c                 | 14 ++++++++++++--
>   include/drm/drm_simple_kms_helper.h               |  4 ----
>   23 files changed, 183 insertions(+), 78 deletions(-)
> ---
> base-commit: e1113c37ba4f166e37dec74a729e6dfd8cba1687
> change-id: 20260718-drm_simple_encoder_init-d069a4cc7f8b
>
> Best regards,
> --
> Diogo Silva <diogompaissilva@gmail.com>
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)