From: Andrew Lunn <andrew@lunn.ch>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "Chester A. Unal" <chester.a.unal@arinc9.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next v5 0/9] net: dsa: mt7530: modernise register access and add two DSA ops
Date: Wed, 2 Sep 2026 14:34:26 +0200 [thread overview]
Message-ID: <e3b0d41a-ff23-4dc2-aa8e-3fc279f750fa@lunn.ch> (raw)
In-Reply-To: <cover.1788190568.git.daniel@makrotopia.org>
On Mon, Aug 31, 2026 at 04:37:43PM +0100, Daniel Golle wrote:
> The mt7530 driver carries its own register accessors that predate the
> regmap conversion and now largely duplicate what regmap already
> provides, including locking. Most of this series removes that layer.
>
> It first moves the MDIO bus locking into the switch regmap via
> .lock/.unlock callbacks, matching the PCS regmaps, so any path reaching
> the regmap is serialised automatically. With the wrappers no longer
> adding locking, the thin mt7530_mii_* indirection is folded away and the
> remaining accessors are replaced mechanically with the plain regmap API,
> using the coccinelle semantic patches included in the commit messages.
> The two remaining reset polls are converted to
> regmap_read_poll_timeout() and the then-unused dummy poll machinery is
> dropped. Open-coded register fields are converted to
> FIELD_GET/FIELD_PREP. None of this is intended to change behaviour.
>
> The last two patches implement .port_fast_age, which flushes dynamically
> learned MAC entries on topology changes, and .port_change_conduit, which
> moves a user port's CPU-port affinity at runtime.
>
> The swallowed MDIO errors Sashiko flagged on v4 5/8 have meanwhile been
> fixed in tree by "fix swallowed MDIO read errors" and "fix remaining
> swallowed MDIO access errors", both merged into net-next. This respin is
> rebased on top of them: regmap_* return values are no longer ignored,
> which is what most of the semantic patches had to be reworked for.
I only had a quick look at the series, but it seems O.K. to me.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2026-09-02 12:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 15:37 [PATCH net-next v5 0/9] net: dsa: mt7530: modernise register access and add two DSA ops Daniel Golle
2026-08-31 15:37 ` [PATCH net-next v5 1/9] net: dsa: mt7530: move MDIO bus locking into regmap Daniel Golle
2026-08-31 15:38 ` [PATCH net-next v5 2/9] net: dsa: mt7530: fold mt7530_mii_write/read into mt7530_write/read Daniel Golle
2026-08-31 15:38 ` [PATCH net-next v5 3/9] net: dsa: mt7530: replace mt7530_write with regmap_write Daniel Golle
2026-08-31 15:38 ` [PATCH net-next v5 4/9] net: dsa: mt7530: replace mt7530_rmw/set/clear with regmap API Daniel Golle
2026-08-31 15:38 ` [PATCH net-next v5 5/9] net: dsa: mt7530: replace mt7530_read with regmap_read Daniel Golle
2026-08-31 15:38 ` [PATCH net-next v5 6/9] net: dsa: mt7530: drop the dummy poll machinery Daniel Golle
2026-08-31 15:39 ` [PATCH net-next v5 7/9] net: dsa: mt7530: convert to use field accessor macros Daniel Golle
2026-08-31 15:39 ` [PATCH net-next v5 8/9] net: dsa: mt7530: implement port_fast_age Daniel Golle
2026-08-31 15:39 ` [PATCH net-next v5 9/9] net: dsa: mt7530: implement port_change_conduit op Daniel Golle
2026-09-02 12:34 ` Andrew Lunn [this message]
2026-09-03 2:20 ` [PATCH net-next v5 0/9] net: dsa: mt7530: modernise register access and add two DSA ops patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3b0d41a-ff23-4dc2-aa8e-3fc279f750fa@lunn.ch \
--to=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chester.a.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox