From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DF7C432BE for ; Wed, 1 Sep 2021 02:56:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60D8B60F12 for ; Wed, 1 Sep 2021 02:56:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 60D8B60F12 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/FeIX1hkOMyBlxFqRHWRBu6q4k3wWqJv8rTdKKFBbgE=; b=pyejzyFM27/bOs I/0BXb4jf2AwpnrURHeuzuEA4koTKMbRjpox+A5tgezbwwGHOj3CoeN9J7CQ6FLAOksgbCDTPstgr ARmo8DNZiOU2sxwEHB8EKGxAp20ngoRWjUtLRIXU1MoKLJpV99F4Lzc4NZz9j12SVX2Nf/7+J3eU+ i/Tnt4xCZ0TFLN27/gaIdgPV32LgHZK2+T/ZX6ePQrbci23FHEISk10apcf75tFtUe2Q1y0+rvNmD hbNmmJmxjnx0O6E1lXeAsGTsoCITztCPmNBTDPAeTw0ZrXRLw1HaJqYQ1QxSIlmNle7l2SULqmPLw FRe2U1HEFy5UgUzM57OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLGPz-003cOA-Q5; Wed, 01 Sep 2021 02:56:03 +0000 Received: from mail-pg1-f173.google.com ([209.85.215.173]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLGPx-003cNX-FS for linux-mediatek@lists.infradead.org; Wed, 01 Sep 2021 02:56:02 +0000 Received: by mail-pg1-f173.google.com with SMTP id w8so1293388pgf.5 for ; Tue, 31 Aug 2021 19:56:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sLupmFKaKQRcnyvHnmavhP0aDh9A0FzUOsF+oM0jF48=; b=HHkkCc5wJM0vw3l3iMmEoovXJvq6XcKBPcmdYlsA1mlfs31Cpckz2FPqWI/q6YrOhx eR77T4VCqLT/y9UTon3W2XyfWU02pEucyeGATn5sG88dv9AqZuQ/toWbmtHsD8+muy1h WYz533xD04SLCieSkQuX8VkAI0Jz9N+LiWtRHL2R2JXVdh59FwdVqREY9whxj8amD9LY 3z0oED1keUunkG0aE9gJNi2TNvBiliBQXfsLnRzGiDKx25oO07rCHKh/YMfqKa69uMMr XQL2iJaxQu6WTmb1+7w3cCRuBq/LiettGK1hzP8YVv9q23cO7k66ikuAxSJKHfwslDgP 9f4Q== X-Gm-Message-State: AOAM5323/gu0LfSYGuPseSoS/1LI0l6O07irQxp5ZiYsE2m8WxDFnkXl 0beR8yIU+DrVSfaCzajvrDs= X-Google-Smtp-Source: ABdhPJxsukK2NE3tWjLoXT6l1cxl2cAiJBiAB+eEP3Uc4ngLpvYhkRLdnt3WRtf5yl+etkaVik8Xag== X-Received: by 2002:a65:648b:: with SMTP id e11mr29592431pgv.138.1630464959659; Tue, 31 Aug 2021 19:55:59 -0700 (PDT) Received: from ?IPV6:2601:647:4000:d7:2f84:a3f9:160a:bc19? ([2601:647:4000:d7:2f84:a3f9:160a:bc19]) by smtp.gmail.com with UTF8SMTPSA id b5sm14717250pfr.26.2021.08.31.19.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 19:55:58 -0700 (PDT) Message-ID: Date: Tue, 31 Aug 2021 19:55:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.1 Subject: Re: [PATCH v1] scsi: ufs: ufs-mediatek: Change dbg select by check hw version Content-Language: en-US To: Peter Wang , stanley.chu@mediatek.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org, chun-hung.wu@mediatek.com, alice.chao@mediatek.com, cc.chou@mediatek.com, chaotian.jing@mediatek.com, jiajie.hao@mediatek.com, powen.kao@mediatek.com, jonathan.hsu@mediatek.com, qilin.tan@mediatek.com, lin.gui@mediatek.com References: <1630325486-11741-1-git-send-email-peter.wang@mediatek.com> From: Bart Van Assche In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210831_195601_574270_D1204E8D X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 8/31/21 19:29, Peter Wang wrote: > REG_UFS_MTK_HW_VER is a read only mediatek dedicated register. > So, hw_ver will get a const value for mediatek to decide how to use > debug select. It only need read once, no need multi-threads protected. Hi Peter, The above can be concluded easily by a human but not by software. If this code is analyzed with KCSAN then KCSAN will probably complain. See also Documentation/dev-tools/kcsan.rst. Anyway, I'm fine with this patch. Thanks, Bart. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek