From: Matthias Brugger <matthias.bgg@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Alexandre Mergnat <amergnat@baylibre.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] ASoC: mediatek: mt8365: include linux/bitfield.h
Date: Mon, 9 Sep 2024 08:59:19 +0200 [thread overview]
Message-ID: <e419964e-0da6-4257-bc0b-40db42399465@kernel.org> (raw)
In-Reply-To: <20240908221754.2210857-1-arnd@kernel.org>
On 09/09/2024 00:17, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> On x86, the header is not already included implicitly,
> breaking compile-testing:
>
> In file included from sound/soc/mediatek/mt8365/mt8365-afe-common.h:19,
> from sound/soc/mediatek/mt8365/mt8365-afe-pcm.c:18:
> sound/soc/mediatek/mt8365/mt8365-afe-pcm.c: In function 'mt8365_afe_cm2_mux_conn':
> sound/soc/mediatek/mt8365/mt8365-reg.h:952:41: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
> 952 | #define CM2_AFE_CM2_CONN_CFG1(x) FIELD_PREP(CM2_AFE_CM2_CONN_CFG1_MASK, (x))
> | ^~~~~~~~~~
>
> Included it ahead of the field definitions.
>
> Fixes: 38c7c9ddc740 ("ASoC: mediatek: mt8365: Add common header")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>
> This started happening after I applied "ASoC: mt8365: Allow build coverage".
> ---
> sound/soc/mediatek/mt8365/mt8365-reg.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/mediatek/mt8365/mt8365-reg.h b/sound/soc/mediatek/mt8365/mt8365-reg.h
> index b763cddc93db..4ebbb94ff02e 100644
> --- a/sound/soc/mediatek/mt8365/mt8365-reg.h
> +++ b/sound/soc/mediatek/mt8365/mt8365-reg.h
> @@ -10,6 +10,8 @@
> #ifndef _MT8365_REG_H_
> #define _MT8365_REG_H_
>
> +#include <linux/bitfield.h>
> +
> #define AUDIO_TOP_CON0 (0x0000)
> #define AUDIO_TOP_CON1 (0x0004)
> #define AUDIO_TOP_CON2 (0x0008)
next prev parent reply other threads:[~2024-09-09 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 22:17 [PATCH] ASoC: mediatek: mt8365: include linux/bitfield.h Arnd Bergmann
2024-09-09 6:59 ` Matthias Brugger [this message]
2024-09-09 17:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e419964e-0da6-4257-bc0b-40db42399465@kernel.org \
--to=matthias.bgg@kernel.org \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox